Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update intra-doc link documentation to match the implementation #80874

Merged
merged 7 commits into from
Mar 2, 2021
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 59 additions & 8 deletions src/doc/rustdoc/src/linking-to-items-by-name.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Linking to items by name

Rustdoc is capable of directly linking to other rustdoc pages using the path of
the item as a link.
the item as a link. This is referred to as an 'intra-doc link'.

For example, in the following code all of the links will link to the rustdoc page for `Bar`:

Expand All @@ -24,11 +24,29 @@ pub struct Foo4;
pub struct Bar;
```

Unlike normal markdown, `[bar][Bar]` syntax is also supported without needing a
jyn514 marked this conversation as resolved.
Show resolved Hide resolved
`[Bar]: ...` reference link, and links are case-sensitive.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably note somewhere that non-intra-doc links are case-insensitive; see #80882.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, #80882 is a mess. I think I'd prefer to see what the plan is there before updating the documentation.


Backticks around the link will be stripped, so ``[`Option`]`` will correctly
link to `Option`.

You can refer to anything in scope, and use paths, including `Self`, `self`,
`super`, and `crate`. You may also use `foo()` and `foo!()` to refer to methods/functions and macros, respectively.
## Valid links

You can refer to anything in scope, and use paths, including `Self`, `self`, `super`, and
`crate`. Associated items (functions, types, and constants) are supported, but [not for blanket
trait implementations][#79682]. Rustdoc also supports linking to the following primitives, which
have no path and cannot be imported:

- [`slice`](https://doc.rust-lang.org/std/primitive.slice.html)
- [`array`](https://doc.rust-lang.org/std/primitive.array.html)
- [`tuple`](https://doc.rust-lang.org/std/primitive.tuple.html)
- [`unit`](https://doc.rust-lang.org/std/primitive.unit.html)
- [`fn`](https://doc.rust-lang.org/std/primitive.fn.html)
- [`pointer`](https://doc.rust-lang.org/std/primitive.pointer.html), `*`, `*const`, or `*mut`
- [`reference`](https://doc.rust-lang.org/std/primitive.reference.html), `&`, or `&mut`
- [`never`](https://doc.rust-lang.org/std/primitive.never.html) or `!`
jyn514 marked this conversation as resolved.
Show resolved Hide resolved

camelid marked this conversation as resolved.
Show resolved Hide resolved
[#79682]: https://github.com/rust-lang/rust/pull/79682

You can also refer to items with generic parameters like `Vec<T>`. The link will
resolve as if you had written ``[`Vec<T>`](Vec)``. Fully-qualified syntax (for example,
Expand All @@ -53,7 +71,7 @@ impl<T> AsyncReceiver<T> {
}
```

You can also link to sections using URL fragment specifiers:
Rustdoc allows using URL fragment specifiers, just like a normal link:

```rust
/// This is a special implementation of [positional parameters].
Expand All @@ -62,9 +80,13 @@ You can also link to sections using URL fragment specifiers:
struct MySpecialFormatter;
```

Paths in Rust have three namespaces: type, value, and macro. Item names must be
unique within their namespace, but can overlap with items outside of their
namespace. In case of ambiguity, rustdoc will warn about the ambiguity and ask you to disambiguate, which can be done by using a prefix like `struct@`, `enum@`, `type@`, `trait@`, `union@`, `const@`, `static@`, `value@`, `fn@`, `function@`, `mod@`, `module@`, `method@`, `prim@`, `primitive@`, `macro@`, or `derive@`:
## Namespaces and Disambiguators

Paths in Rust have three namespaces: type, value, and macro. Item names must be unique within
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may not be necessary, but do you want to note that the type namespace includes modules?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer not to; if you get it wrong it will be clear from the error message. If we mention modules we should also say functions are in the value namespace, though.

their namespace, but can overlap with items outside of their namespace. In case of ambiguity,
jyn514 marked this conversation as resolved.
Show resolved Hide resolved
rustdoc will warn about the ambiguity and ask you to disambiguate, which can be done by using a
prefix like `struct@`, `enum@`, `type@`, `trait@`, `union@`, `const@`, `static@`, `value@`,
`fn@`, `function@`, `mod@`, `module@`, `method@`, `prim@`, `primitive@`, `macro@`, or `derive@`:
jyn514 marked this conversation as resolved.
Show resolved Hide resolved

```rust
/// See also: [`Foo`](struct@Foo)
Expand All @@ -76,6 +98,9 @@ struct Foo {}
fn Foo() {}
```

These prefixes will be stripped when displayed in the documentation, so `[struct@Foo]`
will be rendered as `Foo`.

You can also disambiguate for functions by adding `()` after the function name,
or for macros by adding `!` after the macro name:

Expand All @@ -89,6 +114,32 @@ struct Foo {}
fn Foo() {}
```

Note: Because of how `macro_rules!` macros are scoped in Rust, the intra-doc links of a `macro_rules!` macro will be resolved [relative to the crate root][#72243], as opposed to the module it is defined in.
## Warnings, re-exports, and scoping

Links are resolved in the current module scope, even when re-exported. If a link from another
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "even when re-exported" mean here? Can you elaborate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#73101, basically. If you re-export an item it doesn't affect how rustdoc treats the links, they'll still resolve the same.

crate fails to resolve, no warning is given.

When re-exporting an item, rustdoc allows additional documentation to it. That documentation will
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing a word here.

Suggested change
When re-exporting an item, rustdoc allows additional documentation to it. That documentation will
When re-exporting an item, rustdoc allows adding additional documentation to it. That documentation will

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably define what re-exports are or link to the doc(inline) page somewhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it worked before, but sure, I added the extra word.

We should probably define what re-exports are or link to the doc(inline) page somewhere.

Do you think we need to? I think the example makes it pretty clear.

be resolved in the new scope, not the original, allowing you to link to items in the current
crate. The new links will still give a warning if they fail to resolve.
jyn514 marked this conversation as resolved.
Show resolved Hide resolved

```rust
/// See also [foo()]
pub use std::process::Command;

pub fn foo() {}
```

This is especially useful for proc-macros, which must always be in their own dedicated crate.
jyn514 marked this conversation as resolved.
Show resolved Hide resolved

Note: Because of how `macro_rules!` macros are scoped in Rust, the intra-doc links of a
`macro_rules!` macro will be resolved [relative to the crate root][#72243], as opposed to the
module it is defined in.

If links do not look 'sufficiently like' an intra-doc link, they will be ignored and no warning
will be given, even if the link fails to resolve. For example, any link containing `/` or `[]`
characters will be ignored. You can see the full criteria for 'sufficiently like' in [the source
code].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it's a good idea to link to the source code here. For one, it will very easily become out-of-date because it's tied to a particular commit. I think we should either skip this or include the list directly in the documentation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I kind of prefer not to tie this down so we can update it in the future. Maybe I could change the commit hash to master instead? That might have wrong line numbers though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I could change the commit hash to master instead? That might have wrong line numbers though.

Yeah, I think that would be very confusing.

Hmm, I kind of prefer not to tie this down so we can update it in the future.

What do you mean? Documenting it isn't "tying it down".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this is a not a reference, this is a book, and I don't think it should go into that much detail. We do not need to document every last corner of the implementation here. Let's just drop this section.


[#72243]: https://github.com/rust-lang/rust/issues/72243
[the source code]: https://github.com/rust-lang/rust/blob/34628e5b533d35840b61c5db0665cf7633ed3c5a/src/librustdoc/passes/collect_intra_doc_links.rs#L982