Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-stabilize Weak::as_ptr and friends for unsized T #80764

Merged
merged 8 commits into from
Jan 16, 2021
Merged

Re-stabilize Weak::as_ptr and friends for unsized T #80764

merged 8 commits into from
Jan 16, 2021

Commits on Jan 7, 2021

  1. Re-stabilize Weak::as_ptr &friends for unsized T 

    As per T-lang consensus, this uses a branch to handle the dangling case.
The discussed optimization of only doing the branch in the T: ?Sized
case is left for a followup patch, as doing so is not trivial
(as it requires specialization for correctness, not just optimization).
    @CAD97
    CAD97 committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    6bc772c View commit details
    Browse the repository at this point in the history

  2. Tighten/clarify documentation of rc data_offset

    @CAD97
    CAD97 committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    f00b458 View commit details
    Browse the repository at this point in the history

  3. Remove "pointer describes" terminology

    @CAD97
    CAD97 committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    b10b9e2 View commit details
    Browse the repository at this point in the history

  4. Reclarify Weak<->raw pointer safety comments

    @CAD97
    CAD97 committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    1e578c9 View commit details
    Browse the repository at this point in the history

  5. Replace set_data_ptr with pointer::set_ptr_value

    @CAD97
    CAD97 committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    4901c55 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2021

  1. Provide reasoning for rc data_offset safety

    @CAD97
    CAD97 committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    747dbcb View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2021

  1. Weak::into_raw shouldn't translate sentinel value

    @CAD97
    CAD97 committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    b5b6760 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Ralf Jung <[email protected]>
    @CAD97 @RalfJung
    CAD97 and RalfJung authored Jan 13, 2021
    Configuration menu
    Copy the full SHA
    c14e919 View commit details
    Browse the repository at this point in the history