-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Source Code Pro and include italics #80705
Update Source Code Pro and include italics #80705
Conversation
Some changes occurred in HTML/CSS/JS. |
(rust-highfive has picked a reviewer for you, use r? to override) |
You mean, update ESSENTIAL_FILES_VERSIONED? |
Looks good to me, thanks! Now we just need to sync with docs.rs and I think we're good to go. |
Could someone please explain what they mean by 'sync with docs.rs'? |
Someone can explain: you'll need to update the font file on docs.rs but I don't know the process. If there is nothing particular to be done, then we can simply merge this PR. :) |
Ok. Docs.rs can only be updated after this is merged, because it requires those files to exist and gives an error otherwise. So this needs to make it to a nightly before docs.rs can be updated I think. @rust-lang/docs-rs please correct me if I'm wrong. |
Yeah we'll need to update the essential files list. To avoid generating broken docs I think the best approach is to pin the docs.rs nightly to a known good one before merging this PR, merge the PR, update the docs.rs code to copy the file and then remove the pin. |
Triage: What's the current status? |
☔ The latest upstream changes (presumably #82756) made this pull request unmergeable. Please resolve the merge conflicts. |
a80ef80
to
d78ccd3
Compare
Rebased and updated fonts to the upstream 2.038R-ro/1.058R-it/1.018R-VAR release. |
☔ The latest upstream changes (presumably #82777) made this pull request unmergeable. Please resolve the merge conflicts. |
d78ccd3
to
6f7ebb5
Compare
☔ The latest upstream changes (presumably #82851) made this pull request unmergeable. Please resolve the merge conflicts. |
6f7ebb5
to
8415cdf
Compare
This comment has been minimized.
This comment has been minimized.
8415cdf
to
3ba2136
Compare
3ba2136
to
87d17bb
Compare
@jyn514 Should we wait for rust-lang/docs.rs#1302 or can we r+ it? |
I would prefer to wait for rust-lang/docs.rs#1302 if possible. If it takes more than another week or so I'm ok with approving this and fixing the breakage when it occurs. |
@bors r=GuillaumeGomez |
📌 Commit 87d17bb has been approved by |
Rollup of 7 pull requests Successful merges: - rust-lang#80705 (Update Source Code Pro and include italics) - rust-lang#81917 (Update RELEASES.md for 1.51.0) - rust-lang#82732 (Remove theme.js file) - rust-lang#83356 (rustdoc: Replace pair of `Option`s with an enum) - rust-lang#83384 (rename :pat2018 -> :pat2015) - rust-lang#83385 (:arrow_up: rust-analyzer) - rust-lang#83389 (add rust-analyzer rustc_private option in librustdoc Cargo.toml) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes #65502.
#65665, a similar PR to this was merged but reverted because of #65665 (comment).
The issue in that comment is the upstream issue adobe-fonts/source-code-pro#217 which should now be fixed in the upstream since 2.032R-ro/1.052R-it/1.012R-VAR release, so I think this can now be merged.
A couple of notes from the original PR: