-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "chr" as doc alias to char::from_u32 #80431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 28, 2020
Why |
|
steveklabnik
approved these changes
Dec 28, 2020
Yep, this is great, thanks a ton! @bors: r+ rollup |
📌 Commit b3be9e1 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 28, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 29, 2020
Rollup of 11 pull requests Successful merges: - rust-lang#80383 (clarify wrapping ptr arithmetic docs) - rust-lang#80390 (BTreeMap: rename the area access methods) - rust-lang#80393 (Add links to the source for the rustc and rustdoc books.) - rust-lang#80398 (Use raw version of align_of in rc data_offset) - rust-lang#80402 (Document `InferTy` & co.) - rust-lang#80403 (fix: small typo error in chalk/mod.rs) - rust-lang#80410 (rustdoc book: fix example) - rust-lang#80419 (Add regression test for rust-lang#80375) - rust-lang#80430 (Add "length" as doc alias to len methods) - rust-lang#80431 (Add "chr" as doc alias to char::from_u32) - rust-lang#80448 (Fix stabilization version of deque_range feature.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many programming languages provide a function called
chr
- Perl, Python, PHP, Visual Basic, SQL. This change makeschar::from_u32
easier to discover in the documentation.ord
is not added as its name conflicts withOrd
trait, and it's not exactly clear what it could point to (<u32 as From<char>>::from
?). I don't think it's exactly necessary, aschar::from_u32
documentation page says you can do reverse conversion withas
operator anyway.