Rustdoc render public underscore_imports as Re-exports #80267
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ollie27 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
jyn514
added
the
T-rustdoc
jyn514
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/librustdoc/clean/mod.rs
Outdated
| if pub_underscore && inlined { | ||
| rustc_errors::struct_span_err!( | ||
| cx.tcx.sess, | ||
| self.attrs.lists(sym::doc).next().unwrap().span(), |
There was a problem hiding this comment.
This might be wrong if there are multiple doc attributes. Can you add a test case for
#[doc = "xxx"]
#[doc(inline)]
pub use foo::Foo as _;There was a problem hiding this comment.
This was working as is, maybe because of https://github.com/rust-lang/rust/blob/master/compiler/rustc_ast/src/ast.rs#L496.
Just to be safe it was changed and made some other refactoring to use the previous calculated values.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors r+ squash |
|
📌 Commit 1990713 has been approved by |
bors
added
S-waiting-on-bors
Rustdoc render public underscore_imports as Re-exports Fixes rust-lang#61592
Rustdoc render public underscore_imports as Re-exports Fixes rust-lang#61592
|
☀️ Test successful - checks-actions |
|
Oh right, I forgot that |
Fixes #61592