Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove giant badge in README #80144

Merged
merged 2 commits into from
Jan 16, 2021
Merged

Remove giant badge in README #80144

merged 2 commits into from
Jan 16, 2021

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Dec 18, 2020

Is it meant to be this big? I haven't seen any other open source project with this sort of thing

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 18, 2020
@Mark-Simulacrum
Copy link
Member

@nikomatsakis and @steveklabnik seemed in favor on #73649 which added this badge - I'd be fine with shrinking it down or removing it personally, I agree it seems rather odd right now.

@camelid
Copy link
Member

camelid commented Dec 22, 2020

I would also like to remove this. Ideally we could go back to something like how it was before:

# The Rust Programming Language

@camelid camelid added the A-meta Area: Issues & PRs about the rust-lang/rust repository itself label Dec 22, 2020
@Mark-Simulacrum
Copy link
Member

I'm going to wait till after the holidays to approve, in case Steve or Niko want to chime in, but I don't think a header is too helpful. The first paragraph gets right into what this repository is; we don't need a header to signal that too.

@camelid
Copy link
Member

camelid commented Dec 23, 2020

I'm going to wait till after the holidays to approve, in case Steve or Niko want to chime in

👍

but I don't think a header is too helpful. The first paragraph gets right into what this repository is; we don't need a header to signal that too.

Yes, but practically every open-source project has a header. The page looks kind of “naked” without a title at the top. But we can talk about this after the holidays.

@frewsxcv
Copy link
Member Author

Brought back a top-level heading in d2cc79e

@steveklabnik
Copy link
Member

I like it either way. Constantly churning on this isn't great though.

@camelid
Copy link
Member

camelid commented Dec 28, 2020

I think we'll wait to get Niko's feedback and then merge this if he's okay with it, since it seems we're either neutral or prefer the simple heading.

Constantly churning on this isn't great though.

Yeah, hopefully we won't change this any more. IMO, the badge looks really weird and out-of-place.

@crlf0710
Copy link
Member

r? @nikomatsakis

@nikomatsakis
Copy link
Contributor

Hey all, I'm catching up on my review queue. I don't have a strong opinion about this, but doing a quick survey of other languages (Go, Ruby, Python) I agree the badge seems unusual (although I do like having the logo). I'm going to r+ but I wanted to cc @Anirban166 (who added the badge) so they're not surprised by the change.

@bors r+

@bors
Copy link
Contributor

bors commented Jan 16, 2021

📌 Commit d2cc79e has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2021
@nikomatsakis
Copy link
Contributor

@bors rollup

m-ou-se added a commit to m-ou-se/rust that referenced this pull request Jan 16, 2021
…atsakis

Remove giant badge in README

Is it meant to be this big? I haven't seen any other open source project with this sort of thing
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 16, 2021
Rollup of 17 pull requests

Successful merges:

 - rust-lang#78455 (Introduce {Ref, RefMut}::try_map for optional projections in RefCell)
 - rust-lang#80144 (Remove giant badge in README)
 - rust-lang#80614 (Explain why borrows can't be held across yield point in async blocks)
 - rust-lang#80670 (TrustedRandomAaccess specialization composes incorrectly for nested iter::Zips)
 - rust-lang#80681 (Clarify what the effects of a 'logic error' are)
 - rust-lang#80764 (Re-stabilize Weak::as_ptr and friends for unsized T)
 - rust-lang#80901 (Make `x.py --color always` apply to logging too)
 - rust-lang#80902 (Add a regression test for rust-lang#76281)
 - rust-lang#80941 (Do not suggest invalid code in pattern with loop)
 - rust-lang#80968 (Stabilize the poll_map feature)
 - rust-lang#80971 (Put all feature gate tests under `feature-gates/`)
 - rust-lang#81021 (Remove doctree::Import)
 - rust-lang#81040 (doctest: Reset errors before dropping the parse session)
 - rust-lang#81060 (Add a regression test for rust-lang#50041)
 - rust-lang#81065 (codegen_cranelift: Fix redundant semicolon warn)
 - rust-lang#81069 (Add sample code for Rc::new_cyclic)
 - rust-lang#81081 (Add test for rust-lang#34792)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d2b63d4 into master Jan 16, 2021
@bors bors deleted the frewsxcv-patch-3 branch January 16, 2021 23:15
@rustbot rustbot added this to the 1.51.0 milestone Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants