Cleanup librustpkg a little bit. #7866
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@sstewartgallus: seems there's already a conflict |
src/librustpkg/package_source.rs
Outdated
Contributor
There was a problem hiding this comment.
This can probably be some s == pth.slice_from(5) (or with s.as_slice(), or the arguments flipped).
Contributor
Author
|
Okay, so I made this not fail the tests anymore but to accomplish that I had to revert a little bit of the code that I couldn't figure out. I'm not happy with that but everything else is good, and can go forward. |
Contributor
|
@sstewartgallus needs a rebase again :( |
Contributor
Author
|
Rebased. |
Mostly I did simple transformations from imperative style loops to more functional iterator based transformations.
Contributor
Author
|
Rebased again. |
bors
added a commit
that referenced
this pull request
Aug 13, 2013
Mostly I did simple transformations from imperative style loops to more functional iterator based transformations.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 4, 2021
…earth update most tests to 2021 edition Some tests would no longer work at all, so I added `edition:2015` or `edition:2018` to them. Notably 2021 panics are not yet detected correctly. Once ready, this closes rust-lang#7842. --- changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly I did simple transformations from imperative style loops to
more functional iterator based transformations.