Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delay_span_bug to no longer ICE #78645

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Conversation

JulianKnodt
Copy link
Contributor

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 1, 2020
@JulianKnodt
Copy link
Contributor Author

JulianKnodt commented Nov 1, 2020

cc @estebank because I accidentally sniped the issue

@estebank
Copy link
Contributor

estebank commented Nov 1, 2020

r? @estebank

@bors r+

@bors
Copy link
Contributor

bors commented Nov 1, 2020

📌 Commit ab946dd has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2020
@estebank estebank added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 1, 2020
@bors
Copy link
Contributor

bors commented Nov 2, 2020

⌛ Testing commit ab946dd with merge d8ef0d7...

@bors
Copy link
Contributor

bors commented Nov 2, 2020

☀️ Test successful - checks-actions
Approved by: estebank
Pushing d8ef0d7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 2, 2020
@bors bors merged commit d8ef0d7 into rust-lang:master Nov 2, 2020
@rustbot rustbot added this to the 1.49.0 milestone Nov 2, 2020
@JulianKnodt JulianKnodt deleted the i78622 branch November 2, 2020 07:22
@pnkfelix
Copy link
Member

pnkfelix commented Nov 5, 2020

I'm doing a unilateral beta approve here.

@pnkfelix pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Nov 5, 2020
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 5, 2020
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.49.0, 1.48.0 Nov 5, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 7, 2020
…ulacrum

[beta] backports

This backports a number of PRs to beta:

* Add delay_span_bug to no longer ICE rust-lang#78645
* Do not ICE on invalid input rust-lang#78422
* revert rust-lang#75443, update mir validator rust-lang#78410
* Do not try to report on closures to avoid ICE rust-lang#78268
* Disable "optimization to avoid load of address" in InstCombine rust-lang#78195
* Disable MatchBranchSimplification rust-lang#78151
* Do not ICE with TraitPredicates containing [type error] rust-lang#77930
* Tweak `if let` suggestion to be more liberal with suggestion and to not ICE rust-lang#77283
* Use different mirror for linux headers in musl-toolchain CI script. rust-lang#78316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: compiler/rustc_typeck/src/collect/type_of.rs:82:26: unexpected const parent path Expr(...)
8 participants