Skip to content

[beta] Disable ThinLTO for x86_64-unknown-linux-gnu #78148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2020
Merged

[beta] Disable ThinLTO for x86_64-unknown-linux-gnu #78148

merged 1 commit into from
Oct 21, 2020

Conversation

@Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Oct 20, 2020

Temporarily addresses #76980 for 1.48 release.

r? @pietroalbini

@rust-highfive
Copy link
Contributor

rust-highfive commented Oct 20, 2020

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Oct 20, 2020
Open
@pietroalbini
Copy link
Member

pietroalbini commented Oct 20, 2020

@bors r+ p=5

@bors
Copy link
Collaborator

bors commented Oct 20, 2020

📌 Commit 5e7114a has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2020
@Dylan-DPC-zz
Copy link

Dylan-DPC-zz commented Oct 20, 2020

let this go ahead of the rollup

@bors p=10

@bors
Copy link
Collaborator

bors commented Oct 20, 2020

⌛ Testing commit 5e7114a with merge 5340da3a6ebd379058365b1179271874018f09c4...

@bors
Copy link
Collaborator

bors commented Oct 20, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 20, 2020
@Dylan-DPC-zz
Copy link

Dylan-DPC-zz commented Oct 20, 2020

@Mark-Simulacrum spurious?

@Mark-Simulacrum
Copy link
Member Author

Mark-Simulacrum commented Oct 20, 2020

@bors retry

I don't see any builders that failed, so I think so.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2020
@bors
Copy link
Collaborator

bors commented Oct 21, 2020

⌛ Testing commit 5e7114a with merge 7611972c6833805aed832933c89a0af72479eaac...

@bors
Copy link
Collaborator

bors commented Oct 21, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 21, 2020
@JohnTitor
Copy link
Member

JohnTitor commented Oct 21, 2020

Should be spurious, @bors retry

 Downloading crates ...
warning: spurious network error (2 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/colored/2.0.0/download`, got 502
warning: spurious network error (1 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/colored/2.0.0/download`, got 502
thread 'main' panicked at 'packages downloaded: failed to download from `https://crates.io/api/v1/crates/colored/2.0.0/download`

Caused by:
    failed to get 200 response from `https://crates.io/api/v1/crates/colored/2.0.0/download`, got 502', src/tools/cargo/src/cargo/ops/cargo_compile.rs:1054:14

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2020
@bors
Copy link
Collaborator

bors commented Oct 21, 2020

⌛ Testing commit 5e7114a with merge b09f746e05134aafe29d3cdaf02d5c820c9aef21...

@bors
Copy link
Collaborator

bors commented Oct 21, 2020

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 21, 2020
@pietroalbini
Copy link
Member

pietroalbini commented Oct 21, 2020

Apple timed out.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2020
@bors
Copy link
Collaborator

bors commented Oct 21, 2020

⌛ Testing commit 5e7114a with merge 4c78178...

@bors
Copy link
Collaborator

bors commented Oct 21, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: pietroalbini
Pushing 4c78178 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 21, 2020
@bors bors merged commit 4c78178 into rust-lang:beta Oct 21, 2020
@rustbot rustbot added this to the 1.48.0 milestone Oct 21, 2020
@pthariensflame
Copy link
Contributor

pthariensflame commented Oct 21, 2020

Does this need relnotes?

@Mark-Simulacrum Mark-Simulacrum deleted the beta-76980 branch October 22, 2020 00:40
@Mark-Simulacrum
Copy link
Member Author

Mark-Simulacrum commented Oct 22, 2020

No, it prevents a regression but shouldn't otherwise be notable.

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pietroalbini pietroalbini

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

8 participants

@Mark-Simulacrum @rust-highfive @pietroalbini @bors @Dylan-DPC-zz @JohnTitor @pthariensflame @rustbot