Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused cached_unreachable_block from MIR builder #78039

Merged
merged 1 commit into from
Oct 17, 2020
Merged

Remove unused cached_unreachable_block from MIR builder #78039

merged 1 commit into from
Oct 17, 2020

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Oct 17, 2020

No description provided.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2020
@Mark-Simulacrum
Copy link
Member

Cc @rust-lang/wg-mir-opt (not quite the right group, but should be close enough)

I think this is reasonable - certainly the code is dead - so going to go ahead and approve.

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Oct 17, 2020

📌 Commit a65a283 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2020
@bors
Copy link
Contributor

bors commented Oct 17, 2020

⌛ Testing commit a65a283 with merge dda2b5e...

@bors
Copy link
Contributor

bors commented Oct 17, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing dda2b5e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 17, 2020
@bors bors merged commit dda2b5e into rust-lang:master Oct 17, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 17, 2020
@tmiasko tmiasko deleted the unreachable-block branch October 17, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tmiasko @rust-highfive @Mark-Simulacrum @bors @rustbot