Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check html comments #77753

Merged
merged 3 commits into from
Oct 15, 2020
Merged

Check html comments #77753

merged 3 commits into from
Oct 15, 2020

Conversation

GuillaumeGomez
Copy link
Member

Part of #67799.

cc @ollie27
r? @jyn514

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2020
@jyn514 jyn514 added A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 9, 2020
jyn514
jyn514 approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! One small nit.

src/librustdoc/passes/html_tags.rs Outdated Show resolved Hide resolved
@jyn514 jyn514 mentioned this pull request Oct 9, 2020
Closed
5 tasks
ollie27
ollie27 suggested changes Oct 10, 2020
View reviewed changes
Copy link
Member

@ollie27 ollie27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This produces a false positive warning if the end of the tag is on a different line like:

/// <!--
/// -->

jyn514
jyn514 approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, but otherwise r=me

src/librustdoc/passes/html_tags.rs Outdated Show resolved Hide resolved
@GuillaumeGomez
Copy link
Member Author

@bors: r=jyn514

@bors
Copy link
Contributor

bors commented Oct 14, 2020

📌 Commit dd3be78 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2020
@bors
Copy link
Contributor

bors commented Oct 14, 2020

⌛ Testing commit dd3be78 with merge ffb8fe51bfaaddf9946aa6dca8b3ebd9f6fa89cb...

@bors
Copy link
Contributor

bors commented Oct 14, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 14, 2020
@jyn514
Copy link
Member

jyn514 commented Oct 14, 2020 

warning: /Applications/Xcode_12.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/include/machine/endian.h:37:2: error: architecture not supported
warning: #error architecture not supported
warning:  ^
warning: 7 errors generated.

error: failed to run custom build command for `profiler_builtins v0.0.0 (/Users/runner/work/rust/rust/library/profiler_builtins)`

@shepmaster do you know what's going on here? This is in the dist-aarch64-apple builder.

@jyn514
Copy link
Member

jyn514 commented Oct 14, 2020

@bors retry

#77940

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2020
@JohnTitor JohnTitor mentioned this pull request Oct 14, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 14, 2020
@bors
Auto merge of rust-lang#77954 - JohnTitor:rollup-bpoy497, r=JohnTitor
f42692b 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#77570 (Allow ascii whitespace char for doc aliases )
 - rust-lang#77739 (Remove unused code)
 - rust-lang#77753 (Check html comments)
 - rust-lang#77879 (Provide better documentation and help messages for x.py setup)
 - rust-lang#77902 (Include aarch64-pc-windows-msvc in the dist manifests)
 - rust-lang#77934 (Document -Z codegen-backend in the unstable book)
 - rust-lang#77936 (Remove needless alloc_slice)
 - rust-lang#77946 (Validate references to source scopes)
 - rust-lang#77951 (Update books)

Failed merges:

r? `@ghost`
@bors bors merged commit 5f5ef05 into rust-lang:master Oct 15, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 15, 2020
@GuillaumeGomez GuillaumeGomez deleted the check-html-comments branch October 15, 2020 08:20
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pickfire pickfire pickfire left review comments

@ollie27 ollie27 ollie27 requested changes

@jyn514 jyn514 jyn514 approved these changes

Assignees

@jyn514 jyn514

Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
7 participants
@GuillaumeGomez @bors @jyn514 @pickfire @ollie27 @rust-highfive @rustbot