Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ThinLTO for x86_64-unknown-linux-gnu #77634

Closed

Conversation

Mark-Simulacrum
Copy link
Member

r? @Mark-Simulacrum

I am opening this to get performance numbers back. I believe it should fix #76980 and is largely something I'd be comfortable putting into stable while we work out the more difficult options on nightly (and perhaps beta).

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2020
@Mark-Simulacrum
Copy link
Member Author

@rust-timer queue @bors try

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Oct 6, 2020

⌛ Trying commit f135c38 with merge 6f967be1d4ff00423ed16df7cb77f4074a9d6b80...

@bors
Copy link
Contributor

bors commented Oct 7, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 6f967be1d4ff00423ed16df7cb77f4074a9d6b80 (6f967be1d4ff00423ed16df7cb77f4074a9d6b80)

@rust-timer
Copy link
Collaborator

Queued 6f967be1d4ff00423ed16df7cb77f4074a9d6b80 with parent 9fdaeb3, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (6f967be1d4ff00423ed16df7cb77f4074a9d6b80): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build hang on Linux
4 participants