Skip to content

Check for missing const-stability attributes in rustc_passes #77203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 4 commits into from
Sep 27, 2020
Merged

Check for missing const-stability attributes in rustc_passes #77203

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61d86fa
Check for missing const-stability attributes in `stability`
ecstatic-morse Sep 25, 2020
11bfc60
Change error in `fn_queries` to `delay_span_bug`
ecstatic-morse Sep 25, 2020
76c6f2d
No need to call `is_min_const_fn` for side-effects
ecstatic-morse Sep 25, 2020
6ce178f
Test for missing const-stability attributes
ecstatic-morse Sep 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/rustc_mir/src/const_eval/fn_queries.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ pub fn is_min_const_fn(tcx: TyCtxt<'_>, def_id: DefId) -> bool {
None => {
if let Some(stab) = tcx.lookup_stability(def_id) {
if stab.level.is_stable() {
tcx.sess.span_err(
Copy link
Contributor

@oli-obk oli-obk Sep 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just span_bug! here now, or is it still reachable even if the stability error was reported?

Copy link
Contributor Author

@ecstatic-morse ecstatic-morse Sep 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is called in check_unsafety, which runs before MissingStabilityAnnotations.

tcx.sess.delay_span_bug(
tcx.def_span(def_id),
"stable const functions must have either `rustc_const_stable` or \
`rustc_const_unstable` attribute",
Expand Down