Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove #[rustc_allow_const_fn_ptr] and add #![feature(const_fn_fn_ptr_basics)] #77170

Merged
merged 6 commits into from
Sep 28, 2020
Merged

Remove #[rustc_allow_const_fn_ptr] and add #![feature(const_fn_fn_ptr_basics)] #77170

merged 6 commits into from
Sep 28, 2020

Commits on Sep 27, 2020

  1. Add a feature gate for basic function pointer use in const fn

    @ecstatic-morse
    ecstatic-morse committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    1ff1431 View commit details
    Browse the repository at this point in the history

  2. Remove rustc_allow_const_fn_ptr 

    This was a hack to work around the lack of an escape hatch for the "min
`const fn`" checks in const-stable functions. Now that we have co-opted
`allow_internal_unstable` for this purpose, we no longer need the
bespoke attribute.
    @ecstatic-morse
    ecstatic-morse committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    3cbd17f View commit details
    Browse the repository at this point in the history

  3. Update tests with new feature gate

    @ecstatic-morse
    ecstatic-morse committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    e2622b9 View commit details
    Browse the repository at this point in the history

  4. Bless tests

    @ecstatic-morse
    ecstatic-morse committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    54d3329 View commit details
    Browse the repository at this point in the history

  5. Mark min_const_fn_fn_ptr test as gate test

    @ecstatic-morse
    ecstatic-morse committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    368502c View commit details
    Browse the repository at this point in the history

  6. Remove feature gate test for rustc_allow_const_fn_ptr

    @ecstatic-morse
    ecstatic-morse committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    807260b View commit details
    Browse the repository at this point in the history