Refactor versions detection in build-manifest #77145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Hm, so we can just merge this, but I'm thinking it would be good to @bors try and try to release a dev-static nightly with it just to test that it works on RCS as well. Unfortunately our CI here doesn't run build manifest in any capacity :/ |
Mark-Simulacrum
added
S-waiting-on-author
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 24, 2020
…versions, r=<try> Refactor versions detection in build-manifest This PR refactors how `build-manifest` handles versions, making the following changes: * `build-manifest` now detects the "package releases" on its own, without relying on rustbuild providing them through CLI arguments. This drastically simplifies calling the tool outside of `x.py`, and will allow to ship the prebuilt tool in a tarball in the future, with the goal of stopping to invoke `x.py` during `promote-release`. * The `tar` command is not used to extract the version and the git hash from tarballs anymore. The `flate2` and `tar` crates are used instead. This makes detecting those pieces of data way faster, as the archive is decompressed just once and we stop parsing the archive once all the information is retrieved. * The code to extract the version and the git hash now stores all the collected data dynamically, without requiring to add new fields to the `Builder` struct every time. I tested the changes locally and it should behave the same as before. r? `@Mark-Simulacrum`
|
☀️ Try build successful - checks-actions, checks-azure |
|
Kicked off promotion. |
|
Promotion ended, it seems to work? |
pietroalbini
force-pushed
the
refactor-build-manifest-versions
branch
from
bb8430e to
73d9c24
Compare
|
@bors r+ |
|
📌 Commit 73d9c24 has been approved by |
bors
added
S-waiting-on-bors
|
@bors r- Wait, there is actually a bug, this does not find the |
bors
added
S-waiting-on-author
|
Addressed. |
|
@bors r=Mark-Simulacrum |
|
📌 Commit 0749ad0 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
ehuss
added a commit
to ehuss/rust
that referenced
this pull request
Jan 17, 2022
The version was removed in rust-lang#77145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors how
build-manifesthandles versions, making the following changes:build-manifestnow detects the "package releases" on its own, without relying on rustbuild providing them through CLI arguments. This drastically simplifies calling the tool outside ofx.py, and will allow to ship the prebuilt tool in a tarball in the future, with the goal of stopping to invokex.pyduringpromote-release.tarcommand is not used to extract the version and the git hash from tarballs anymore. Theflate2andtarcrates are used instead. This makes detecting those pieces of data way faster, as the archive is decompressed just once and we stop parsing the archive once all the information is retrieved.Builderstruct every time.I tested the changes locally and it should behave the same as before.
r? @Mark-Simulacrum