-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 11 pull requests #75862
Closed
Closed
Rollup of 11 pull requests #75862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * Fix typo in module docs * Link to `std::io::stderr` instead of `std::io::Stderr` to match the link text * Link to `std::io::stdout`
…eless_format, clippy:::for_kv_map
This prevents links from breaking when items are re-exported in a different crate and the original isn't being documented.
…jyn514 Use intra-doc link in `proc_macro` Yep. One link. Helps with rust-lang#75080. r? @jyn514
…r=jyn514 Use intra-doc-links in `core::{char, macros, fmt}` Helps with rust-lang#75080. r? @jyn514
…ros, r=jyn514 Switch to intra-doc links in `std::macros` Part of rust-lang#75080. --- * Switch to intra-doc links in `std::macros` * Fix typo in module docs * Link to `std::io::stderr` instead of `std::io::Stderr` to match the link text * Link to `std::io::stdout` --- @rustbot modify labels: A-intra-doc-links T-doc T-rustdoc
Fix typo in documentation of i32 wrapping_abs() Hi! I was reading through the std library docs and noticed that this section flowed a bit oddly; comparing it against https://doc.rust-lang.org/std/primitive.i32.html#method.wrapping_div and https://doc.rust-lang.org/std/primitive.i32.html#method.wrapping_neg , I noticed that those two pieces of documentation used a semicolon here. This is my first time submitting a PR to this repo. Am I doing this right? Are tiny typo-fix PRs like this worth submitting, or are they not a good use of time? Thank you!
…ation_for_derived_Ord_PartialOrd, r=KodrAus Corrected Misleading documentation for derived Ord/PartialOrd implementation Corrected Misleading documentation for derived Ord/PartialOrd implementation Fixes rust-lang#75620
doc: Prefer https link for wikipedia URLs A tiny changes.
…r=Mark-Simulacrum publish-toolstate: show more context on HTTP error The default display for HTTPError in Python does not include the request body. For GitHub API, the body includes more details about the error (like rate limiting). This could help diagnosing errors like this: rust-lang#75815 (comment)
Switch to intra-doc links in `std::collections` Part of rust-lang#75080. @rustbot modify labels: A-intra-doc-links T-doc T-rustdoc
Use allow(unused_imports) instead of cfg(doc) for imports used only for intra-doc links This prevents links from breaking when items are re-exported in a different crate and the original isn't being documented. Spotted in rust-lang#75832 (comment) (thanks ollie!) r? @ollie27
more tool clippy fixes r? @Dylan-DPC
doc: Fix typo in std::process::Child documentation Nearly done reading stdlib docs, found another small typo, here's a PR! r? @steveklabnik
📌 Commit 5b49ffe has been approved by |
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Aug 24, 2020
⌛ Testing commit 5b49ffe with merge debf8323270b82f77058ad106a0bb61d54556595... |
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rollup
A PR which is a rollup
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
proc_macro
#75817 (Use intra-doc link inproc_macro
)core::{char, macros, fmt}
#75819 (Use intra-doc-links incore::{char, macros, fmt}
)std::macros
#75821 (Switch to intra-doc links instd::macros
)std::collections
#75847 (Switch to intra-doc links instd::collections
)Failed merges:
r? @ghost