Add back unwinding support for Sony PSP #75280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @dtolnay (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
dtolnay
approved these changes
Aug 9, 2020
There was a problem hiding this comment.
Thanks!
I'll stamp this without particular scrutiny on the basis that:
- Only the PSP target is affected by this commit.
- PSP is a Tier 3 target so whatever happens happens.
- You are the maintainer of rust-psp which is a real project with a large number of stars. Consequently if you say it works that's enough for me!
|
@bors r+ rollup |
|
📌 Commit 27fca58 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds back unwinding support for the Sony PSP. The
mipsel-sony-psptarget works well with unwinding. In rust-psp, we use thepanic_unwindcrate along with LLVM's libunwind to catch panics, run destructors, and print them to the debug screen without aborting all threads.