-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miri: Renamed "undef" to "uninit" #75226
Conversation
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
1008f48
to
c454687
Compare
The test initially failed due to formatting on a particular line in |
r? @RalfJung |
(Next time please Cc me in the PR description or put a link to the PR in the issue when there was prior discussion; I almost missed that you created this PR.) |
Ok sounds good, I was thinking of doing so but did not want to spam you. I will do so next time! |
☔ The latest upstream changes (presumably #74821) made this pull request unmergeable. Please resolve the merge conflicts. |
Please don't add merge commits to PRs; instead, please rebase on top of current master. |
// An optimization where we can just overwrite an entire range of an entire range of | ||
// initialization bits bits if they are going to be uniformly `1` or `0`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// An optimization where we can just overwrite an entire range of an entire range of | |
// initialization bits bits if they are going to be uniformly `1` or `0`. | |
// An optimization where we can just overwrite an entire range of | |
// initialization bits if they are going to be uniformly `1` or `0`. |
1a81acb
to
de24cab
Compare
Renamed remaining references to "undef" to "uninit" when referring to Miri. Impacted directories are: - src/librustc_codegen_llvm/consts.rs - src/librustc_middle/mir/interpret/ - src/librustc_middle/ty/print/pretty.rs - src/librustc_mir/ - src/tools/clippy/clippy_lints/src/consts.rs Upon building Miri based on the new changes it was verified that no changes needed to be made with the Miri project. Related issue #71193
de24cab
to
0c6e8b6
Compare
@bors r+ rollup |
📌 Commit 0c6e8b6 has been approved by |
Rollup of 10 pull requests Successful merges: - rust-lang#74744 (Update RELEASES.md for 1.46.0) - rust-lang#75085 (Transmute big endian `s6_addr` and `[u16; 8]`) - rust-lang#75226 (Miri: Renamed "undef" to "uninit") - rust-lang#75333 (polymorphize: constrain unevaluated const handling) - rust-lang#75338 (move stack size check to const_eval machine) - rust-lang#75347 (Rustdoc: Fix natural ordering to look at all numbers.) - rust-lang#75352 (Tweak conditions for E0026 and E0769) - rust-lang#75353 (Tiny cleanup, remove unnecessary `unwrap`) - rust-lang#75359 (unused_delims: trim expr) - rust-lang#75360 (Add sample fix for E0749) Failed merges: r? @ghost
Miri: Renamed "undef" to "uninit" Renamed remaining references to "undef" to "uninit" when referring to Miri. Impacted directories are: - `src/librustc_codegen_llvm/consts.rs` - `src/librustc_middle/mir/interpret/` - `src/librustc_middle/ty/print/pretty.rs` - `src/librustc_mir/` - `src/tools/clippy/clippy_lints/src/consts.rs` Upon building Miri based on the new changes it was verified that no changes needed to be made with the Miri project. Related issue rust-lang#71193
Renamed remaining references to "undef" to "uninit" when referring to Miri.
Impacted directories are:
src/librustc_codegen_llvm/consts.rs
src/librustc_middle/mir/interpret/
src/librustc_middle/ty/print/pretty.rs
src/librustc_mir/
src/tools/clippy/clippy_lints/src/consts.rs
Upon building Miri based on the new changes it was verified that no changes needed to be made with the Miri project.
Related issue #71193