Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid non-derefable types explicitly in unsizing casts #75136

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Forbid non-derefable types explicitly in unsizing casts #75136

merged 1 commit into from
Aug 4, 2020

Conversation

JohnTitor
Copy link
Member

Fixes #75118
r? @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Aug 4, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 4, 2020

📌 Commit cd7204e has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2020
@bors
Copy link
Contributor

bors commented Aug 4, 2020

⌛ Testing commit cd7204e with merge f4e38ee6b1b7292ad16ca220f9a6be9122a50e06...

@bors
Copy link
Contributor

bors commented Aug 4, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 4, 2020
@rust-log-analyzer
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@JohnTitor
Copy link
Member Author

Seems spurious:

2020-08-04T13:24:52.4138230Z Cloning into '/Users/runner/work/rust/rust/src/tools/rls'...
2020-08-04T13:24:52.5558570Z fatal: unable to access 'https://github.com/rust-lang/rls.git/': transfer closed with outstanding read data remaining
2020-08-04T13:24:52.5600530Z fatal: clone of 'https://github.com/rust-lang/rls.git' into submodule path '/Users/runner/work/rust/rust/src/tools/rls' failed
2020-08-04T13:24:52.5608690Z Failed to clone 'src/tools/rls'. Retry scheduled
2020-08-04T13:24:52.7158790Z Cloning into '/Users/runner/work/rust/rust/src/tools/rls'...
2020-08-04T13:24:52.7179710Z fatal: unable to access 'https://github.com/rust-lang/rls.git/': transfer closed with outstanding read data remaining
2020-08-04T13:24:52.7180500Z The command has failed after 5 attempts.
2020-08-04T13:24:52.7184470Z fatal: clone of 'https://github.com/rust-lang/rls.git' into submodule path '/Users/runner/work/rust/rust/src/tools/rls' failed
2020-08-04T13:24:52.7185190Z Failed to clone 'src/tools/rls' a second time, aborting
2020-08-04T13:24:52.7185720Z + [[ 5 -lt 5 ]]
2020-08-04T13:24:52.7186320Z + echo 'The command has failed after 5 attempts.'
2020-08-04T13:24:52.7186540Z + return 1
2020-08-04T13:24:57.7345840Z ##[error]Process completed with exit code 1.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2020
@JohnTitor
Copy link
Member Author

@oli-obk Could we beta-nominate this? The failure has reached beta and this is an obvious fix.

@bors
Copy link
Contributor

bors commented Aug 4, 2020

⌛ Testing commit cd7204e with merge f9d422e...

@bors
Copy link
Contributor

bors commented Aug 4, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: oli-obk
Pushing f9d422e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 4, 2020
@bors bors merged commit f9d422e into rust-lang:master Aug 4, 2020
@JohnTitor JohnTitor deleted the unsizing-casts-non-null branch August 4, 2020 21:32
@JohnTitor
Copy link
Member Author

Beta-nominating with this reason: #75136 (comment)

@JohnTitor JohnTitor added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 4, 2020
@spastorino
Copy link
Member

discussed in T-compiler meeting.

@rustbot modify labels: beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 6, 2020
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 7, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Aug 7, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 7, 2020
@bors
Auto merge of rust-lang#75261 - Mark-Simulacrum:beta-next, r=Mark-Sim…
63ca028 
…ulacrum

[beta] backports

* Forbid non-derefable types explicitly in unsizing casts rust-lang#75136
* forbid `#[track_caller]` on main rust-lang#75130
* Fix #[track_caller] shims for trait objects. rust-lang#74784
* rustc_target: Add a target spec option for disabling `--eh-frame-hdr` rust-lang#74631
* Disable Azure Pipelines except for macOS rust-lang#74620
* Upload builds from GHA instead of Azure Pipelines rust-lang#74565
* Add the aarch64-apple-darwin target rust-lang#74541
* Use `ReEmpty(U0)` as the implicit region bound in typeck rust-lang#74509
* rustbuild: drop tool::should_install rust-lang#74457
* lint: use `transparent_newtype_field` to avoid ICE rust-lang#74340
* Don't panic if the lhs of a div by zero is not statically known rust-lang#74221
* improper_ctypes_definitions: allow `Box` rust-lang#74448
* typeck: check for infer before type impls trait rust-lang#73965
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.

ICE when coercing NonNull<[T; 0]> to NonNull<[T]> in const fn
9 participants
@JohnTitor @oli-obk @bors @rust-log-analyzer @spastorino @cuviper @Mark-Simulacrum @rust-highfive @rustbot