Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Ignore fs::canonicalize errors in metadata #74915

Merged
merged 1 commit into from
Jul 30, 2020

Commits on Jul 30, 2020

  1. rustc: Ignore fs::canonicalize errors in metadata

    This commit updates the metadata location logic to ignore errors when
    calling `fs::canonicalize`. Canonicalization was added historically so
    multiple `-L` paths to the same directory don't print errors about
    multiple candidates (since rustc can deduplicate same-named paths), but
    canonicalization doesn't work on all filesystems. Cargo, for example,
    always uses this sort of fallback where it will opportunitistically try
    to canonicalize but fall back to using the input path if it otherwise
    doesn't work.
    
    If rustc is run on a filesystem that doesn't support canonicalization
    then the effect of this change will be that `-L` paths which logically
    point to the same directory will cause errors, but that's a rare enough
    occurrence it shouldn't cause much issue in practice. Otherwise rustc
    doesn't work at all today on those sorts of filesystem where
    canonicalization isn't supported!
    alexcrichton committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    cd8bdb5 View commit details
    Browse the repository at this point in the history