Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes required for rustc/cargo to build for iOS targets #73903

Closed
wants to merge 6 commits into from
Closed

Changes required for rustc/cargo to build for iOS targets #73903

wants to merge 6 commits into from

Conversation

Absolucy
Copy link
Contributor

cargo, rustc, clippy, rust-src, and rust-analysis successfully build for aarch64-apple-ios with these changes.

NOTE: cargo required arm64-ios openssl/libcurl to be linked.

image
image

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 30, 2020
Mark-Simulacrum
Mark-Simulacrum reviewed Jun 30, 2020
View reviewed changes
src/bootstrap/lib.rs Outdated Show resolved Hide resolved
src/bootstrap/native.rs Show resolved Hide resolved
src/bootstrap/native.rs Outdated Show resolved Hide resolved
@Mark-Simulacrum
Copy link
Member

r? @nikomatsakis -- I can't review these changes due to lack of knowledge about these platforms, not sure who to ask.

Left some comments as to questions I have, though.

I suppose we can also land and just presume they're fine -- shouldn't affect tier 1 platforms at least (and I think nothing in CI, in fact).

@Absolucy
Copy link
Contributor Author

Absolucy commented Jul 1, 2020

image

ignore the error, that's just iOS being iOS (an ld wrapper needs to be made that just ldid -S's everything)

nikomatsakis
nikomatsakis requested changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good to r+ but would like the comments added first =)

@Absolucy Absolucy requested a review from nikomatsakis July 1, 2020 16:22
Aaron1011
Aaron1011 reviewed Jul 1, 2020
View reviewed changes
src/bootstrap/native.rs Outdated Show resolved Hide resolved
@Absolucy
Copy link
Contributor Author

Absolucy commented Jul 1, 2020

What would it take for official rustc/cargo builds for aarch64-apple-ios to be made? As tier 2 targets still have official binary releases.

@nikomatsakis
Copy link
Contributor

We've been working on an RFC laying things out but Tier 2 support would require us working out how we're going to manage integrating into CI along with having a group of folks to help handle maintenance etc.

@bors r+

@bors
Copy link
Contributor

bors commented Jul 1, 2020

📌 Commit 67b162f has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2020
@Absolucy
Copy link
Contributor Author

Absolucy commented Jul 1, 2020

@nikomatsakis Am I misunderstanding something, as aarch64-apple-ios seems to already be a Tier 2 target

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 2, 2020
@Manishearth
Rollup merge of rust-lang#73903 - luxxxxy:ios-rustc, r=nikomatsakis
061f1c6 
Changes required for rustc/cargo to build for iOS targets

cargo, rustc, clippy, rust-src, and rust-analysis successfully build for `aarch64-apple-ios` with these changes.

NOTE: cargo required arm64-ios openssl/libcurl to be linked.

![image](https://user-images.githubusercontent.com/65794972/86178510-75d78080-baf6-11ea-9c17-b74bd6c85272.png)
![image](https://user-images.githubusercontent.com/65794972/86178525-7bcd6180-baf6-11ea-9974-f99980cbdb24.png)
@Manishearth Manishearth mentioned this pull request Jul 2, 2020
Merged
@pietroalbini
Copy link
Member

Am I misunderstanding something, as aarch64-apple-ios seems to already be a Tier 2 target

aarch64-apple-ios is a cross-compilation Tier 2 target (only the std column is ticket), while what you want is for it to be a host Tier 2 target. Yeah it's confusing :/

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 2, 2020
@bors
Auto merge of rust-lang#73954 - Manishearth:rollup-8qvh170, r=Manishe…
8a6d434 
…arth

Rollup of 10 pull requests

Successful merges:

 - rust-lang#73414 (Implement `slice_strip` feature)
 - rust-lang#73564 (linker: Create GNU_EH_FRAME header by default when producing ELFs)
 - rust-lang#73622 (Deny unsafe ops in unsafe fns in libcore)
 - rust-lang#73684 (add spans to injected coverage counters, extract with CoverageData query)
 - rust-lang#73812 (ast_pretty: Pass some token streams and trees by reference)
 - rust-lang#73853 (Add newline to rustc MultiSpan docs)
 - rust-lang#73883 (Compile rustdoc less often.)
 - rust-lang#73885 (Fix wasm32 being broken due to a NodeJS version bump)
 - rust-lang#73903 (Changes required for rustc/cargo to build for iOS targets)
 - rust-lang#73938 (Optimise fast path of checked_ops with `unlikely`)

Failed merges:

r? @ghost
@Aaron1011 Aaron1011 closed this Jul 2, 2020
@Absolucy Absolucy deleted the ios-rustc branch July 2, 2020 14:26
@Chris--B Chris--B mentioned this pull request Aug 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

@Aaron1011 Aaron1011 Aaron1011 left review comments

@nikomatsakis nikomatsakis Awaiting requested review from nikomatsakis

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Absolucy @rust-highfive @Mark-Simulacrum @nikomatsakis @bors @pietroalbini @Aaron1011