Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wasm32 being broken due to a NodeJS version bump #73885

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Fix wasm32 being broken due to a NodeJS version bump #73885

merged 1 commit into from
Jul 2, 2020

Commits on Jun 30, 2020

  1. ci: fix wasm32 broken due to a NodeJS version bump 

    Emscripten's SDK recently bumped the version of NodeJS they shipped, but
our Dockerfile for the wasm32 builder hardcoded the version number. This
will cause consistent CI failures once the currently cached image is
rebuilt (either due to a change or due to the cache expiring).

This commit fixes the problem by finding the latest version of NodeJS in
the Emscripten SDK and symlinking it to a "latest" directory, which is
then added to the PATH.
    @pietroalbini
    pietroalbini committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    844dc31 View commit details
    Browse the repository at this point in the history