Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pollute docs/suggestions with libstd deps #73771

Merged
merged 1 commit into from
Jul 16, 2020

Commits on Jun 26, 2020

  1. Don't pollute docs/suggestions with libstd deps

    Currently dependency crates of the standard library can sometimes leak
    into error messages such as when traits to import are suggested.
    Additionally they can leak into documentation such as in the list of
    "all traits implemented by `u32`". The dependencies of the standard
    library, however, are intended to be private.
    
    The dependencies of the standard library can't actually be stabl-y
    imported nor is the documentation that relevant since you can't import
    them on stable either. This commit updates both the compiler and rustdoc
    to ignore unstable traits in these two scenarios.
    
    Specifically the suggestion for traits to import ignore unstable traits,
    and similarly the list of traits implemented by a type excludes unstable
    traits.
    
    This commit is extracted from rust-lang#73441 where the addition of some new
    dependencies to the standard library was showed to leak into various
    error messages and documentation. The intention here is to go ahead and
    land these changes ahead of that since it will likely take some time to
    land.
    alexcrichton committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    fde8d11 View commit details
    Browse the repository at this point in the history