-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mdbook #73671
Update mdbook #73671
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #73756) made this pull request unmergeable. Please resolve the merge conflicts. |
Hm, so with the google fonts change -- I am a bit worried about redistributing those in our artifacts. Do we know if the licensing allows for that? Do we need some call out? Maybe we should disable copying the fonts for now and deal with it later (or never). |
Okay, seems good, thanks for checking. @bors r+ |
📌 Commit 6bcbc42 has been approved by |
I'm actually going to @bors rollup=never this as well because it seems like we'd want to be able to bisect accurately just in case |
@bors p=1 |
☀️ Test successful - checks-azure |
This updates mdbook to 0.4. The list of changes can be found at https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md#mdbook-040. I think the most important one is the change to include fonts with the book instead of using the Google Fonts CDN. This adds a few megabytes of fonts to the docs component. It may be possible to share the fonts across the books, but would take a fair bit of work to make that happen, so I'm not sure if it is necessary.
This also removes mdbook-linkcheck. It is currently not being used, and I don't foresee it going back into use anytime soon. I would prefer not to maintain something that isn't being used, and it removes a very large number of dependencies.