[stable] stable 1.44.1

[Mark-Simulacrum]

Another backport for 1.44.1, fixing rust-lang/rust-clippy#5356.

r? @ghost

[Mark-Simulacrum]

@bors r+ p=1000 rollup=never

Hopefully the last backport to this point release...

[bors]

📌 Commit 0a53b3aa30657f78887bafce50a8ea06b7f338d8 has been approved by Mark-Simulacrum

[ehuss]

Looks like RLS will need to be updated, too.

error[E0061]: this function takes 1 argument but 2 arguments were supplied
  --> src/tools/rls/rls-rustc/src/clippy.rs:62:9
   |
62 |         clippy_lints::register_pre_expansion_lints(&mut lint_store, &conf);
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ---------------  ----- supplied 2 arguments
   |         |
   |         expected 1 argument

error: aborting due to previous error

For more information about this error, try `rustc --explain E0061`.
error: could not compile `rls-rustc`.

[ehuss]

This is going to fail.
@bors r-
(I hope you don't mind the r-, just didn't want to waste queue time.)

[Dylan-DPC-zz]

@ehuss no worries, that's the right thing to do :)

[Dylan-DPC-zz]

For those who don't like scrolling through a 9k long log :

Cloning into 'rust-toolstate'...
error: Tool `rls` should be test-pass but is build-fail
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test check-tools

cc @Xanewok just in case

[Mark-Simulacrum]

I'll take a look first thing tomorrow, if folks don't get to it before then. Can't wait for universal subtrees...

[Xanewok]

Does this need anything more than just removing the &conf part?
I’ll prepare a branch shortly with the fix

[ehuss]

I noticed the release notes included something that wasn't actually added:

diff --git a/RELEASES.md b/RELEASES.md
index 45fe2e1fbb9..7de3700df95 100644
--- a/RELEASES.md
+++ b/RELEASES.md
@@ -2,13 +2,11 @@ Version 1.44.1 (2020-06-18)
 ===========================
 
 * [rustfmt accepts rustfmt_skip in cfg_attr again.][73078]
-* [Fix fingerprinting for lld on Windows with dylib.][cargo/8290]
 * [Don't hash executable filenames on apple platforms.][cargo/8329]
 * [Fix crashes when finding backtrace on macOS.][71397]
 
 [71397]: https://github.com/rust-lang/rust/issues/71397
 [73078]: https://github.com/rust-lang/rust/issues/73078
-[cargo/8290]: https://github.com/rust-lang/cargo/pull/8290
 [cargo/8329]: https://github.com/rust-lang/cargo/pull/8329
 
 Version 1.44.0 (2020-06-04)

For the other Cargo PR, it might be good just to briefly mention why the change was made, maybe just add (fixes backtraces) or something like that.

[Mark-Simulacrum]

Okay I've pushed up a rust-1.44.1 branch for RLS and am testing locally (and I guess in PR CI). Will approve and likely bump queue to get this in as quickly as possible.

[Mark-Simulacrum]

Okay, tests passed locally (had to adjust one more place in RLS). @bors r+ p=1000 rollup=neer

[bors]

📌 Commit 03c622f has been approved by Mark-Simulacrum

[bors]

⌛ Testing commit 03c622f with merge c7087fe...

[bors]

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing c7087fe to stable...