Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #73105

Closed
wants to merge 11 commits into from

Commits on Jun 6, 2020

  1. Configuration menu
    Copy the full SHA
    ff327c8 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2020

  1. Free default() forwarding to Default::default()

    When creating default values a trait method needs to be called with an
    explicit trait name.  `Default::default()` seems redundant.  A free
    function on the other hand, when imported directly, seems to be a better
    API, as it is just `default()`.  When implementing the trait, a method
    is still required.
    ilya-bobyr committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    8f4dfa8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ebb8722 View commit details
    Browse the repository at this point in the history
  3. Clean up E0646

    GuillaumeGomez committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    af68249 View commit details
    Browse the repository at this point in the history
  4. Add Item::is_fake for rustdoc

    I wasn't aware items _could_ be fake, so I think having a function
    mentioning it could be helpful. Also, I'd need to make this change for
    cross-crate intra-doc links anyway, so I figured it's better to make the
    refactor separate.
    jyn514 committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    1f11331 View commit details
    Browse the repository at this point in the history
  5. Use LocalDefId directly in Resolver::export_map and `module_expor…

    …ts` query
    
    This is to avoid the final conversion from `NodeId` to `HirId`
    during call to `Resolver::(clone|into)_outputs`.
    marmeladema committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    e759222 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#73001 - ilya-bobyr:master, r=dtolnay

    Free `default()` forwarding to `Default::default()`
    
    It feels a bit redundant to have to say `Default::default()` every time I need a new value of a type that has a `Default` instance.
    Especially so, compared to Haskell, where the same functionality is called `def`.
    Providing a free `default()` function that forwards to `Default::default()` seems to improve the situation.
    The trait is still there, so if someone wants to be explicit and to say `Default::default()` - it still works, but if imported as `std::default::default;`, then the free function reduces typing and visual noise.
    Dylan-DPC authored Jun 7, 2020
    Configuration menu
    Copy the full SHA
    7d81735 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#73075 - jyn514:comment-module, r=Dylan-DPC

    Add comments to `Resolve::get_module`
    
    r? @Manishearth
    Dylan-DPC authored Jun 7, 2020
    Configuration menu
    Copy the full SHA
    3df9fc0 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#73090 - marmeladema:resolver-outputs-local-…

    …def-id, r=petrochenkov
    
    Use `LocalDefId` directly in `Resolver::export_map`
    
    This is to avoid the final conversion from `NodeId` to `HirId`
    during call to `(clone|into)_outputs`
    
    This brings down the post-lowering uses of `NodeId` down to 2 calls to convert the `trait_map`.
    
    cc rust-lang#50928
    
    r? @petrochenkov
    Dylan-DPC authored Jun 7, 2020
    Configuration menu
    Copy the full SHA
    f8231df View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    eb31879 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#73098 - jyn514:rustdoc-is-fake, r=Guillaume…

    …Gomez
    
    Add Item::is_fake for rustdoc
    
    I wasn't aware items _could_ be fake, so I think having a function
    mentioning it could be helpful. Also, I'd need to make this change for
    cross-crate intra-doc links anyway, so I figured it's better to make the
    refactor separate.
    Dylan-DPC authored Jun 7, 2020
    Configuration menu
    Copy the full SHA
    b8f453f View commit details
    Browse the repository at this point in the history