Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve items for cross-crate imports relative to the original module #73101

Merged
merged 19 commits into from
Jul 17, 2020
Merged

Resolve items for cross-crate imports relative to the original module #73101

merged 19 commits into from
Jul 17, 2020

Commits on Jul 16, 2020

  1. Use get_module instead of module_map for resolve_str_path_error

    @jyn514
    jyn514 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    5271e98 View commit details
    Browse the repository at this point in the history

  2. Use the scope of the imported variable for resolution, not the curren… 

    …t scope

- Accept DefId in resolve_str_path_error

This will probably break lots of internal invariants.
    @jyn514
    jyn514 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    848a766 View commit details
    Browse the repository at this point in the history

  3. Use DefId for modules

    @jyn514
    jyn514 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    69bd13f View commit details
    Browse the repository at this point in the history

  4. Don't panic on fake IDs

    @jyn514
    jyn514 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    c3d9a73 View commit details
    Browse the repository at this point in the history

  5. unwrap() -> expect()

    @jyn514
    jyn514 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    20106d5 View commit details
    Browse the repository at this point in the history

  6. Make sure that module_id is actually a module

    @jyn514
    jyn514 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    24c3d85 View commit details
    Browse the repository at this point in the history

  7. Add tests for basic intra-doc links

    @jyn514
    jyn514 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    9542e23 View commit details
    Browse the repository at this point in the history

  8. Remove warnings

    @jyn514
    jyn514 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    99f34d8 View commit details
    Browse the repository at this point in the history

  9. Add test for re-exports 

    I had a hard time getting this to work without the `extern crate`,
suggestions are welcome.
    @jyn514
    jyn514 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    e78d499 View commit details
    Browse the repository at this point in the history

  10. Add test for documenting the re-export

    @jyn514
    jyn514 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    9eb6394 View commit details
    Browse the repository at this point in the history

  11. Add test for submodules in inner crate

    @jyn514
    jyn514 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    71fe8f7 View commit details
    Browse the repository at this point in the history

  12. Move import to top of function

    @jyn514
    jyn514 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    432b043 View commit details
    Browse the repository at this point in the history

  13. #![deny(intra_doc_resolution_failure)]

    @jyn514
    jyn514 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    769acba View commit details
    Browse the repository at this point in the history

  14. rand -> my_rand 

    This fixes a failure in stage2 rustdoc tests.
    @jyn514
    jyn514 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    5f49f55 View commit details
    Browse the repository at this point in the history

  15. Support intra-doc links on macro re-exports 

    This includes both `macro_rules!` and proc-macros.
    @jyn514
    jyn514 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    e63e5cd View commit details
    Browse the repository at this point in the history

  16. Support intra-doc links on trait and module re-exports 

    Trait implementations are treated the same as modules for the purposes
of intra-doc links.
    @jyn514
    jyn514 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    82b3b07 View commit details
    Browse the repository at this point in the history

  17. Add more debugging

    @jyn514
    jyn514 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    0ad1dcd View commit details
    Browse the repository at this point in the history

  18. Add (broken and ignored) test for rust-lang#73829

    @jyn514
    jyn514 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    8387e38 View commit details
    Browse the repository at this point in the history

  19. Fix invalid lint 

    intra_doc_resolution_failure is not a lint.
    @jyn514
    jyn514 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    c46e038 View commit details
    Browse the repository at this point in the history