Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run dataflow for const qualification if type-based check would fail #71330

Merged
merged 4 commits into from
Apr 25, 2020
Merged

Only run dataflow for const qualification if type-based check would fail #71330

merged 4 commits into from
Apr 25, 2020

Commits on Apr 23, 2020

  1. Make type alias private

    @ecstatic-morse
    ecstatic-morse committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    a75c792 View commit details
    Browse the repository at this point in the history

  2. Don't cache result of in_any_value_of_ty for locals 

    This was needed by an early version of dataflow-based const
qualification where `QualifCursor` needed to return a full `BitSet` with
the current state.
    @ecstatic-morse
    ecstatic-morse committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    274c85f View commit details
    Browse the repository at this point in the history

  3. Lazily run dataflow for const qualification

    @ecstatic-morse
    ecstatic-morse committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    1343797 View commit details
    Browse the repository at this point in the history

  4. Cycle errors now occur during const-eval, not checking

    @ecstatic-morse
    ecstatic-morse committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    15f95b1 View commit details
    Browse the repository at this point in the history