Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On FnDef type annotation suggestion, use fn-pointer output #71311

Merged
merged 2 commits into from
Apr 28, 2020

Conversation

estebank
Copy link
Contributor

Address the last point in #71209.

@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 19, 2020
@varkor
Copy link
Member

varkor commented Apr 27, 2020

r? @varkor

@rust-highfive rust-highfive assigned varkor and unassigned cramertj Apr 27, 2020
Co-Authored-By: varkor <[email protected]>
@varkor
Copy link
Member

varkor commented Apr 27, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 27, 2020

📌 Commit 432ab34 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2020
Rollup of 5 pull requests

Successful merges:

 - rust-lang#71311 (On `FnDef` type annotation suggestion, use fn-pointer output)
 - rust-lang#71488 (normalize field projection ty to fix broken MIR issue)
 - rust-lang#71489 (Fix off by one in treat err as bug)
 - rust-lang#71585 (remove obsolete comment)
 - rust-lang#71634 (Revert rust-lang#71372 ("Fix #! (shebang) stripping account space issue").)

Failed merges:

r? @ghost
@bors bors merged commit d9c1f5c into rust-lang:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants