might_permit_raw_init: also check aggregate fields #71274

RalfJung · 2020-04-18T07:57:18Z

This is the next step for #66151: when doing mem::zeroed/mem::uninitialized, also recursively check fields of aggregates (except for arrays) for whether they permit zero/uninit initialization.

rust-highfive · 2020-04-18T07:57:21Z

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

RalfJung · 2020-04-18T07:58:30Z

@bors rollup=never

petrochenkov · 2020-04-18T09:37:41Z

@bors try

bors · 2020-04-18T09:37:52Z

⌛ Trying commit 1e6b345ccb9c89af0a36fce2bb34ee6b9835041d with merge 41997647ba6a77908f6ef64401414feb00bccf16...

lqd · 2020-04-18T11:23:23Z

(sorry for the misclick, wrong issue)

bors · 2020-04-18T12:05:15Z

☀️ Try build successful - checks-azure
Build commit: 41997647ba6a77908f6ef64401414feb00bccf16 (41997647ba6a77908f6ef64401414feb00bccf16)

petrochenkov · 2020-04-18T12:09:57Z

@craterbot run

craterbot · 2020-04-18T12:10:00Z

👌 Experiment pr-71274 created and queued.
🤖 Automatically detected try build 41997647ba6a77908f6ef64401414feb00bccf16
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2020-04-18T12:10:02Z

🚧 Experiment pr-71274 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

RalfJung · 2020-04-22T11:03:48Z

After 4 days we are at 26%? How long do crater runs take these days?^^

Mark-Simulacrum · 2020-04-22T16:22:27Z

I have started the azure agent (seems it went down). Hopefully that speeds things up. Will check again in an hour or two.

Mark-Simulacrum · 2020-04-22T19:22:28Z

It looks to me like test runs are just really slow (I'm not sure, but I think the two week estimate is misleading -- we were running at roughly 30% capacity due to one of the builders being down).

RalfJung · 2020-04-27T09:39:02Z

9 days, 97%. Wow, I had no idea crater runs became so expensive.

Mark-Simulacrum · 2020-04-27T15:51:03Z

build-and-test crater runs are progressively slowing down -- I think if we were at full builders (instead of spotty on the azure one), it'd probably be roughly 7 days. But yeah, build-and-test runs take a long time.

craterbot · 2020-04-27T20:52:27Z

🎉 Experiment pr-71274 is completed!
📊 416 regressed and 28 fixed (99064 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

petrochenkov · 2020-04-27T21:37:54Z

Waiting on author to triage the regressions.

RalfJung · 2020-04-27T22:59:58Z

Wow, 400 regressions, that will take a bit. :(

petrochenkov · 2020-09-27T08:46:22Z

Is it okay to just update the cargotest to a newer version?

No idea.
Maybe someone from cargo or infra teams knows.

RalfJung · 2020-09-27T09:17:34Z

@pietroalbini said we can just bump it.
@bors r=petrochenkov

bors · 2020-09-27T09:17:35Z

📌 Commit 3009c52 has been approved by petrochenkov

bors · 2020-09-27T10:17:15Z

⌛ Testing commit 3009c52 with merge b836329...

bors · 2020-09-27T12:21:34Z

☀️ Test successful - checks-actions, checks-azure
Approved by: petrochenkov
Pushing b836329 to master...

Clean up some of the pkgsrc Makefile, there's still lots in here that should just be deleted though. Switch SunOS to the illumos bootstrap by default. Version 1.48.0 (2020-11-19) ========================== Language -------- - [The `unsafe` keyword is now syntactically permitted on modules.][75857] This is still rejected *semantically*, but can now be parsed by procedural macros. Compiler -------- - [Stabilised the `-C link-self-contained=<yes|no>` compiler flag.][76158] This tells `rustc` whether to link its own C runtime and libraries or to rely on a external linker to find them. (Supported only on `windows-gnu`, `linux-musl`, and `wasi` platforms.) - [You can now use `-C target-feature=+crt-static` on `linux-gnu` targets.][77386] Note: If you're using cargo you must explicitly pass the `--target` flag. - [Added tier 2\* support for `aarch64-unknown-linux-musl`.][76420] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries --------- - [`io::Write` is now implemented for `&ChildStdin` `&Sink`, `&Stdout`, and `&Stderr`.][76275] - [All arrays of any length now implement `TryFrom<Vec<T>>`.][76310] - [The `matches!` macro now supports having a trailing comma.][74880] - [`Vec<A>` now implements `PartialEq<[B]>` where `A: PartialEq<B>`.][74194] - [The `RefCell::{replace, replace_with, clone}` methods now all use `#[track_caller]`.][77055] Stabilized APIs --------------- - [`slice::as_ptr_range`] - [`slice::as_mut_ptr_range`] - [`VecDeque::make_contiguous`] - [`future::pending`] - [`future::ready`] The following previously stable methods are now `const fn`'s: - [`Option::is_some`] - [`Option::is_none`] - [`Option::as_ref`] - [`Result::is_ok`] - [`Result::is_err`] - [`Result::as_ref`] - [`Ordering::reverse`] - [`Ordering::then`] Cargo ----- Rustdoc ------- - [You can now link to items in `rustdoc` using the intra-doc link syntax.][74430] E.g. ``/// Uses [`std::future`]`` will automatically generate a link to `std::future`'s documentation. See ["Linking to items by name"][intradoc-links] for more information. - [You can now specify `#[doc(alias = "<alias>")]` on items to add search aliases when searching through `rustdoc`'s UI.][75740] Compatibility Notes ------------------- - [Promotion of references to `'static` lifetime inside `const fn` now follows the same rules as inside a `fn` body.][75502] In particular, `&foo()` will not be promoted to `'static` lifetime any more inside `const fn`s. - [Associated type bindings on trait objects are now verified to meet the bounds declared on the trait when checking that they implement the trait.][27675] - [When trait bounds on associated types or opaque types are ambiguous, the compiler no longer makes an arbitrary choice on which bound to use.][54121] - [Fixed recursive nonterminals not being expanded in macros during pretty-print/reparse check.][77153] This may cause errors if your macro wasn't correctly handling recursive nonterminal tokens. - [`&mut` references to non zero-sized types are no longer promoted.][75585] - [`rustc` will now warn if you use attributes like `#[link_name]` or `#[cold]` in places where they have no effect.][73461] - [Updated `_mm256_extract_epi8` and `_mm256_extract_epi16` signatures in `arch::{x86, x86_64}` to return `i32` to match the vendor signatures.][73166] - [`mem::uninitialized` will now panic if any inner types inside a struct or enum disallow zero-initialization.][71274] - [`#[target_feature]` will now error if used in a place where it has no effect.][78143] - [Foreign exceptions are now caught by `catch_unwind` and will cause an abort.][70212] Note: This behaviour is not guaranteed and is still considered undefined behaviour, see the [`catch_unwind`] documentation for further information. Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Building `rustc` from source now uses `ninja` by default over `make`.][74922] You can continue building with `make` by setting `ninja=false` in your `config.toml`. - [cg_llvm: `fewer_names` in `uncached_llvm_type`][76030] - [Made `ensure_sufficient_stack()` non-generic][76680] [78143]: rust-lang/rust#78143 [76680]: rust-lang/rust#76680 [76030]: rust-lang/rust#76030 [70212]: rust-lang/rust#70212 [27675]: rust-lang/rust#27675 [54121]: rust-lang/rust#54121 [71274]: rust-lang/rust#71274 [77386]: rust-lang/rust#77386 [77153]: rust-lang/rust#77153 [77055]: rust-lang/rust#77055 [76275]: rust-lang/rust#76275 [76310]: rust-lang/rust#76310 [76420]: rust-lang/rust#76420 [76158]: rust-lang/rust#76158 [75857]: rust-lang/rust#75857 [75585]: rust-lang/rust#75585 [75740]: rust-lang/rust#75740 [75502]: rust-lang/rust#75502 [74880]: rust-lang/rust#74880 [74922]: rust-lang/rust#74922 [74430]: rust-lang/rust#74430 [74194]: rust-lang/rust#74194 [73461]: rust-lang/rust#73461 [73166]: rust-lang/rust#73166 [intradoc-links]: https://doc.rust-lang.org/rustdoc/linking-to-items-by-name.html [`catch_unwind`]: https://doc.rust-lang.org/std/panic/fn.catch_unwind.html [`Option::is_some`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_some [`Option::is_none`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_none [`Option::as_ref`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.as_ref [`Result::is_ok`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_ok [`Result::is_err`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_err [`Result::as_ref`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.as_ref [`Ordering::reverse`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.reverse [`Ordering::then`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.then [`slice::as_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_ptr_range [`slice::as_mut_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_mut_ptr_range [`VecDeque::make_contiguous`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.make_contiguous [`future::pending`]: https://doc.rust-lang.org/std/future/fn.pending.html [`future::ready`]: https://doc.rust-lang.org/std/future/fn.ready.html

Pkgsrc changes: * Compensate for files being moved around upstream. * Introduce optional, on-by-default semi-static building of cargo, using the internal curl and openssl sources. This reduces the dynamic dependencies of cargo and therefore the rust package itself. Ref. options.mk. * The 1.47.0 bootstrap kits have been re-built with the above option turned on, so no longer depends on curl or openssl from pkgsrc and/or from earlier OS or pkgsrc versions. This should hopefully fix installation of rust with non-default PREFIX, ref. PR#54453. Upstream changes: Version 1.48.0 (2020-11-19) ========================== Language -------- - [The `unsafe` keyword is now syntactically permitted on modules.][75857] This is still rejected *semantically*, but can now be parsed by procedural macros. Compiler -------- - [Stabilised the `-C link-self-contained=<yes|no>` compiler flag.][76158] This tells `rustc` whether to link its own C runtime and libraries or to rely on a external linker to find them. (Supported only on `windows-gnu`, `linux-musl`, and `wasi` platforms.) - [You can now use `-C target-feature=+crt-static` on `linux-gnu` targets.] [77386] Note: If you're using cargo you must explicitly pass the `--target` flag. - [Added tier 2\* support for `aarch64-unknown-linux-musl`.][76420] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries --------- - [`io::Write` is now implemented for `&ChildStdin` `&Sink`, `&Stdout`, and `&Stderr`.][76275] - [All arrays of any length now implement `TryFrom<Vec<T>>`.][76310] - [The `matches!` macro now supports having a trailing comma.][74880] - [`Vec<A>` now implements `PartialEq<[B]>` where `A: PartialEq<B>`.][74194] - [The `RefCell::{replace, replace_with, clone}` methods now all use `#[track_caller]`.][77055] Stabilized APIs --------------- - [`slice::as_ptr_range`] - [`slice::as_mut_ptr_range`] - [`VecDeque::make_contiguous`] - [`future::pending`] - [`future::ready`] The following previously stable methods are now `const fn`'s: - [`Option::is_some`] - [`Option::is_none`] - [`Option::as_ref`] - [`Result::is_ok`] - [`Result::is_err`] - [`Result::as_ref`] - [`Ordering::reverse`] - [`Ordering::then`] Cargo ----- Rustdoc ------- - [You can now link to items in `rustdoc` using the intra-doc link syntax.][74430] E.g. ``/// Uses [`std::future`]`` will automatically generate a link to `std::future`'s documentation. See ["Linking to items by name"][intradoc-links] for more information. - [You can now specify `#[doc(alias = "<alias>")]` on items to add search aliases when searching through `rustdoc`'s UI.][75740] Compatibility Notes ------------------- - [Promotion of references to `'static` lifetime inside `const fn` now follows the same rules as inside a `fn` body.][75502] In particular, `&foo()` will not be promoted to `'static` lifetime any more inside `const fn`s. - [Associated type bindings on trait objects are now verified to meet the bounds declared on the trait when checking that they implement the trait.][27675] - [When trait bounds on associated types or opaque types are ambiguous, the compiler no longer makes an arbitrary choice on which bound to use.][54121] - [Fixed recursive nonterminals not being expanded in macros during pretty-print/reparse check.][77153] This may cause errors if your macro wasn't correctly handling recursive nonterminal tokens. - [`&mut` references to non zero-sized types are no longer promoted.][75585] - [`rustc` will now warn if you use attributes like `#[link_name]` or `#[cold]` in places where they have no effect.][73461] - [Updated `_mm256_extract_epi8` and `_mm256_extract_epi16` signatures in `arch::{x86, x86_64}` to return `i32` to match the vendor signatures.][73166] - [`mem::uninitialized` will now panic if any inner types inside a struct or enum disallow zero-initialization.][71274] - [`#[target_feature]` will now error if used in a place where it has no effect.][78143] - [Foreign exceptions are now caught by `catch_unwind` and will cause an abort.][70212] Note: This behaviour is not guaranteed and is still considered undefined behaviour, see the [`catch_unwind`] documentation for further information. Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Building `rustc` from source now uses `ninja` by default over `make`.][74922] You can continue building with `make` by setting `ninja=false` in your `config.toml`. - [cg_llvm: `fewer_names` in `uncached_llvm_type`][76030] - [Made `ensure_sufficient_stack()` non-generic][76680] [78143]: rust-lang/rust#78143 [76680]: rust-lang/rust#76680 [76030]: rust-lang/rust#76030 [70212]: rust-lang/rust#70212 [27675]: rust-lang/rust#27675 [54121]: rust-lang/rust#54121 [71274]: rust-lang/rust#71274 [77386]: rust-lang/rust#77386 [77153]: rust-lang/rust#77153 [77055]: rust-lang/rust#77055 [76275]: rust-lang/rust#76275 [76310]: rust-lang/rust#76310 [76420]: rust-lang/rust#76420 [76158]: rust-lang/rust#76158 [75857]: rust-lang/rust#75857 [75585]: rust-lang/rust#75585 [75740]: rust-lang/rust#75740 [75502]: rust-lang/rust#75502 [74880]: rust-lang/rust#74880 [74922]: rust-lang/rust#74922 [74430]: rust-lang/rust#74430 [74194]: rust-lang/rust#74194 [73461]: rust-lang/rust#73461 [73166]: rust-lang/rust#73166 [intradoc-links]: https://doc.rust-lang.org/rustdoc/linking-to-items-by-name.html [`catch_unwind`]: https://doc.rust-lang.org/std/panic/fn.catch_unwind.html [`Option::is_some`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_some [`Option::is_none`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_none [`Option::as_ref`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.as_ref [`Result::is_ok`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_ok [`Result::is_err`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_err [`Result::as_ref`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.as_ref [`Ordering::reverse`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.reverse [`Ordering::then`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.then [`slice::as_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_ptr_range [`slice::as_mut_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_mut_ptr_range [`VecDeque::make_contiguous`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.make_contiguous [`future::pending`]: https://doc.rust-lang.org/std/future/fn.pending.html [`future::ready`]: https://doc.rust-lang.org/std/future/fn.ready.html

jonhoo · 2021-01-02T20:47:25Z

Should the documentation for mem::zeroed mention that it can panic when trying to zero values that cannot be zeroed?

MikailBag · 2021-01-02T21:08:19Z

AFAIU this is just an implementation detail since Undefined Behavior may be replaced by any other, including panic.

rust-highfive assigned petrochenkov Apr 18, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2020

petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2020

lqd added NLL-polonius Issues related for using Polonius in the borrow checker and removed NLL-polonius Issues related for using Polonius in the borrow checker labels Apr 18, 2020

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Apr 27, 2020

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2020

This was referenced May 3, 2020

Fix mem::uninitialized UB warning contain-rs/linked-hash-map#100

Merged

UB due to misuse of mem::uninitialized (will soon lead to panic) DaseinPhaos/arendur#1

Open

update tokei and ripgrep in cargotest

3009c52

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 27, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 27, 2020

bors merged commit b836329 into rust-lang:master Sep 27, 2020

rustbot added this to the 1.48.0 milestone Sep 27, 2020

RalfJung deleted the raw-init-check-aggregate branch September 28, 2020 08:24

spastorino removed the to-announce Announce this issue on triage meeting label Oct 1, 2020

Bobo1239 mentioned this pull request Oct 4, 2020

new release of lru-disk-cache with updated dependicies on crates.io ? mozilla/sccache#813

Closed

RalfJung mentioned this pull request Oct 5, 2020

Panic in Firefox (rusqlite/lru_cache/linked_hash_map) built with recent Rust nightlies #77585

Closed

Aaron1011 mentioned this pull request Oct 20, 2020

Crater runs for 1.48 #77970

Closed

Mark-Simulacrum mentioned this pull request Oct 26, 2020

Update RELEASES.md for 1.48.0 #78364

Merged

RalfJung mentioned this pull request Nov 22, 2020

might_permit_raw_init: also check arrays #79296

Closed

sudarshan-reddy mentioned this pull request Nov 24, 2020

Replacing lru_cache with hashlink. hickory-dns/hickory-dns#1301

Closed

probablykasper mentioned this pull request Nov 25, 2020

from_str panic alkis/decimal#62

Closed

bossmc mentioned this pull request Dec 3, 2020

sccache v0.2.13 does not work when built with rustc 1.48 mozilla/sccache#887

Closed

nicodemus26 mentioned this pull request Dec 17, 2020

Deserialization in serde panics in rustc 1.48+ with some enum inner types dimforge/nalgebra#812

Closed

christoph-heiss mentioned this pull request Jan 2, 2021

Building master gives me "thread 'main' panicked at 'attempted to leave type linked_hash_map::Node<yaml::Yaml, yaml::Yaml> uninitialized, which is invalid'" If I have any syntax definition file on syntaxes folder jmacdonald/amp#205

Closed

netzdoktor mentioned this pull request Jan 20, 2021

generic-array v0.14 rust-embedded/heapless#166

Closed

SimonSapin mentioned this pull request Jan 26, 2021

Migrate away from the truetype crate servo/servo#28101

Closed

5225225 mentioned this pull request Aug 26, 2022

panic-on-uninit: adjust checks to 0x01-filling #101061

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

might_permit_raw_init: also check aggregate fields #71274

might_permit_raw_init: also check aggregate fields #71274

RalfJung commented Apr 18, 2020 •

edited by Mark-Simulacrum

Loading

rust-highfive commented Apr 18, 2020

RalfJung commented Apr 18, 2020

petrochenkov commented Apr 18, 2020

bors commented Apr 18, 2020

lqd commented Apr 18, 2020 •

edited

Loading

bors commented Apr 18, 2020

petrochenkov commented Apr 18, 2020

craterbot commented Apr 18, 2020

craterbot commented Apr 18, 2020

RalfJung commented Apr 22, 2020 •

edited

Loading

Mark-Simulacrum commented Apr 22, 2020

Mark-Simulacrum commented Apr 22, 2020

RalfJung commented Apr 27, 2020

Mark-Simulacrum commented Apr 27, 2020

craterbot commented Apr 27, 2020

petrochenkov commented Apr 27, 2020

RalfJung commented Apr 27, 2020

petrochenkov commented Sep 27, 2020

RalfJung commented Sep 27, 2020

bors commented Sep 27, 2020

bors commented Sep 27, 2020

bors commented Sep 27, 2020

jonhoo commented Jan 2, 2021

MikailBag commented Jan 2, 2021

might_permit_raw_init: also check aggregate fields #71274

might_permit_raw_init: also check aggregate fields #71274

Conversation

RalfJung commented Apr 18, 2020 • edited by Mark-Simulacrum Loading

rust-highfive commented Apr 18, 2020

RalfJung commented Apr 18, 2020

petrochenkov commented Apr 18, 2020

bors commented Apr 18, 2020

lqd commented Apr 18, 2020 • edited Loading

bors commented Apr 18, 2020

petrochenkov commented Apr 18, 2020

craterbot commented Apr 18, 2020

craterbot commented Apr 18, 2020

RalfJung commented Apr 22, 2020 • edited Loading

Mark-Simulacrum commented Apr 22, 2020

Mark-Simulacrum commented Apr 22, 2020

RalfJung commented Apr 27, 2020

Mark-Simulacrum commented Apr 27, 2020

craterbot commented Apr 27, 2020

petrochenkov commented Apr 27, 2020

RalfJung commented Apr 27, 2020

petrochenkov commented Sep 27, 2020

RalfJung commented Sep 27, 2020

bors commented Sep 27, 2020

bors commented Sep 27, 2020

bors commented Sep 27, 2020

jonhoo commented Jan 2, 2021

MikailBag commented Jan 2, 2021

RalfJung commented Apr 18, 2020 •

edited by Mark-Simulacrum

Loading

lqd commented Apr 18, 2020 •

edited

Loading

RalfJung commented Apr 22, 2020 •

edited

Loading