Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #70994

Merged
merged 20 commits into from
Apr 10, 2020
Merged

Rollup of 9 pull requests #70994

merged 20 commits into from
Apr 10, 2020

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Apr 10, 2020

Successful merges:

Failed merges:

r? @ghost

estebank and others added 20 commits April 8, 2020 14:40
Keep more information about trait binding failures.
…=nikomatsakis,eddyb

Use `PredicateObligation`s instead of `Predicate`s

Keep more information about trait binding failures. Use more specific spans by pointing at bindings that introduce obligations.

Subset of rust-lang#69709.

r? @eddyb
…nas-schievink

Use forward traversal for unconditional recursion lint

While reviewing rust-lang#70822, I noted that rust-lang#54444 could be solved without requiring the predecessor graph and without allocating a `Vec<Span>` for every basic block. The unconditional recursion lint is not a performance bottleneck however, so I approved rust-lang#70822 as it was.

Nevertheless, I wanted to try implementing my idea using `TriColorDepthFirstSearch`, which is a DFS that can differentiate between [forward/tree edges and backward ones](https://en.wikipedia.org/wiki/Depth-first_search#Output_of_a_depth-first_search). I found this approach more straightforward than the existing one, so I'm opening this PR to see if it is desirable.

The pass is now just a DFS across the control-flow graph. We ignore false edges and false unwinds, as well as the successors of recursive calls, just like existing pass does. If we see a back-edge (loop) or a terminator that would cause us to yield control-flow back to the caller (`Return`, `Resume`, etc.), we know that the function does not unconditionally recurse.

r? @jonas-schievink
…Simulacrum

compiletest: let config flags overwrite -A unused

Cc Manishearth/compiletest-rs#216
…ariations, r=Amanieu

Follow up on BTreeMap comments

r? @Amanieu (for the first commit)
…Mark-Simulacrum

Rearrange BTreeMap::into_iter to match range_mut.

r? @Mark-Simulacrum
I wondered why you catered for the optional root differently in `into_iter` than in `range_mut`.
…e, r=Mark-Simulacrum

Setup the `@rustbot prioritize` command

See rust-lang/triagebot#453

r? @Mark-Simulacrum can you confirm that the `t-compiler/wg-prioritization` stream ID is `227806`?
cc @spastorino
fix rustc-dev-guide's url in src/librustc_codegen_ssa

Change the backend-agnostic chapter's url in rustc-dev-guide from [url](https://rustc-dev-guide.rust-lang.org/codegen/backend-agnostic.html), which is 404 now, to [the right one](https://rustc-dev-guide.rust-lang.org/backend/backend-agnostic.html).

Sorry for disturbing.
@Centril Centril added the rollup A PR which is a rollup label Apr 10, 2020
@Centril
Copy link
Contributor Author

Centril commented Apr 10, 2020

@bors r+ p=9 rollup=never

@bors
Copy link
Contributor

bors commented Apr 10, 2020

📌 Commit 178aa6a has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 10, 2020
@bors
Copy link
Contributor

bors commented Apr 10, 2020

⌛ Testing commit 178aa6a with merge 1406186...

@bors
Copy link
Contributor

bors commented Apr 10, 2020

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 1406186 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 10, 2020
@bors bors merged commit 1406186 into rust-lang:master Apr 10, 2020
@bors bors mentioned this pull request Apr 10, 2020
@Centril Centril deleted the rollup-lftv0a3 branch April 10, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants