Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #70943

Merged
merged 32 commits into from
Apr 9, 2020
Merged

Rollup of 7 pull requests #70943

merged 32 commits into from
Apr 9, 2020

Commits on Mar 24, 2020

  1. save/restore pessimistic_yield when entering bodies

    This flag is used to make the execution order around `+=` operators
    pessimistic. Failure to save/restore the flag was causing independent
    async blocks to effect one another, leading to strange ICEs and failed
    assumptions.
    nikomatsakis committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    e7f8895 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2020

  1. Configuration menu
    Copy the full SHA
    041e170 View commit details
    Browse the repository at this point in the history
  2. Use unrolled loop

    tesuji committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    89bc236 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2020

  1. Configuration menu
    Copy the full SHA
    87d859a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9dd18a3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    60e9927 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dec9078 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. Configuration menu
    Copy the full SHA
    cd9f709 View commit details
    Browse the repository at this point in the history
  2. linker: Make argument building interface in trait Linker richer

    by redirecting everything to `Command`
    petrochenkov committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    ce25dab View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    032462e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    927db7d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7f42d81 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fd6fa68 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    379c255 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b30d906 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5a4fa45 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. Configuration menu
    Copy the full SHA
    b8f416d View commit details
    Browse the repository at this point in the history
  2. Implement Chain with Option fuses

    The iterators are now "fused" with `Option` so we don't need separate
    state to track which part is already exhausted, and we may also get
    niche layout for `None`. We don't use the real `Fuse` adapter because
    its specialization for `FusedIterator` unconditionally descends into the
    iterator, and that could be expensive to keep revisiting stuff like
    nested chains. It also hurts compiler performance to add more iterator
    layers to `Chain`.
    cuviper committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    859b8da View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8aac107 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2c4cffd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ce8abc6 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. Configuration menu
    Copy the full SHA
    f6c729d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f03db79 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    563152d View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2020

  1. Configuration menu
    Copy the full SHA
    45589b5 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#67705 - lzutao:wmemchr, r=wesleywiser

    Use unrolled loop for searching NULL in [u16] on Windows
    Centril authored Apr 9, 2020
    Configuration menu
    Copy the full SHA
    e89cb07 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#70367 - nikomatsakis:issue-69307, r=Aaron1011

    save/restore `pessimistic_yield` when entering bodies
    
    This flag is used to make the execution order around `+=` operators
    pessimistic. Failure to save/restore the flag was causing independent
    async blocks to effect one another, leading to strange ICEs and failed
    assumptions.
    
    Fixes rust-lang#69307
    
    r? @Zoxc
    Centril authored Apr 9, 2020
    Configuration menu
    Copy the full SHA
    ba50bc5 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#70822 - jonas-schievink:curse-of-the-recurs…

    …ion, r=ecstatic-morse
    
    Don't lint for self-recursion when the function can diverge
    
    Fixes rust-lang#54444
    Centril authored Apr 9, 2020
    Configuration menu
    Copy the full SHA
    a209b4f View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#70868 - petrochenkov:linkorder, r=nagisa,ma…

    …ti865
    
    rustc_codegen_ssa: Refactor construction of linker arguments
    
    And add comments.
    
    This PR doesn't reorder any linker arguments and therefore shouldn't contain any observable changes.
    
    The next goal here is to
    - Factor out order-independent linker arguments in the compiler code and in target specifications and pass them together. Such arguments generally apply to the whole linking session or the produced linking result rather to individual object files or libraries.
    - Figure out where exactly among the remaining order-dependent arguments we should place customization points like `-C link-args` and `-Z pre-link-args`.
    - Possibly provide command line opt-outs for options that are currently passed unconditionally (like CRT objects or arguments defined by the target spec).
    - Document and stabilize the customization points that are not yet stable (rust-lang#70505).
    Centril authored Apr 9, 2020
    Configuration menu
    Copy the full SHA
    cefee7b View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#70896 - cuviper:optional-chain, r=scottmcm

    Implement Chain with Option fuses
    
    The iterators are now "fused" with `Option` so we don't need separate state to track which part is already exhausted, and we may also get niche layout for `None`. We don't use the real `Fuse` adapter because its specialization for `FusedIterator` unconditionally descends into the iterator, and that could be expensive to keep revisiting stuff like nested chains. It also hurts compiler performance to add more iterator layers to `Chain`.
    
    This change was inspired by the [proposal](https://internals.rust-lang.org/t/proposal-implement-iter-chain-using-fuse/12006) on the internals forum. This is an alternate to rust-lang#70332, directly employing some of the same `Fuse` optimizations as rust-lang#70366 and rust-lang#70750.
    
    r? @scottmcm
    Centril authored Apr 9, 2020
    Configuration menu
    Copy the full SHA
    ecc4e2a View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#70916 - Centril:track-caller-ffi, r=eddyb

    Support `#[track_caller]` on functions in `extern "Rust" { ... }`
    
    Fixes rust-lang#70830 which is the follow-up to @eddyb's suggestion in rust-lang#69251 (comment) to allow `#[track_caller]` on `fn`s in FFI imports, that is, on functions in `extern "Rust" { ... }` blocks.
    
    This requires that the other side, the FFI export, also have the `#[track_caller]` attribute. Otherwise, undefined behavior is triggered and the blame lies, as usual, with the `unsafe { ... }` block which called the FFI imported function.
    
    After this PR, all forms of `fn` items with the right ABI (`"Rust"`) support `#[track_caller]`.
    
    As a drive-by, the PR also hardens the check rejecting `#[naked] #[track_caller]` such that methods and other forms of `fn` items are also considered.
    
    r? @eddyb
    cc @rust-lang/lang
    Centril authored Apr 9, 2020
    Configuration menu
    Copy the full SHA
    4f00396 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#70918 - tobithiel:fix_forbid_override, r=da…

    …vidtwco
    
    rustc_session: forbid lints override regardless of position
    
    Addresses the regression reported in rust-lang#70819 for command line arguments, but does not address the source code flag regression.
    Centril authored Apr 9, 2020
    Configuration menu
    Copy the full SHA
    09052a6 View commit details
    Browse the repository at this point in the history