Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully destructure constants into patterns #70743

Merged
merged 21 commits into from
Sep 26, 2020
Merged

Fully destructure constants into patterns #70743

merged 21 commits into from
Sep 26, 2020

Commits on Sep 20, 2020

  1. Merge tuple and struct pattern generation.

    @oli-obk
    oli-obk committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    b54f122 View commit details
    Browse the repository at this point in the history

  2. Add a query for dereferencing constants of reference type

    @oli-obk
    oli-obk committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    34c62e0 View commit details
    Browse the repository at this point in the history

  3. Implement destructuring for all aggregates and for references

    @oli-obk
    oli-obk committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    b2532a8 View commit details
    Browse the repository at this point in the history

  4. Split check for PartialEq impl into a method

    @oli-obk
    oli-obk committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    3795886 View commit details
    Browse the repository at this point in the history

  5. Lint on function pointers used in patterns

    @oli-obk
    oli-obk committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    aba5ea1 View commit details
    Browse the repository at this point in the history

  6. Use precise errors during const to pat conversion instead of a catch-… 

    …all on the main constant
    @oli-obk
    oli-obk committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    adf98ab View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. Document future incompat lints

    @oli-obk
    oli-obk committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    f7eceef View commit details
    Browse the repository at this point in the history

  2. Pacify tidy

    @oli-obk
    oli-obk committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    f12583a View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. Remove the "lift constant to reference" logic

    @oli-obk
    oli-obk committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    1b1b6ea View commit details
    Browse the repository at this point in the history

  2. Talk about unpredictable instead of "not deterministic"

    @oli-obk
    oli-obk committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    d486486 View commit details
    Browse the repository at this point in the history

  3. Deduplicate errors in const to pat conversion

    @oli-obk
    oli-obk committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    177d0ce View commit details
    Browse the repository at this point in the history

  4. Make sure we don't hide errors just because a lint has been emitted

    @oli-obk
    oli-obk committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    9a7e66a View commit details
    Browse the repository at this point in the history

  5. Name function correctly

    @oli-obk
    oli-obk committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    6a33de0 View commit details
    Browse the repository at this point in the history

  6. Make sure we report a future incompat error in all cases

    @oli-obk
    oli-obk committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    0174231 View commit details
    Browse the repository at this point in the history

  7. Make sure we keep emitting a hard error

    @oli-obk
    oli-obk committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    da21764 View commit details
    Browse the repository at this point in the history

  8. Update documentation tests

    @oli-obk
    oli-obk committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    9aa1c09 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. Don't talk about determinism

    @oli-obk
    oli-obk committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    2bc54d4 View commit details
    Browse the repository at this point in the history

  2. Use correct type in diagnostics again

    @oli-obk
    oli-obk committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    e4928d7 View commit details
    Browse the repository at this point in the history

  3. Deduplicate the "needs partialeq derive" message creation sites

    @oli-obk
    oli-obk committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    9550ca6 View commit details
    Browse the repository at this point in the history

  4. Document FallbackToConstRef and make sure we don't accidentally use it

    @oli-obk
    oli-obk committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    fc9f294 View commit details
    Browse the repository at this point in the history

  5. Revert a test change to make sure it's still testing the original issue

    @oli-obk
    oli-obk committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    daf976f View commit details
    Browse the repository at this point in the history