-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle ConstKind::Unresolved after monomorphizing #70249
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,31 +40,26 @@ impl<'a, 'tcx, Bx: BuilderMethods<'a, 'tcx>> FunctionCx<'a, 'tcx, Bx> { | |
&mut self, | ||
constant: &mir::Constant<'tcx>, | ||
) -> Result<ConstValue<'tcx>, ErrorHandled> { | ||
match constant.literal.val { | ||
ty::ConstKind::Unevaluated(def_id, substs, promoted) => { | ||
let substs = self.monomorphize(&substs); | ||
self.cx | ||
.tcx() | ||
.const_eval_resolve(ty::ParamEnv::reveal_all(), def_id, substs, promoted, None) | ||
.map_err(|err| { | ||
if promoted.is_none() { | ||
self.cx | ||
.tcx() | ||
.sess | ||
.span_err(constant.span, "erroneous constant encountered"); | ||
} | ||
err | ||
}) | ||
} | ||
match self.monomorphize(&constant.literal).val { | ||
ty::ConstKind::Unevaluated(def_id, substs, promoted) => self | ||
.cx | ||
.tcx() | ||
.const_eval_resolve(ty::ParamEnv::reveal_all(), def_id, substs, promoted, None) | ||
.map_err(|err| { | ||
if promoted.is_none() { | ||
self.cx | ||
.tcx() | ||
.sess | ||
.span_err(constant.span, "erroneous constant encountered"); | ||
} | ||
err | ||
}), | ||
ty::ConstKind::Value(value) => Ok(value), | ||
_ => { | ||
let const_ = self.monomorphize(&constant.literal); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What you could try is first always It's not the right fix here (see #70125 (comment)), but it could be useful for handling the erroring constant case. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok, this already seems to fix all tests 🤔 Will still look into your comment on #70125 |
||
if let ty::ConstKind::Value(value) = const_.val { | ||
Ok(value) | ||
} else { | ||
span_bug!(constant.span, "encountered bad ConstKind in codegen: {:?}", const_); | ||
} | ||
} | ||
err => span_bug!( | ||
constant.span, | ||
"encountered bad ConstKind after monomorphizing: {:?}", | ||
err | ||
), | ||
} | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
// run-pass | ||
#![feature(const_generics)] | ||
//~^ WARN the feature `const_generics` is incomplete and may cause the compiler to crash | ||
|
||
const L: usize = 4; | ||
|
||
pub trait Print<const N: usize> { | ||
fn print(&self) -> usize { | ||
N | ||
} | ||
} | ||
|
||
pub struct Printer; | ||
impl Print<L> for Printer {} | ||
|
||
fn main() { | ||
let p = Printer; | ||
assert_eq!(p.print(), 4); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
warning: the feature `const_generics` is incomplete and may cause the compiler to crash | ||
--> $DIR/issue-70125-1.rs:2:12 | ||
| | ||
LL | #![feature(const_generics)] | ||
| ^^^^^^^^^^^^^^ | ||
| | ||
= note: `#[warn(incomplete_features)]` on by default | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// run-pass | ||
|
||
#![feature(const_generics)] | ||
//~^ WARN the feature `const_generics` is incomplete and may cause the compiler to crash | ||
|
||
fn main() { | ||
<()>::foo(); | ||
} | ||
|
||
trait Foo<const X: usize> { | ||
fn foo() -> usize { | ||
X | ||
} | ||
} | ||
|
||
impl Foo<{3}> for () {} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
warning: the feature `const_generics` is incomplete and may cause the compiler to crash | ||
--> $DIR/issue-70125-2.rs:3:12 | ||
| | ||
LL | #![feature(const_generics)] | ||
| ^^^^^^^^^^^^^^ | ||
| | ||
= note: `#[warn(incomplete_features)]` on by default | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oli-obk @wesleywiser @varkor @yodaldevoid NB: this
Unevaluated
handling should, after #70125 (comment) is fixed, only handle the error case, whereas success should result inmonomorphize
itself doing the evaluation.What do you think about merging this PR before that root cause is fixed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to merge this interim fix if it addresses one of the existing ICEs 👍