more cleanups #69619
Merged
more cleanups #69619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
matthiaskrgr
commented
Mar 1, 2020
•
matthiaskrgr
commented
- use starts_with() instead of chars().next() == Some(x)
- use subsec_micros() instead of subsec_nanos() / 1000
- use for (idx, item) in iter.enumerate() instead of manually counting loop iterations with variables
- use values() or keys() respectively when iterating only over keys or values of maps.
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
eddyb
reviewed
Mar 2, 2020
Comment on lines
+1385
to
+1386
| for (idx, local) in ineligible_locals.iter().enumerate() { | ||
| assignments[local] = Ineligible(Some(idx as u32)); |
eddyb
reviewed
Mar 2, 2020
| for (_, item) in &krate.items { | ||
| visitor.visit_item(item); | ||
| } | ||
| krate.items.values().for_each(|item| visitor.visit_item(item)) |
There was a problem hiding this comment.
I prefer avoiding for_each as an anti-pattern, tbh, but the .values() change seems fine.
There was a problem hiding this comment.
sure, I'll change it
eddyb
reviewed
Mar 2, 2020
| tv_usec: (dur.subsec_nanos() / 1000) as libc::suseconds_t, | ||
| tv_usec: dur.subsec_micros() as libc::suseconds_t, |
eddyb
approved these changes
Mar 2, 2020
eddyb
approved these changes
Mar 2, 2020
|
@bors r+ |
|
📌 Commit 21affdd has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Mar 3, 2020
Rollup of 9 pull requests Successful merges: - #69213 (Improve documentation on iterators length) - #69609 (Remove `usable_size` APIs) - #69619 (more cleanups) - #69620 (doc(librustc_error_codes): add long error explanation for E0719) - #69626 (Toolstate: don't duplicate nightly tool list.) - #69628 (Fix a leak in `DiagnosticBuilder::into_diagnostic`.) - #69633 (Update my mailmap entry) - #69634 (clean up E0378 explanation) - #69637 (Don't convert Results to Options just for matching.) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.