-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use LZ4 instead of Deflate in metadata #6954
Conversation
Closes #6902 |
@cmr what impact does this have on rustc size and running time? |
@brson Cuts down compilation time of an empty file from 0.260s to 0.220s on my computer. It does cause the binaries to be larger: deflate
lz4
Probably not worth it for a 16% improvement? |
"Empty file" meaning fn main() {} When linking to extra it's 0.286s vs 0.331, still 16% speedup. |
@cmr how does the time to compile rustc change? |
@brson Up to 16:58.86 from 16:50.72, but that could be noise. |
What about the time to run the test suite? |
16% speedup for small files seems definitely worth it to me. Small crates are the "first run experience" on Rust. |
@pcwalton the problem is the 22% increase in binary size and a 50% increase |
No description provided.