Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't take redundant references to operands #69495

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Conversation

matthiaskrgr
Copy link
Member

No description provided.

@ecstatic-morse
Copy link
Contributor

I don't really think this is worth doing. Comparing slices by value slice[start..] == other[start..] always read a bit strange to me. Feel free to request a review from someone else.

@matthiaskrgr
Copy link
Member Author

r? @oli-obk

@oli-obk
Copy link
Contributor

oli-obk commented Feb 27, 2020

@bors r+ rollup

Without an explicit styleguide, following clippy's "use as few references as necessary" is my de-facto preference

@bors
Copy link
Contributor

bors commented Feb 27, 2020

📌 Commit 280e381 has been approved by oli-obk

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 27, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 27, 2020
don't take redundant references to operands
bors added a commit that referenced this pull request Feb 27, 2020
Rollup of 8 pull requests

Successful merges:

 - #60826 (Implement new gdb/lldb pretty-printers)
 - #69255 (Add more context to E0599 errors)
 - #69379 (Fail on multiple declarations of `main`.)
 - #69430 (librustc_typeck: remove loop that never actually loops)
 - #69449 (Do not ping PR reviewers in toolstate breakage)
 - #69491 (rustc_span: Add `Symbol::to_ident_string` for use in diagnostic messages)
 - #69495 (don't take redundant references to operands)
 - #69496 (use find(x) instead of filter(x).next())

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Feb 28, 2020
Rollup of 9 pull requests

Successful merges:

 - #69379 (Fail on multiple declarations of `main`.)
 - #69430 (librustc_typeck: remove loop that never actually loops)
 - #69449 (Do not ping PR reviewers in toolstate breakage)
 - #69491 (rustc_span: Add `Symbol::to_ident_string` for use in diagnostic messages)
 - #69495 (don't take redundant references to operands)
 - #69496 (use find(x) instead of filter(x).next())
 - #69501 (note that find(f) is equivalent to filter(f).next() in the docs.)
 - #69527 (Ignore untracked paths when running `rustfmt` on repository.)
 - #69529 (don't use .into() to convert types into identical types.)

Failed merges:

r? @ghost
@bors bors merged commit b19e822 into rust-lang:master Feb 28, 2020
@matthiaskrgr matthiaskrgr deleted the op_ref branch February 29, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants