Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement unused crate lint for 2018 edition #69203

Closed
wants to merge 9 commits into from
Closed

Implement unused crate lint for 2018 edition #69203

wants to merge 9 commits into from

Commits on Mar 12, 2020

  1. Add allow-by-default lint UNUSED_EXTERN_OPTIONS 

    This lint fires for any unused crates in the Rust 2018 extern prelude
(e.g. passed in via `--extern`)

For now, it is allow-by-default to prevent false positives in
multi-target crate. See rust-lang#69203 (comment)
for more details, and rust-lang/cargo#1982 for
the tracking issue.
    @Aaron1011
    Aaron1011 committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    278ea18 View commit details
    Browse the repository at this point in the history

  2. Pass "-Wunused_extern_options" to stage1 compiler

    @Aaron1011
    Aaron1011 committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    54034ce View commit details
    Browse the repository at this point in the history

  3. Properly handle transitive dependencies

    @Aaron1011
    Aaron1011 committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    e4170c4 View commit details
    Browse the repository at this point in the history

  4. Cleanup unused crates

    @Aaron1011
    Aaron1011 committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    3cfec9d View commit details
    Browse the repository at this point in the history

  5. Use underscore import

    @Aaron1011
    Aaron1011 committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    a87d6ba View commit details
    Browse the repository at this point in the history

  6. Run './x.py fmt'

    @Aaron1011
    Aaron1011 committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    cfd75fe View commit details
    Browse the repository at this point in the history

  7. Use opt_def_id when pretty-printing types 

    This fixes an ICE for items without a `DefId`
    @Aaron1011
    Aaron1011 committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    df71d38 View commit details
    Browse the repository at this point in the history

  8. Provide used_crates in Resolver.clone_outputs 

    This is necessary for Rustdoc to work, since we never end up calling
`Resolver.into_outputs`
    @Aaron1011
    Aaron1011 committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    bb0dac2 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2020

  1. More warning suppressions

    @Aaron1011
    Aaron1011 committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    8bfbaf6 View commit details
    Browse the repository at this point in the history