Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use check-pass mode for lint tests and nll tests #68504

Merged
merged 2 commits into from
Jan 25, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/test/ui/lint/command-line-lint-group-allow.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// compile-flags: -A bad-style
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

fn main() {
let _InappropriateCamelCasing = true;
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/lint/dead-code/tuple-struct-field.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

#![deny(dead_code)]

Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/lint/inclusive-range-pattern-syntax.fixed
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// run-rustfix

#![warn(ellipsis_inclusive_range_patterns)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/lint/inclusive-range-pattern-syntax.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// run-rustfix

#![warn(ellipsis_inclusive_range_patterns)]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// Issue #7526: lowercase static constants in patterns look like bindings

// This is similar to lint-lowercase-static-const-pattern.rs, except it
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/lint/lint-non-camel-case-variant.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

#![deny(non_camel_case_types)]

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

#![allow(dead_code)]
// This is ok because we often use the trailing underscore to mean 'prime'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

#![allow(dead_code)]
// pretty-expanded FIXME #23616
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/lint/lint-nonstandard-style-unicode.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

#![allow(dead_code)]

Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/lint/lint-output-format-2.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// aux-build:lint_output_format.rs

#![feature(unstable_test_feature)]
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

extern crate lint_output_format;
use lint_output_format::{foo, bar};
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/lint/lint-stability-deprecated.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// aux-build:lint_stability.rs
// aux-build:inherited_stability.rs
// aux-build:stability_cfg1.rs
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/lint/lints-in-foreign-macros.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// aux-build:lints-in-foreign-macros.rs
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

#![warn(unused_imports)] //~ missing documentation for crate [missing_docs]
#![warn(missing_docs)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/lint/reasons.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

#![feature(lint_reasons)]

Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/lint/type-overflow.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
#![warn(overflowing_literals)]

fn main() {
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/lint/unused_labels.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// should also deal with the edge cases where a label is shadowed,
// within nested loops

// build-pass (FIXME(62277): could be check-pass?)
// check-pass

#![feature(label_break_value)]
#![warn(unused_labels)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/lint/use-redundant.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
#![warn(unused_imports)]

use crate::foo::Bar;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// regions is erased.

// compile-flags:-Zborrowck=mir -Zverbose
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

#![feature(rustc_attrs)]

Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/nll/constant.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// arbitrary types without ICEs.

// compile-flags:-Zborrowck=mir
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

const HI: &str = "hi";

Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/nll/drop-may-dangle.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// including) the call to `use_x`. The `else` branch is not included.

// compile-flags:-Zborrowck=mir
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

#![allow(warnings)]
#![feature(dropck_eyepatch)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/nll/extra-unused-mut.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// extra unused mut lint tests for #51918

// build-pass (FIXME(62277): could be check-pass?)
// check-pass

#![feature(generators, nll)]
#![deny(unused_mut)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/nll/generator-distinct-lifetime.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// over a yield -- because the data that is borrowed (`*x`) is not
// stored on the stack.

// build-pass (FIXME(62277): could be check-pass?)
// check-pass

fn foo(x: &mut u32) {
move || {
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/nll/maybe-initialized-drop-uninitialized.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// compile-flags: -Zborrowck=mir
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

#![allow(warnings)]

Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/nll/projection-return.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// compile-flags:-Zborrowck=mir
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

#![feature(rustc_attrs)]

Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/nll/relate_tys/hr-fn-aau-eq-abu.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// another -- effectively, the single lifetime `'a` is just inferred
// to be the intersection of the two distinct lifetimes.
//
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// compile-flags:-Zno-leak-check

#![feature(nll)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/nll/relate_tys/hr-fn-aba-as-aaa.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// function returning always its first argument can be upcast to one
// that returns either first or second argument.
//
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// compile-flags:-Zno-leak-check

#![feature(nll)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/nll/ty-outlives/projection-body.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Test that when we infer the lifetime to a subset of the fn body, it
// works out.
//
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

trait MyTrait<'a> {
type Output;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// we don't even propagate constraints from the closures to the callers.

// compile-flags:-Zborrowck=mir -Zverbose
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

#![allow(warnings)]
#![feature(rustc_attrs)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/nll/ty-outlives/projection-where-clause-env.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// Regression test for #53121.
//
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

trait MyTrait<'a> {
type Output;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// MyTrait<'a>>::Output: 'a` outlives `'a` (because the trait says
// so).
//
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

trait MyTrait<'a> {
type Output: 'a;
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/nll/ty-outlives/ty-param-implied-bounds.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// compile-flags:-Zborrowck=mir -Zverbose
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

// Test that we assume that universal types like `T` outlive the
// function body.
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/nll/user-annotations/downcast-infer.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

// Check that we don't try to downcast `_` when type-checking the annotation.
fn main() {
Expand Down