Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide niches under UnsafeCell #68491

Merged
merged 4 commits into from
Feb 11, 2020
Merged

Hide niches under UnsafeCell #68491

merged 4 commits into from
Feb 11, 2020

Commits on Feb 10, 2020

  1. Add #[repr(no_niche)]. 

    This repr-hint makes a struct/enum hide any niche within from its
surrounding type-construction context.

It is meant (at least initially) as an implementation detail for
resolving issue 68303. We will not stabilize the repr-hint unless
someone finds motivation for doing so.

(So, declaration of `no_niche` feature lives in section of file
where other internal implementation details are grouped, and
deliberately leaves out the tracking issue number.)

incorporated review feedback, and fixed post-rebase.
    @pnkfelix
    pnkfelix committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    88747ff View commit details
    Browse the repository at this point in the history

  2. tests for #[repr(no_niche)].

    @pnkfelix
    pnkfelix committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    35e3b4d View commit details
    Browse the repository at this point in the history

  3. Add repr(no_niche) to UnsafeCell. Fix rust-lang#68303.

    @pnkfelix
    pnkfelix committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    3e04722 View commit details
    Browse the repository at this point in the history

  4. Fix SGX RWLock representation for UnsafeCell niche fix

    @pnkfelix
    Jethro Beekman authored and pnkfelix committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    1b12232 View commit details
    Browse the repository at this point in the history