Print constants in type_name for const generics
#68111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
I'd rather not merge anything around constants and pretty printing until my pretty printing PR is merged. This PR doesn't actually print anything new, right? It just stops printing the type for const generics |
It prints const generic arguments, which were previously just ignored. |
|
☔ The latest upstream changes (presumably #67000) made this pull request unmergeable. Please resolve the merge conflicts. |
JohnCSimon
added
S-waiting-on-author
varkor
added
S-waiting-on-review
|
#67133 is getting split up anyway, so r=me on this PR after a rebase |
varkor
force-pushed
the
const-generics-type_name
branch
from
c6198a0
to
50dd8ea
Compare
|
@bors r=oli-obk rollup |
|
📌 Commit 50dd8ea has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 24, 2020
…oli-obk Print constants in `type_name` for const generics Fixes rust-lang#65372. r? @oli-obk as there may have been a deliberate decision not to in rust-lang@5b98489#diff-4ed1a72c0bfdf17be769ed520932cd02R80.
bors
added a commit
that referenced
this pull request
Jan 24, 2020
Rollup of 6 pull requests Successful merges: - #68111 (Print constants in `type_name` for const generics) - #68374 (Fix invalid link to the C++ Exception Handling ABI documentation) - #68504 (Use check-pass mode for lint tests and nll tests) - #68509 (Clean up error codes E0223 and E0225 explanations) - #68511 (Remove unused ignore-license directives) - #68515 (Support feature process_set_argv0 for VxWorks) Failed merges: r? @ghost
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65372.
r? @oli-obk as there may have been a deliberate decision not to in 5b98489#diff-4ed1a72c0bfdf17be769ed520932cd02R80.