Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Only search potentially changed constraints in lexical_region_resolve #68001

Merged
merged 2 commits into from
Jan 18, 2020
Merged

perf: Only search potentially changed constraints in lexical_region_resolve #68001

merged 2 commits into from
Jan 18, 2020

Conversation

Marwes
Copy link
Contributor

@Marwes Marwes commented Jan 8, 2020

Gives a big performance increase to the unicode_normalization benchmark in my testing.

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 8, 2020
@jonas-schievink
Copy link
Contributor

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Jan 8, 2020

⌛ Trying commit d9f3888 with merge fe4e15c...

bors added a commit that referenced this pull request Jan 8, 2020
@bors
Auto merge of #68001 - Marwes:lexical_region_resolve, r=<try>
fe4e15c 
perf: Only search potentially changed constraints in lexical_region_resolve

Gives a big performance increase to the unicode_normalization benchmark in my testing.
@bors
Copy link
Contributor

bors commented Jan 8, 2020

☀️ Try build successful - checks-azure
Build commit: fe4e15c (fe4e15ced4225b62039d4bca075950c3367ef83a)

@rust-timer
Copy link
Collaborator

Queued fe4e15c with parent f48e576, future comparison URL.

@Marwes Marwes mentioned this pull request Jan 8, 2020
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit fe4e15c, comparison URL.

@Centril
Copy link
Contributor

Centril commented Jan 8, 2020

r? @nikomatsakis

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 8, 2020

📌 Commit d9f3888 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2020
@Centril
Copy link
Contributor

Centril commented Jan 8, 2020

@bors rollup=never

@bors
Copy link
Contributor

bors commented Jan 9, 2020

☔ The latest upstream changes (presumably #68034) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 9, 2020
@Marwes
perf: Filter out and process fixed constraints first in region expansion
343eee6 
Should reduce the number of elements as well as branches in the
extremely hot loop and process_constraint in benchmarks such as
unicode_normalization
@Marwes
perf: Only search the potentially changed constraints in lexical_regi…
917eb18 
…on_resolve
@Marwes
Copy link
Contributor Author

Marwes commented Jan 18, 2020 •
edited
Loading

Rebased to fix conflicts

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 18, 2020

📌 Commit 917eb18 has been approved by nikomatsakis

@bors bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 18, 2020
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 18, 2020
@bors
Copy link
Contributor

bors commented Jan 18, 2020

⌛ Testing commit 917eb18 with merge 779f85b...

bors added a commit that referenced this pull request Jan 18, 2020
@bors
Auto merge of #68001 - Marwes:lexical_region_resolve, r=nikomatsakis
779f85b 
perf: Only search potentially changed constraints in lexical_region_resolve

Gives a big performance increase to the unicode_normalization benchmark in my testing.
@bors
Copy link
Contributor

bors commented Jan 18, 2020

☀️ Test successful - checks-azure
Approved by: nikomatsakis
Pushing 779f85b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 18, 2020
@bors bors merged commit 917eb18 into rust-lang:master Jan 18, 2020
@bors bors mentioned this pull request Jan 18, 2020
Merged
@Marwes Marwes deleted the lexical_region_resolve branch January 18, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Marwes @rust-highfive @jonas-schievink @rust-timer @bors @Centril @nikomatsakis @davidtwco