Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove boxed closures in address parser. #67085

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Remove boxed closures in address parser. #67085

merged 1 commit into from
Dec 6, 2019

Conversation

reitermarkus
Copy link
Contributor

Simplify address parser by removing unnecessary boxed closures.

Also relevant for rust-lang/rfcs#2832.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @KodrAus (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 6, 2019
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

Thanks! I confirmed that as best as I can tell we're still issuing the reads atomically and avoiding the allocation here seems like a good thing as well.

@bors
Copy link
Contributor

bors commented Dec 6, 2019

📌 Commit 79f8764 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Dec 6, 2019
@JohnTitor
Rollup merge of rust-lang#67085 - reitermarkus:addr-parser, r=Mark-Si…
931be6c 
…mulacrum

Remove boxed closures in address parser.

Simplify address parser by removing unnecessary boxed closures.

Also relevant for rust-lang/rfcs#2832.
@JohnTitor JohnTitor mentioned this pull request Dec 6, 2019
Merged
bors added a commit that referenced this pull request Dec 6, 2019
@bors
Auto merge of #67091 - JohnTitor:rollup-kitphze, r=JohnTitor
9630dbb 
Rollup of 11 pull requests

Successful merges:

 - #66846 (Make try_mark_previous_green aware of cycles.)
 - #66959 (Remove potential cfgs duplicates)
 - #66988 (Fix angle bracket formatting when dumping MIR debug vars)
 - #66998 (Modified the testcases for VxWorks)
 - #67008 (rustdoc: Add test for fixed issue)
 - #67023 (SGX: Fix target linker used by bootstrap)
 - #67033 (Migrate to LLVM{Get,Set}ValueName2)
 - #67049 (Simplify {IoSlice, IoSliceMut}::advance examples and tests)
 - #67054 (codegen "unreachable" for invalid SetDiscriminant)
 - #67081 (Fix Query type docs)
 - #67085 (Remove boxed closures in address parser.)

Failed merges:

r? @ghost
@bors bors merged commit 79f8764 into rust-lang:master Dec 6, 2019
@reitermarkus reitermarkus deleted the addr-parser branch December 7, 2019 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@reitermarkus @rust-highfive @Mark-Simulacrum @bors @KodrAus