Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not ICE on async fn with non-Copy infered type arg #67004

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Do not ICE on async fn with non-Copy infered type arg #67004

merged 2 commits into from
Dec 9, 2019

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Dec 3, 2019

Fix #66958.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 3, 2019
@hellow554
Copy link
Contributor

The u32 field is not needed for the ICE. It was a leftover from the reduction. Feel free to remove it if you like.

@estebank
Copy link
Contributor Author

estebank commented Dec 5, 2019

Addressed comments.

@bors
Copy link
Contributor

bors commented Dec 5, 2019

☔ The latest upstream changes (presumably #66815) made this pull request unmergeable. Please resolve the merge conflicts.

eddyb
eddyb approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@estebank
Copy link
Contributor Author

estebank commented Dec 6, 2019

@bors r=eddyb

@bors
Copy link
Contributor

bors commented Dec 6, 2019

📌 Commit 7ed9066 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2019
Centril added a commit to Centril/rust that referenced this pull request Dec 7, 2019
@Centril
Rollup merge of rust-lang#67004 - estebank:issue-66958, r=eddyb
6c2232d 
Do not ICE on async fn with non-Copy infered type arg

Fix rust-lang#66958.
@Centril Centril mentioned this pull request Dec 7, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Dec 8, 2019
@Centril
Rollup merge of rust-lang#67004 - estebank:issue-66958, r=eddyb
3fd39b9 
Do not ICE on async fn with non-Copy infered type arg

Fix rust-lang#66958.
@Centril Centril mentioned this pull request Dec 8, 2019
Closed
@bors
Copy link
Contributor

bors commented Dec 9, 2019

⌛ Testing commit 7ed9066 with merge dbbe4f1...

bors added a commit that referenced this pull request Dec 9, 2019
@bors
Auto merge of #67004 - estebank:issue-66958, r=eddyb
dbbe4f1 
Do not ICE on async fn with non-Copy infered type arg

Fix #66958.
@bors
Copy link
Contributor

bors commented Dec 9, 2019

☀️ Test successful - checks-azure
Approved by: eddyb
Pushing dbbe4f1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 9, 2019
@bors bors merged commit 7ed9066 into rust-lang:master Dec 9, 2019
@bors bors mentioned this pull request Dec 9, 2019
Merged
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Feb 6, 2020
Closed
@estebank estebank deleted the issue-66958 branch November 9, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

@hellow554 hellow554 hellow554 left review comments

@eddyb eddyb eddyb approved these changes

Assignees

@eddyb eddyb

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE on rustc 1.41.0-nightly (25d8a9494 2019-11-29) running on x86_64-apple-darwin
6 participants
@estebank @rust-highfive @hellow554 @bors @eddyb @Centril