Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

really_init cmdline args on Miri #66873

Merged
merged 1 commit into from
Nov 30, 2019
Merged

really_init cmdline args on Miri #66873

merged 1 commit into from
Nov 30, 2019

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Nov 29, 2019 •
edited by dtolnay
Loading

r? @joshtriplett

Closes #66862.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 29, 2019
@RalfJung RalfJung mentioned this pull request Nov 29, 2019
Closed
@dtolnay
Copy link
Member

dtolnay commented Nov 29, 2019

@bors r+ p=1, fixing toolstate

@bors
Copy link
Contributor

bors commented Nov 29, 2019

📌 Commit f621c25 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2019
@dtolnay
Copy link
Member

dtolnay commented Nov 29, 2019

@bors p=1

@bors

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 30, 2019
@joshtriplett

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2019
@bors

This comment has been minimized.

Sign in to view
@dtolnay

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 30, 2019
@dtolnay

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2019
@bors
Copy link
Contributor

bors commented Nov 30, 2019

⌛ Testing commit f621c25 with merge 8f1bbd6...

bors added a commit that referenced this pull request Nov 30, 2019
@bors
Auto merge of #66873 - RalfJung:miri-args, r=dtolnay
8f1bbd6 
really_init cmdline args on Miri

r? @joshtriplett

Closes #66862.
@bors
Copy link
Contributor

bors commented Nov 30, 2019

☀️ Test successful - checks-azure
Approved by: dtolnay
Pushing 8f1bbd6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 30, 2019
@bors bors merged commit f621c25 into rust-lang:master Nov 30, 2019
@RalfJung RalfJung deleted the miri-args branch November 30, 2019 07:50
@dtolnay dtolnay assigned dtolnay and unassigned joshtriplett Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#66547
5 participants
@RalfJung @dtolnay @bors @rust-highfive @joshtriplett