Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LLVMAddAnalysisPasses instead of Rust's wrapper #66858

Merged
merged 1 commit into from
Dec 1, 2019
Merged

Use LLVMAddAnalysisPasses instead of Rust's wrapper #66858

merged 1 commit into from
Dec 1, 2019
+6 −16

Conversation

0dvictor
Copy link
Contributor

LLVM exposes a C API LLVMAddAnalysisPasses and hence Rust's own wrapper LLVMRustAddAnalysisPasses is not needed anymore.

Use LLVMAddAnalysisPasses instead of Rust's wrapper
b41b1d3 
LLVM exposes a C API `LLVMAddAnalysisPasses` and hence Rust's own
wrapper `LLVMRustAddAnalysisPasses` is not needed anymore.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @davidtwco (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 29, 2019
@0dvictor
Copy link
Contributor Author

FYI:

The LLVM's C API can be found at:
https://github.com/rust-lang/llvm-project/blob/de1a7dbf6c6b34f56e65732d45970ff27a8e84bf/llvm/include/llvm-c/TargetMachine.h#L156-L157

and its implementation is:
https://github.com/rust-lang/llvm-project/blob/de1a7dbf6c6b34f56e65732d45970ff27a8e84bf/llvm/lib/Target/TargetMachineC.cpp#L268-L271

@hanna-kruppe
Copy link
Contributor

Nice cleanup, thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 30, 2019

📌 Commit b41b1d3 has been approved by rkruppe

@bors
Copy link
Contributor

bors commented Nov 30, 2019

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2019
@davidtwco
Copy link
Member

r? @rkruppe

Centril added a commit to Centril/rust that referenced this pull request Nov 30, 2019
@Centril
Rollup merge of rust-lang#66858 - 0dvictor:capi, r=rkruppe
2378651 
Use LLVMAddAnalysisPasses instead of Rust's wrapper

LLVM exposes a C API `LLVMAddAnalysisPasses` and hence Rust's own wrapper `LLVMRustAddAnalysisPasses` is not needed anymore.
@Centril Centril mentioned this pull request Nov 30, 2019
Merged
bors added a commit that referenced this pull request Dec 1, 2019
@bors
Auto merge of #66908 - Centril:rollup-26givp6, r=Centril
135ccba 
Rollup of 9 pull requests

Successful merges:

 - #66612 (Initial implementation of or-pattern usefulness checking)
 - #66705 (Atomic as_mut_ptr)
 - #66759 (impl TrustedLen for vec::Drain)
 - #66858 (Use LLVMAddAnalysisPasses instead of Rust's wrapper)
 - #66870 (SimplifyArmIdentity only for locals with the same type)
 - #66883 (rustc_typeck: gate AnonConst's generics on feature(const_generics).)
 - #66889 (Make python-generated source files compatible with rustfmt)
 - #66894 (Remove unneeded prelude imports in libcore tests)
 - #66895 (Feature gating *declarations* => new crate `rustc_feature`)

Failed merges:

 - #66905 (rustc_plugin: Remove some remaining plugin features)

r? @ghost
@bors bors merged commit b41b1d3 into rust-lang:master Dec 1, 2019
@0dvictor 0dvictor deleted the capi branch December 1, 2019 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hanna-kruppe hanna-kruppe

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0dvictor @rust-highfive @hanna-kruppe @bors @davidtwco