Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused feature gates #66498

Merged
merged 21 commits into from
Feb 11, 2020
Merged

Remove unused feature gates #66498

merged 21 commits into from
Feb 11, 2020

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Nov 17, 2019

I think many of the remaining unstable things can be easily be replaced with stable things. I have kept the #![feature(nll)] even though it is only necessary in libstd, to make regressions of it harder.

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 17, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-11-17T19:20:54.3242175Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-17T19:20:54.3509895Z ##[command]git config gc.auto 0
2019-11-17T19:20:54.3576979Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-17T19:20:54.3643826Z ##[command]git config --get-all http.proxy
2019-11-17T19:20:54.3801033Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66498/merge:refs/remotes/pull/66498/merge
---
2019-11-17T20:19:44.2098326Z .................................................................................................... 1500/9251
2019-11-17T20:19:50.3922569Z .................................................................................................... 1600/9251
2019-11-17T20:19:59.2265272Z .................................................................................................... 1700/9251
2019-11-17T20:20:08.1431536Z ........i........................................................................................... 1800/9251
2019-11-17T20:20:14.6360093Z .............................................................................................iiiii.. 1900/9251
2019-11-17T20:20:35.6358888Z .................................................................................................... 2100/9251
2019-11-17T20:20:37.9517591Z .................................................................................................... 2200/9251
2019-11-17T20:20:40.4066794Z .................................................................................................... 2300/9251
2019-11-17T20:20:46.4370246Z .................................................................................................... 2400/9251
---
2019-11-17T20:24:25.9409477Z .................................................................................................... 5400/9251
2019-11-17T20:24:36.0458671Z ...............................................................................i.................... 5500/9251
2019-11-17T20:24:43.7577153Z .................................................................................................... 5600/9251
2019-11-17T20:24:50.2084902Z .................................................................................................... 5700/9251
2019-11-17T20:25:00.3125666Z .................................................................ii...i..ii...........i............. 5800/9251
2019-11-17T20:25:22.4290816Z .................................................................................................... 6000/9251
2019-11-17T20:25:30.7574949Z .................................................................................................... 6100/9251
2019-11-17T20:25:30.7574949Z .................................................................................................... 6100/9251
2019-11-17T20:25:35.6638376Z ....................................................................................i..ii........... 6200/9251
2019-11-17T20:26:03.2353925Z .................................................................................................... 6400/9251
2019-11-17T20:26:08.1487686Z ....................................................i............................................... 6500/9251
2019-11-17T20:26:10.3308065Z .................................................................................................... 6600/9251
2019-11-17T20:26:12.7938562Z .........................................i.......................................................... 6700/9251
---
2019-11-17T20:31:23.9010440Z  finished in 5.790
2019-11-17T20:31:23.9171429Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-17T20:31:24.1184432Z 
2019-11-17T20:31:24.1184623Z running 156 tests
2019-11-17T20:31:27.1300403Z iiii....iii......iii..iiii...i.............................i..i..................i....i...........ii 100/156
2019-11-17T20:31:28.9845608Z .i.i..iiii..............i.........iii.i.........ii......
2019-11-17T20:31:28.9846274Z 
2019-11-17T20:31:28.9851262Z  finished in 5.068
2019-11-17T20:31:29.0031376Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-17T20:31:29.1620372Z 
---
2019-11-17T20:31:31.1280955Z  finished in 2.125
2019-11-17T20:31:31.1463728Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-17T20:31:31.3215914Z 
2019-11-17T20:31:31.3216998Z running 9 tests
2019-11-17T20:31:31.3217977Z iiiiiiiii
2019-11-17T20:31:31.3219463Z 
2019-11-17T20:31:31.3219626Z  finished in 0.174
2019-11-17T20:31:31.3398863Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-17T20:31:31.5177546Z 
---
2019-11-17T20:31:50.8586578Z  finished in 19.519
2019-11-17T20:31:50.8799864Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-17T20:31:51.0573880Z 
2019-11-17T20:31:51.0574849Z running 123 tests
2019-11-17T20:32:14.4992751Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-11-17T20:32:19.0423655Z i.i.i......iii.i.....ii
2019-11-17T20:32:19.0425287Z 
2019-11-17T20:32:19.0431841Z  finished in 28.163
2019-11-17T20:32:19.0441774Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-17T20:32:19.0442208Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-11-17T20:40:59.7781179Z     |
2019-11-17T20:40:59.7782509Z 157 |             let node = Some(Box::into_raw_non_null(node));
2019-11-17T20:40:59.7782932Z     |                             ^^^^^^^^^^^^^^^^^^^^^^
2019-11-17T20:40:59.7783185Z     |
2019-11-17T20:40:59.7783717Z     = note: for more information, see ***/issues/47336
2019-11-17T20:40:59.7784110Z     = help: add `#![feature(box_into_raw_non_null)]` to the crate attributes to enable
2019-11-17T20:40:59.7842369Z error[E0658]: use of unstable library feature 'box_into_raw_non_null'
2019-11-17T20:40:59.7842729Z    --> src/liballoc/collections/linked_list.rs:198:29
2019-11-17T20:40:59.7842983Z     |
2019-11-17T20:40:59.7843348Z 198 |             let node = Some(Box::into_raw_non_null(node));
2019-11-17T20:40:59.7843348Z 198 |             let node = Some(Box::into_raw_non_null(node));
2019-11-17T20:40:59.7843682Z     |                             ^^^^^^^^^^^^^^^^^^^^^^
2019-11-17T20:40:59.7843955Z     |
2019-11-17T20:40:59.7844407Z     = note: for more information, see ***/issues/47336
2019-11-17T20:40:59.7844794Z     = help: add `#![feature(box_into_raw_non_null)]` to the crate attributes to enable
2019-11-17T20:40:59.8106769Z error[E0658]: use of unstable library feature 'box_into_raw_non_null'
2019-11-17T20:40:59.8107175Z    --> src/liballoc/collections/linked_list.rs:962:33
2019-11-17T20:40:59.8107463Z     |
2019-11-17T20:40:59.8107826Z 962 |                 let node = Some(Box::into_raw_non_null(box Node {
2019-11-17T20:40:59.8107826Z 962 |                 let node = Some(Box::into_raw_non_null(box Node {
2019-11-17T20:40:59.8108167Z     |                                 ^^^^^^^^^^^^^^^^^^^^^^
2019-11-17T20:40:59.8108792Z     |
2019-11-17T20:40:59.8109426Z     = note: for more information, see ***/issues/47336
2019-11-17T20:40:59.8109948Z     = help: add `#![feature(box_into_raw_non_null)]` to the crate attributes to enable
2019-11-17T20:41:00.1317194Z error[E0658]: use of unstable library feature 'box_into_raw_non_null'
2019-11-17T20:41:00.1317638Z    --> src/liballoc/sync.rs:310:26
2019-11-17T20:41:00.1317875Z     |
2019-11-17T20:41:00.1317875Z     |
2019-11-17T20:41:00.1318173Z 310 |         Self::from_inner(Box::into_raw_non_null(x))
2019-11-17T20:41:00.1318752Z     |
2019-11-17T20:41:00.1318752Z     |
2019-11-17T20:41:00.1319199Z     = note: for more information, see ***/issues/47336
2019-11-17T20:41:00.1319579Z     = help: add `#![feature(box_into_raw_non_null)]` to the crate attributes to enable
2019-11-17T20:41:00.2885825Z error[E0658]: use of unstable library feature 'box_into_raw_non_null'
2019-11-17T20:41:00.2886252Z    --> src/liballoc/rc.rs:326:26
2019-11-17T20:41:00.2886490Z     |
2019-11-17T20:41:00.2886490Z     |
2019-11-17T20:41:00.2886804Z 326 |         Self::from_inner(Box::into_raw_non_null(box RcBox {
2019-11-17T20:41:00.2887396Z     |
2019-11-17T20:41:00.2887396Z     |
2019-11-17T20:41:00.2887840Z     = note: for more information, see ***/issues/47336
2019-11-17T20:41:00.2888310Z     = help: add `#![feature(box_into_raw_non_null)]` to the crate attributes to enable
2019-11-17T20:41:00.6746531Z error: aborting due to 5 previous errors
2019-11-17T20:41:00.6746643Z 
2019-11-17T20:41:00.6755582Z For more information about this error, try `rustc --explain E0658`.
2019-11-17T20:41:00.7043518Z error: could not compile `alloc`.
---
2019-11-17T20:41:45.4976550Z   local time: Sun Nov 17 20:41:45 UTC 2019
2019-11-17T20:41:45.7673974Z   network time: Sun, 17 Nov 2019 20:41:45 GMT
2019-11-17T20:41:45.7675871Z == end clock drift check ==
2019-11-17T20:41:46.3481045Z 
2019-11-17T20:41:46.3583385Z ##[error]Bash exited with code '1'.
2019-11-17T20:41:46.3612718Z ##[section]Starting: Checkout
2019-11-17T20:41:46.3614657Z ==============================================================================
2019-11-17T20:41:46.3614705Z Task         : Get sources
2019-11-17T20:41:46.3614746Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril
Copy link
Contributor

Centril commented Nov 17, 2019

I have kept the #![feature(nll)] even though it is only necessary in libstd, to make regressions of it harder.

Seems like some of them were removed. Please re-add them.

@bjorn3
Copy link
Member Author

bjorn3 commented Nov 18, 2019

Seems like some of them were removed. Please re-add them.

Done. Also hopefully fixed the CI error.

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-11-18T19:41:46.7698620Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-18T19:41:46.7934768Z ##[command]git config gc.auto 0
2019-11-18T19:41:46.7977480Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-18T19:41:46.8044229Z ##[command]git config --get-all http.proxy
2019-11-18T19:41:46.8197997Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66498/merge:refs/remotes/pull/66498/merge
---
2019-11-18T20:42:18.0961252Z .................................................................................................... 1500/9251
2019-11-18T20:42:24.4760648Z .................................................................................................... 1600/9251
2019-11-18T20:42:33.4674192Z .................................................................................................... 1700/9251
2019-11-18T20:42:42.7670725Z ........i........................................................................................... 1800/9251
2019-11-18T20:42:49.6613145Z .............................................................................................iiiii.. 1900/9251
2019-11-18T20:43:12.2657000Z .................................................................................................... 2100/9251
2019-11-18T20:43:14.7698603Z .................................................................................................... 2200/9251
2019-11-18T20:43:17.4682409Z .................................................................................................... 2300/9251
2019-11-18T20:43:23.9398377Z .................................................................................................... 2400/9251
---
2019-11-18T20:47:14.9721561Z .................................................................................................... 5400/9251
2019-11-18T20:47:25.8461994Z ...............................................................................i.................... 5500/9251
2019-11-18T20:47:34.1579081Z .................................................................................................... 5600/9251
2019-11-18T20:47:40.8421191Z .................................................................................................... 5700/9251
2019-11-18T20:47:51.5953007Z .................................................................ii...i..ii...........i............. 5800/9251
2019-11-18T20:48:14.8522940Z .................................................................................................... 6000/9251
2019-11-18T20:48:23.5256169Z .................................................................................................... 6100/9251
2019-11-18T20:48:23.5256169Z .................................................................................................... 6100/9251
2019-11-18T20:48:30.1710996Z ....................................................................................i..ii........... 6200/9251
2019-11-18T20:48:58.6719159Z .................................................................................................... 6400/9251
2019-11-18T20:49:03.6938926Z ....................................................i............................................... 6500/9251
2019-11-18T20:49:06.0344073Z .................................................................................................... 6600/9251
2019-11-18T20:49:08.5689237Z .........................................i.......................................................... 6700/9251
---
2019-11-18T20:54:36.1869174Z  finished in 6.067
2019-11-18T20:54:36.2066798Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-18T20:54:36.4023947Z 
2019-11-18T20:54:36.4025736Z running 156 tests
2019-11-18T20:54:39.4558631Z iiii....iii......iii..iiii...i.............................i..i..................i....i...........ii 100/156
2019-11-18T20:54:41.4623113Z .i.i..iiii..............i.........iii.i.........ii......
2019-11-18T20:54:41.4624050Z 
2019-11-18T20:54:41.4624108Z  finished in 5.255
2019-11-18T20:54:41.4811755Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-18T20:54:41.6589075Z 
---
2019-11-18T20:54:43.7174892Z  finished in 2.236
2019-11-18T20:54:43.7389596Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-18T20:54:43.9079657Z 
2019-11-18T20:54:43.9079914Z running 9 tests
2019-11-18T20:54:43.9080764Z iiiiiiiii
2019-11-18T20:54:43.9081319Z 
2019-11-18T20:54:43.9088367Z  finished in 0.169
2019-11-18T20:54:43.9294174Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-18T20:54:44.1161766Z 
---
2019-11-18T20:55:04.3735304Z  finished in 20.444
2019-11-18T20:55:04.3945131Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-18T20:55:04.5788904Z 
2019-11-18T20:55:04.5789132Z running 123 tests
2019-11-18T20:55:29.3446595Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-11-18T20:55:34.1612337Z i.i.i......iii.i.....ii
2019-11-18T20:55:34.1613382Z 
2019-11-18T20:55:34.1617527Z  finished in 29.767
2019-11-18T20:55:34.1627233Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-18T20:55:34.1627616Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-11-18T21:07:53.3221050Z 
2019-11-18T21:07:53.3221936Z    Doc-tests core
2019-11-18T21:07:58.4450713Z 
2019-11-18T21:07:58.4451505Z running 2421 tests
2019-11-18T21:08:09.6393901Z ......iiiii......................................................................................... 100/2421
2019-11-18T21:08:20.3899872Z .................................................................................ii................. 200/2421
2019-11-18T21:08:46.1339748Z ...i................................................................................................ 400/2421
2019-11-18T21:08:46.1339748Z ...i................................................................................................ 400/2421
2019-11-18T21:08:56.8110660Z ...................................................i..i..................iiii....................... 500/2421
2019-11-18T21:09:17.1381839Z .................................................................................................... 700/2421
2019-11-18T21:09:27.7483802Z .................................................................................................... 800/2421
2019-11-18T21:09:38.2064157Z .................................................................................................... 900/2421
2019-11-18T21:09:48.9257604Z .................................................................................................... 1000/2421
---
2019-11-18T21:12:28.3145270Z    Compiling std v0.0.0 (/checkout/src/libstd)
2019-11-18T21:12:32.9731842Z error[E0658]: use of unstable library feature 'clamp'
2019-11-18T21:12:32.9732887Z     --> src/libstd/f32.rs:1635:24
2019-11-18T21:12:32.9733383Z      |
2019-11-18T21:12:32.9734094Z 1635 |         let _ = 1.0f32.clamp(3.0, 1.0);
2019-11-18T21:12:32.9735109Z      |
2019-11-18T21:12:32.9735109Z      |
2019-11-18T21:12:32.9735809Z      = note: for more information, see ***/issues/44095
2019-11-18T21:12:32.9736635Z      = help: add `#![feature(clamp)]` to the crate attributes to enable
2019-11-18T21:12:32.9745953Z error[E0658]: use of unstable library feature 'clamp'
2019-11-18T21:12:32.9746543Z     --> src/libstd/f32.rs:1641:24
2019-11-18T21:12:32.9750072Z      |
2019-11-18T21:12:32.9750072Z      |
2019-11-18T21:12:32.9750479Z 1641 |         let _ = 1.0f32.clamp(NAN, 1.0);
2019-11-18T21:12:32.9751101Z      |
2019-11-18T21:12:32.9751101Z      |
2019-11-18T21:12:32.9751584Z      = note: for more information, see ***/issues/44095
2019-11-18T21:12:32.9751940Z      = help: add `#![feature(clamp)]` to the crate attributes to enable
2019-11-18T21:12:32.9752201Z error[E0658]: use of unstable library feature 'clamp'
2019-11-18T21:12:32.9752437Z     --> src/libstd/f32.rs:1647:24
2019-11-18T21:12:32.9752618Z      |
2019-11-18T21:12:32.9752618Z      |
2019-11-18T21:12:32.9752863Z 1647 |         let _ = 1.0f32.clamp(3.0, NAN);
2019-11-18T21:12:32.9753300Z      |
2019-11-18T21:12:32.9753300Z      |
2019-11-18T21:12:32.9753618Z      = note: for more information, see ***/issues/44095
2019-11-18T21:12:32.9753898Z      = help: add `#![feature(clamp)]` to the crate attributes to enable
2019-11-18T21:12:33.2237142Z error[E0658]: use of unstable library feature 'clamp'
2019-11-18T21:12:33.2239330Z     --> src/libstd/f64.rs:1576:24
2019-11-18T21:12:33.2239933Z      |
2019-11-18T21:12:33.2239933Z      |
2019-11-18T21:12:33.2240642Z 1576 |         let _ = 1.0f64.clamp(3.0, 1.0);
2019-11-18T21:12:33.2241645Z      |
2019-11-18T21:12:33.2241645Z      |
2019-11-18T21:12:33.2242200Z      = note: for more information, see ***/issues/44095
2019-11-18T21:12:33.2242830Z      = help: add `#![feature(clamp)]` to the crate attributes to enable
2019-11-18T21:12:33.2251182Z error[E0658]: use of unstable library feature 'clamp'
2019-11-18T21:12:33.2251786Z     --> src/libstd/f64.rs:1582:24
2019-11-18T21:12:33.2252512Z      |
2019-11-18T21:12:33.2252512Z      |
2019-11-18T21:12:33.2252966Z 1582 |         let _ = 1.0f64.clamp(NAN, 1.0);
2019-11-18T21:12:33.2253746Z      |
2019-11-18T21:12:33.2253746Z      |
2019-11-18T21:12:33.2254260Z      = note: for more information, see ***/issues/44095
2019-11-18T21:12:33.2254740Z      = help: add `#![feature(clamp)]` to the crate attributes to enable
2019-11-18T21:12:33.2255287Z error[E0658]: use of unstable library feature 'clamp'
2019-11-18T21:12:33.2255949Z     --> src/libstd/f64.rs:1588:24
2019-11-18T21:12:33.2256311Z      |
2019-11-18T21:12:33.2256311Z      |
2019-11-18T21:12:33.2257139Z 1588 |         let _ = 1.0f64.clamp(3.0, NAN);
2019-11-18T21:12:33.2258081Z      |
2019-11-18T21:12:33.2258081Z      |
2019-11-18T21:12:33.2258616Z      = note: for more information, see ***/issues/44095
2019-11-18T21:12:33.2259101Z      = help: add `#![feature(clamp)]` to the crate attributes to enable
2019-11-18T21:12:43.9559703Z error: aborting due to 6 previous errors
2019-11-18T21:12:43.9560554Z 
2019-11-18T21:12:43.9561449Z For more information about this error, try `rustc --explain E0658`.
2019-11-18T21:12:44.1032828Z error: could not compile `std`.
---
2019-11-18T21:12:44.1137392Z   local time: Mon Nov 18 21:12:44 UTC 2019
2019-11-18T21:12:44.6609478Z   network time: Mon, 18 Nov 2019 21:12:44 GMT
2019-11-18T21:12:44.6614786Z == end clock drift check ==
2019-11-18T21:12:45.1750864Z 
2019-11-18T21:12:45.1835012Z ##[error]Bash exited with code '1'.
2019-11-18T21:12:45.1900077Z ##[section]Starting: Checkout
2019-11-18T21:12:45.1901875Z ==============================================================================
2019-11-18T21:12:45.1901925Z Task         : Get sources
2019-11-18T21:12:45.1901969Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Dylan-DPC-zz
Copy link

From the errors, it looks like clamp is still unstable

@bors
Copy link
Contributor

bors commented Nov 19, 2019

☔ The latest upstream changes (presumably #66545) made this pull request unmergeable. Please resolve the merge conflicts.

@bjorn3 bjorn3 force-pushed the less_feature_flags branch from b216da4 to 761e263 Compare November 19, 2019 19:04
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-11-19T19:05:35.2814571Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-19T19:05:35.2829548Z ##[command]git config gc.auto 0
2019-11-19T19:05:36.2758318Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-19T19:05:36.2764686Z ##[command]git config --get-all http.proxy
2019-11-19T19:05:36.2771018Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66498/merge:refs/remotes/pull/66498/merge
---
2019-11-19T20:03:43.2383112Z .................................................................................................... 1500/9256
2019-11-19T20:03:49.4820124Z .................................................................................................... 1600/9256
2019-11-19T20:03:58.0231385Z .................................................................................................... 1700/9256
2019-11-19T20:04:07.0957733Z ........i........................................................................................... 1800/9256
2019-11-19T20:04:13.6471347Z .............................................................................................iiiii.. 1900/9256
2019-11-19T20:04:34.8817948Z .................................................................................................... 2100/9256
2019-11-19T20:04:37.3328271Z .................................................................................................... 2200/9256
2019-11-19T20:04:39.9675953Z .................................................................................................... 2300/9256
2019-11-19T20:04:46.1949148Z .................................................................................................... 2400/9256
---
2019-11-19T20:07:37.0483841Z ..............................................................................................i..... 4700/9256
2019-11-19T20:07:43.4782442Z ..........i......................................................................................... 4800/9256
2019-11-19T20:07:53.3296359Z .................................................................................................... 4900/9256
2019-11-19T20:07:58.3607249Z .................................................................................................... 5000/9256
2019-11-19T20:08:08.4881456Z ..................................................................................................ii 5100/9256
2019-11-19T20:08:13.6338734Z .ii...........i..................................................................................... 5200/9256
2019-11-19T20:08:24.2613024Z .................................................................................................... 5400/9256
2019-11-19T20:08:35.0318031Z ................................................................................i................... 5500/9256
2019-11-19T20:08:43.0819366Z .................................................................................................... 5600/9256
2019-11-19T20:08:49.7826087Z .................................................................................................... 5700/9256
2019-11-19T20:08:49.7826087Z .................................................................................................... 5700/9256
2019-11-19T20:09:00.4594930Z ..................................................................ii...i..ii...........i............ 5800/9256
2019-11-19T20:09:22.8789230Z .................................................................................................... 6000/9256
2019-11-19T20:09:31.2080500Z .................................................................................................... 6100/9256
2019-11-19T20:09:31.2080500Z .................................................................................................... 6100/9256
2019-11-19T20:09:36.5401826Z .......................................................................................i..ii........ 6200/9256
2019-11-19T20:10:03.4716598Z .................................................................................................... 6400/9256
2019-11-19T20:10:08.7561830Z .......................................................i............................................ 6500/9256
2019-11-19T20:10:11.1532662Z .................................................................................................... 6600/9256
2019-11-19T20:10:13.6630257Z ............................................i....................................................... 6700/9256
---
2019-11-19T20:15:29.3579568Z  finished in 5.695
2019-11-19T20:15:29.3780961Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-19T20:15:29.5585537Z 
2019-11-19T20:15:29.5587003Z running 156 tests
2019-11-19T20:15:32.4996286Z iiii....iii......iii..iiii...i.............................i..i..................i....i...........ii 100/156
2019-11-19T20:15:34.4766231Z .i.i..iiii..............i.........iii.i.........ii......
2019-11-19T20:15:34.4768185Z 
2019-11-19T20:15:34.4770384Z  finished in 5.099
2019-11-19T20:15:34.4964491Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-19T20:15:34.6696071Z 
---
2019-11-19T20:15:36.6995474Z  finished in 2.203
2019-11-19T20:15:36.7195114Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-19T20:15:36.8797347Z 
2019-11-19T20:15:36.8797572Z running 9 tests
2019-11-19T20:15:36.8798338Z iiiiiiiii
2019-11-19T20:15:36.8798746Z 
2019-11-19T20:15:36.8798790Z  finished in 0.160
2019-11-19T20:15:36.8992163Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-19T20:15:37.0795151Z 
---
2019-11-19T20:15:56.9424862Z  finished in 20.044
2019-11-19T20:15:56.9649170Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-19T20:15:57.8354617Z 
2019-11-19T20:15:57.8373065Z running 123 tests
2019-11-19T20:16:21.7367618Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-11-19T20:16:26.4723538Z i.i.i......iii.i.....ii
2019-11-19T20:16:26.4727881Z 
2019-11-19T20:16:26.4729412Z  finished in 29.508
2019-11-19T20:16:26.4741169Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-19T20:16:26.4741574Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-11-19T20:28:12.1112403Z 
2019-11-19T20:28:12.1117755Z    Doc-tests core
2019-11-19T20:28:17.0887906Z 
2019-11-19T20:28:17.0888148Z running 2421 tests
2019-11-19T20:28:27.4334477Z ......iiiii......................................................................................... 100/2421
2019-11-19T20:28:37.5206720Z .................................................................................ii................. 200/2421
2019-11-19T20:29:01.2454549Z ...i................................................................................................ 400/2421
2019-11-19T20:29:01.2454549Z ...i................................................................................................ 400/2421
2019-11-19T20:29:11.0047262Z ...................................................i..i..................iiii....................... 500/2421
2019-11-19T20:29:29.4444682Z .................................................................................................... 700/2421
2019-11-19T20:29:39.3468121Z .................................................................................................... 800/2421
2019-11-19T20:29:49.3637951Z .................................................................................................... 900/2421
2019-11-19T20:29:59.1323401Z .................................................................................................... 1000/2421
---
2019-11-19T20:32:30.6495729Z    Compiling std v0.0.0 (/checkout/src/libstd)
2019-11-19T20:32:48.5009118Z error: `ffi::c_str::CStr::from_bytes_with_nul_unchecked` is not yet stable as a const fn
2019-11-19T20:32:48.5012842Z     --> src/libstd/ffi/c_str.rs:1507:13
2019-11-19T20:32:48.5013132Z      |
2019-11-19T20:32:48.5013560Z 1507 |             CStr::from_bytes_with_nul_unchecked(b"Hello, world!\0")
2019-11-19T20:32:48.5014193Z      |
2019-11-19T20:32:48.5014567Z      = help: add `#![feature(const_cstr_unchecked)]` to the crate attributes to enable
2019-11-19T20:32:48.5014613Z 
2019-11-19T20:32:53.6172746Z error: aborting due to previous error
---
2019-11-19T20:32:53.8623536Z   local time: Tue Nov 19 20:32:53 UTC 2019
2019-11-19T20:32:53.9372961Z   network time: Tue, 19 Nov 2019 20:32:53 GMT
2019-11-19T20:32:53.9375862Z == end clock drift check ==
2019-11-19T20:32:54.5679245Z 
2019-11-19T20:32:54.5789552Z ##[error]Bash exited with code '1'.
2019-11-19T20:32:54.5841743Z ##[section]Starting: Checkout
2019-11-19T20:32:54.5843563Z ==============================================================================
2019-11-19T20:32:54.5843619Z Task         : Get sources
2019-11-19T20:32:54.5843679Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Nov 21, 2019

☔ The latest upstream changes (presumably #66607) made this pull request unmergeable. Please resolve the merge conflicts.

@bjorn3 bjorn3 force-pushed the less_feature_flags branch from 46db7df to 6c8e009 Compare November 22, 2019 14:29
@bjorn3
Copy link
Member Author

bjorn3 commented Nov 22, 2019

Some feature gates were only used with cfg(test), so I didn't notice them when running ./x.py check. I think I added all those feature gates used when testing again, so I hope it works now.

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-11-22T14:30:27.8458381Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-22T14:30:27.8472351Z ##[command]git config gc.auto 0
2019-11-22T14:30:27.8475315Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-22T14:30:27.8480056Z ##[command]git config --get-all http.proxy
2019-11-22T14:30:27.8484501Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66498/merge:refs/remotes/pull/66498/merge
---
2019-11-22T14:36:10.4406126Z      |
2019-11-22T14:36:10.4406383Z 4725 | impl From<!> for TryFromIntError {
2019-11-22T14:36:10.4406788Z      |           ^
2019-11-22T14:36:10.4406966Z      |
2019-11-22T14:36:10.4407325Z      = note: for more information, see ***/issues/35121
2019-11-22T14:36:10.4407854Z      = help: add `#![feature(never_type)]` to the crate attributes to enable
2019-11-22T14:36:10.4428936Z error[E0658]: The `!` type is experimental
2019-11-22T14:36:10.4429183Z     --> src/libcore/num/mod.rs:4726:20
2019-11-22T14:36:10.4429365Z      |
2019-11-22T14:36:10.4429365Z      |
2019-11-22T14:36:10.4429611Z 4726 |     fn from(never: !) -> TryFromIntError {
2019-11-22T14:36:10.4429992Z      |
2019-11-22T14:36:10.4429992Z      |
2019-11-22T14:36:10.4430302Z      = note: for more information, see ***/issues/35121
2019-11-22T14:36:10.4430557Z      = help: add `#![feature(never_type)]` to the crate attributes to enable
2019-11-22T14:36:10.4547472Z error[E0658]: The `!` type is experimental
2019-11-22T14:36:10.4547721Z    --> src/libcore/marker.rs:778:19
2019-11-22T14:36:10.4547918Z     |
2019-11-22T14:36:10.4547918Z     |
2019-11-22T14:36:10.4548129Z 778 |     impl Copy for ! {}
2019-11-22T14:36:10.4548524Z     |
2019-11-22T14:36:10.4548524Z     |
2019-11-22T14:36:10.4548815Z     = note: for more information, see ***/issues/35121
2019-11-22T14:36:10.4549074Z     = help: add `#![feature(never_type)]` to the crate attributes to enable
2019-11-22T14:36:10.4711489Z error[E0658]: The `!` type is experimental
2019-11-22T14:36:10.4712121Z     --> src/libcore/cmp.rs:1132:24
2019-11-22T14:36:10.4712517Z      |
2019-11-22T14:36:10.4713280Z 1132 |     impl PartialEq for ! {
2019-11-22T14:36:10.4713280Z 1132 |     impl PartialEq for ! {
2019-11-22T14:36:10.4713547Z      |                        ^
2019-11-22T14:36:10.4713756Z      |
2019-11-22T14:36:10.4714110Z      = note: for more information, see ***/issues/35121
2019-11-22T14:36:10.4714575Z      = help: add `#![feature(never_type)]` to the crate attributes to enable
2019-11-22T14:36:10.4743010Z error[E0658]: The `!` type is experimental
2019-11-22T14:36:10.4743522Z     --> src/libcore/cmp.rs:1133:26
2019-11-22T14:36:10.4743761Z      |
2019-11-22T14:36:10.4743761Z      |
2019-11-22T14:36:10.4744158Z 1133 |         fn eq(&self, _: &!) -> bool {
2019-11-22T14:36:10.4744614Z      |
2019-11-22T14:36:10.4744614Z      |
2019-11-22T14:36:10.4745150Z      = note: for more information, see ***/issues/35121
2019-11-22T14:36:10.4745420Z      = help: add `#![feature(never_type)]` to the crate attributes to enable
2019-11-22T14:36:10.4774391Z error[E0658]: The `!` type is experimental
2019-11-22T14:36:10.4774870Z     --> src/libcore/cmp.rs:1139:17
2019-11-22T14:36:10.4775082Z      |
2019-11-22T14:36:10.4775082Z      |
2019-11-22T14:36:10.4775514Z 1139 |     impl Eq for ! {}
2019-11-22T14:36:10.4775901Z      |
2019-11-22T14:36:10.4775901Z      |
2019-11-22T14:36:10.4776421Z      = note: for more information, see ***/issues/35121
2019-11-22T14:36:10.4776696Z      = help: add `#![feature(never_type)]` to the crate attributes to enable
2019-11-22T14:36:10.4804839Z error[E0658]: The `!` type is experimental
2019-11-22T14:36:10.4805148Z     --> src/libcore/cmp.rs:1142:25
2019-11-22T14:36:10.4805358Z      |
2019-11-22T14:36:10.4805590Z 1142 |     impl PartialOrd for ! {
2019-11-22T14:36:10.4805590Z 1142 |     impl PartialOrd for ! {
2019-11-22T14:36:10.4805833Z      |                         ^
2019-11-22T14:36:10.4806209Z      |
2019-11-22T14:36:10.4807898Z      = note: for more information, see ***/issues/35121
2019-11-22T14:36:10.4808246Z      = help: add `#![feature(never_type)]` to the crate attributes to enable
2019-11-22T14:36:10.4890508Z error[E0658]: The `!` type is experimental
2019-11-22T14:36:10.4891346Z     --> src/libcore/cmp.rs:1143:35
2019-11-22T14:36:10.4891574Z      |
2019-11-22T14:36:10.4891574Z      |
2019-11-22T14:36:10.4892016Z 1143 |         fn partial_cmp(&self, _: &!) -> Option<Ordering> {
2019-11-22T14:36:10.4892732Z      |
2019-11-22T14:36:10.4892732Z      |
2019-11-22T14:36:10.4893076Z      = note: for more information, see ***/issues/35121
2019-11-22T14:36:10.4893593Z      = help: add `#![feature(never_type)]` to the crate attributes to enable
2019-11-22T14:36:10.4896933Z error[E0658]: The `!` type is experimental
2019-11-22T14:36:10.4897461Z     --> src/libcore/cmp.rs:1149:18
2019-11-22T14:36:10.4897645Z      |
2019-11-22T14:36:10.4898109Z 1149 |     impl Ord for ! {
2019-11-22T14:36:10.4898109Z 1149 |     impl Ord for ! {
2019-11-22T14:36:10.4898491Z      |                  ^
2019-11-22T14:36:10.4898706Z      |
2019-11-22T14:36:10.4899236Z      = note: for more information, see ***/issues/35121
2019-11-22T14:36:10.4899979Z      = help: add `#![feature(never_type)]` to the crate attributes to enable
2019-11-22T14:36:10.4903631Z error[E0658]: The `!` type is experimental
2019-11-22T14:36:10.4903900Z     --> src/libcore/cmp.rs:1150:27
2019-11-22T14:36:10.4904073Z      |
2019-11-22T14:36:10.4904073Z      |
2019-11-22T14:36:10.4904325Z 1150 |         fn cmp(&self, _: &!) -> Ordering {
2019-11-22T14:36:10.4904705Z      |
2019-11-22T14:36:10.4904705Z      |
2019-11-22T14:36:10.4905010Z      = note: for more information, see ***/issues/35121
2019-11-22T14:36:10.4905653Z      = help: add `#![feature(never_type)]` to the crate attributes to enable
2019-11-22T14:36:10.4911209Z error[E0658]: The `!` type is experimental
2019-11-22T14:36:10.4911518Z    --> src/libcore/clone.rs:189:20
2019-11-22T14:36:10.4911760Z     |
2019-11-22T14:36:10.4912016Z 189 |     impl Clone for ! {
2019-11-22T14:36:10.4912016Z 189 |     impl Clone for ! {
2019-11-22T14:36:10.4912265Z     |                    ^
2019-11-22T14:36:10.4912490Z     |
2019-11-22T14:36:10.4912816Z     = note: for more information, see ***/issues/35121
2019-11-22T14:36:10.4913114Z     = help: add `#![feature(never_type)]` to the crate attributes to enable
2019-11-22T14:36:10.4925908Z error[E0658]: The `!` type is experimental
2019-11-22T14:36:10.4926312Z    --> src/libcore/convert.rs:557:14
2019-11-22T14:36:10.4926492Z     |
2019-11-22T14:36:10.4926821Z 557 | impl<T> From<!> for T {
2019-11-22T14:36:10.4926821Z 557 | impl<T> From<!> for T {
2019-11-22T14:36:10.4927051Z     |              ^
2019-11-22T14:36:10.4927221Z     |
2019-11-22T14:36:10.4927514Z     = note: for more information, see ***/issues/35121
2019-11-22T14:36:10.4927791Z     = help: add `#![feature(never_type)]` to the crate attributes to enable
2019-11-22T14:36:10.4928017Z error[E0658]: The `!` type is experimental
2019-11-22T14:36:10.4928254Z    --> src/libcore/convert.rs:558:16
2019-11-22T14:36:10.4928423Z     |
2019-11-22T14:36:10.4928423Z     |
2019-11-22T14:36:10.4928633Z 558 |     fn from(t: !) -> T { t }
2019-11-22T14:36:10.4929022Z     |
2019-11-22T14:36:10.4929022Z     |
2019-11-22T14:36:10.4929304Z     = note: for more information, see ***/issues/35121
2019-11-22T14:36:10.4929555Z     = help: add `#![feature(never_type)]` to the crate attributes to enable
2019-11-22T14:36:10.4972148Z error[E0658]: The `!` type is experimental
2019-11-22T14:36:10.4972580Z    --> src/libcore/convert.rs:643:23
2019-11-22T14:36:10.4972820Z     |
2019-11-22T14:36:10.4973187Z 643 | pub type Infallible = !;
2019-11-22T14:36:10.4973187Z 643 | pub type Infallible = !;
2019-11-22T14:36:10.4973448Z     |                       ^
2019-11-22T14:36:10.4973616Z     |
2019-11-22T14:36:10.4973924Z     = note: for more information, see ***/issues/35121
2019-11-22T14:36:10.4974179Z     = help: add `#![feature(never_type)]` to the crate attributes to enable
2019-11-22T14:36:10.5025451Z error[E0658]: The `!` type is experimental
2019-11-22T14:36:10.5025709Z     --> src/libcore/iter/traits/iterator.rs:1828:84
2019-11-22T14:36:10.5025888Z      |
2019-11-22T14:36:10.5025888Z      |
2019-11-22T14:36:10.5026249Z 1828 |         fn ok<B, T>(mut f: impl FnMut(B, T) -> B) -> impl FnMut(B, T) -> Result<B, !> {
2019-11-22T14:36:10.5027069Z      |
2019-11-22T14:36:10.5027069Z      |
2019-11-22T14:36:10.5027614Z      = note: for more information, see ***/issues/35121
2019-11-22T14:36:10.5028069Z      = help: add `#![feature(never_type)]` to the crate attributes to enable
2019-11-22T14:36:10.5064208Z error[E0658]: The `!` type is experimental
2019-11-22T14:36:10.5064461Z    --> src/libcore/iter/traits/double_ended.rs:228:84
2019-11-22T14:36:10.5064709Z     |
2019-11-22T14:36:10.5064709Z     |
2019-11-22T14:36:10.5064987Z 228 |         fn ok<B, T>(mut f: impl FnMut(B, T) -> B) -> impl FnMut(B, T) -> Result<B, !> {
2019-11-22T14:36:10.5065451Z     |
2019-11-22T14:36:10.5065451Z     |
2019-11-22T14:36:10.5065738Z     = note: for more information, see ***/issues/35121
2019-11-22T14:36:10.5066390Z     = help: add `#![feature(never_type)]` to the crate attributes to enable
2019-11-22T14:36:10.5238246Z error[E0658]: The `!` type is experimental
2019-11-22T14:36:10.5238518Z    --> src/libcore/hash/mod.rs:616:19
2019-11-22T14:36:10.5238738Z     |
2019-11-22T14:36:10.5238947Z 616 |     impl Hash for ! {
2019-11-22T14:36:10.5238947Z 616 |     impl Hash for ! {
2019-11-22T14:36:10.5239212Z     |                   ^
2019-11-22T14:36:10.5239380Z     |
2019-11-22T14:36:10.5239686Z     = note: for more information, see ***/issues/35121
2019-11-22T14:36:10.5240195Z     = help: add `#![feature(never_type)]` to the crate attributes to enable
2019-11-22T14:36:10.5299864Z error[E0658]: The `!` type is experimental
2019-11-22T14:36:10.5300107Z     --> src/libcore/fmt/mod.rs:1939:16
2019-11-22T14:36:10.5300330Z      |
2019-11-22T14:36:10.5300568Z 1939 | impl Debug for ! {
2019-11-22T14:36:10.5300568Z 1939 | impl Debug for ! {
2019-11-22T14:36:10.5300776Z      |                ^
2019-11-22T14:36:10.5301103Z      |
2019-11-22T14:36:10.5301463Z      = note: for more information, see ***/issues/35121
2019-11-22T14:36:10.5302119Z      = help: add `#![feature(never_type)]` to the crate attributes to enable
2019-11-22T14:36:10.5331634Z error[E0658]: The `!` type is experimental
2019-11-22T14:36:10.5331980Z     --> src/libcore/fmt/mod.rs:1946:18
2019-11-22T14:36:10.5332182Z      |
2019-11-22T14:36:10.5332393Z 1946 | impl Display for ! {
2019-11-22T14:36:10.5332393Z 1946 | impl Display for ! {
2019-11-22T14:36:10.5332599Z      |                  ^
2019-11-22T14:36:10.5332780Z      |
2019-11-22T14:36:10.5333270Z      = note: for more information, see ***/issues/35121
2019-11-22T14:36:10.5333533Z      = help: add `#![feature(never_type)]` to the crate attributes to enable
2019-11-22T14:36:13.2458796Z    Compiling build_helper v0.1.0 (/checkout/src/build_helper)
2019-11-22T14:36:14.1348362Z    Compiling libc v0.2.64
2019-11-22T14:36:14.6988912Z    Compiling autocfg v0.1.6
2019-11-22T14:36:15.6350441Z    Compiling std v0.0.0 (/checkout/src/libstd)
---
2019-11-22T14:36:17.7826025Z   local time: Fri Nov 22 14:36:17 UTC 2019
2019-11-22T14:36:17.8200544Z   network time: Fri, 22 Nov 2019 14:36:17 GMT
2019-11-22T14:36:17.8206996Z == end clock drift check ==
2019-11-22T14:36:19.2871412Z 
2019-11-22T14:36:19.2955082Z ##[error]Bash exited with code '1'.
2019-11-22T14:36:19.2983021Z ##[section]Starting: Checkout
2019-11-22T14:36:19.2984907Z ==============================================================================
2019-11-22T14:36:19.2984954Z Task         : Get sources
2019-11-22T14:36:19.2985013Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-11-22T14:46:48.5976259Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-22T14:46:48.6159874Z ##[command]git config gc.auto 0
2019-11-22T14:46:48.6234781Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-22T14:46:48.6283533Z ##[command]git config --get-all http.proxy
2019-11-22T14:46:48.6424305Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66498/merge:refs/remotes/pull/66498/merge
---
2019-11-22T14:53:12.3031345Z    Compiling panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
2019-11-22T14:53:16.5581549Z error[E0658]: dereferencing raw pointers in constant functions is unstable
2019-11-22T14:53:16.5583300Z     --> src/libstd/ffi/c_str.rs:1070:9
2019-11-22T14:53:16.5585326Z      |
2019-11-22T14:53:16.5585962Z 1070 |         &*(bytes as *const [u8] as *const CStr)
2019-11-22T14:53:16.5587074Z      |
2019-11-22T14:53:16.5587074Z      |
2019-11-22T14:53:16.5587673Z      = note: for more information, see ***/issues/51911
2019-11-22T14:53:16.5588841Z 
2019-11-22T14:53:17.7301316Z error: aborting due to previous error
2019-11-22T14:53:17.7302260Z 
2019-11-22T14:53:17.7303571Z For more information about this error, try `rustc --explain E0658`.
---
2019-11-22T14:53:17.7943795Z   local time: Fri Nov 22 14:53:17 UTC 2019
2019-11-22T14:53:18.0714658Z   network time: Fri, 22 Nov 2019 14:53:18 GMT
2019-11-22T14:53:18.0714913Z == end clock drift check ==
2019-11-22T14:53:20.9435547Z 
2019-11-22T14:53:20.9544676Z ##[error]Bash exited with code '1'.
2019-11-22T14:53:20.9571052Z ##[section]Starting: Checkout
2019-11-22T14:53:20.9573214Z ==============================================================================
2019-11-22T14:53:20.9573296Z Task         : Get sources
2019-11-22T14:53:20.9573345Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-11-22T15:01:01.1333124Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-22T15:01:01.1568260Z ##[command]git config gc.auto 0
2019-11-22T15:01:01.1628188Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-22T15:01:01.1736551Z ##[command]git config --get-all http.proxy
2019-11-22T15:01:01.1898976Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66498/merge:refs/remotes/pull/66498/merge
---
2019-11-22T15:10:00.6195193Z configure: build.locked-deps    := True
2019-11-22T15:10:00.6195273Z configure: llvm.ccache          := sccache
2019-11-22T15:10:00.6195514Z configure: build.cargo-native-static := True
2019-11-22T15:10:00.6195741Z configure: dist.missing-tools   := True
2019-11-22T15:10:00.6196010Z configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
2019-11-22T15:10:00.6196125Z configure: writing `config.toml` in current directory
2019-11-22T15:10:00.6196168Z configure: 
2019-11-22T15:10:00.6196384Z configure: run `python /checkout/x.py --help`
2019-11-22T15:10:00.6196443Z configure: 
---
2019-11-22T15:11:50.0627517Z     Checking cfg-if v0.1.8
2019-11-22T15:11:50.0668845Z     Checking alloc v0.0.0 (/checkout/src/liballoc)
2019-11-22T15:11:50.1506126Z     Checking rustc-demangle v0.1.16
2019-11-22T15:11:50.4748240Z     Checking panic_abort v0.0.0 (/checkout/src/libpanic_abort)
2019-11-22T15:11:50.5104576Z error[E0658]: use of unstable library feature 'core_intrinsics': intrinsics are unlikely to ever be stabilized, instead they should be used through stabilized interfaces in the rest of the standard library
2019-11-22T15:11:50.5104937Z   --> src/libpanic_abort/lib.rs:52:9
2019-11-22T15:11:50.5110491Z 52 |         core::intrinsics::abort();
2019-11-22T15:11:50.5111319Z    |         ^^^^^^^^^^^^^^^^^^^^^^^
2019-11-22T15:11:50.5111790Z    |
2019-11-22T15:11:50.5112291Z    = help: add `#![feature(core_intrinsics)]` to the crate attributes to enable
---
2019-11-22T15:11:52.6537310Z   local time: Fri Nov 22 15:11:52 UTC 2019
2019-11-22T15:11:52.8018607Z   network time: Fri, 22 Nov 2019 15:11:52 GMT
2019-11-22T15:11:52.8026085Z == end clock drift check ==
2019-11-22T15:12:01.8389106Z 
2019-11-22T15:12:01.8517284Z ##[error]Bash exited with code '1'.
2019-11-22T15:12:01.8550117Z ##[section]Starting: Checkout
2019-11-22T15:12:01.8552285Z ==============================================================================
2019-11-22T15:12:01.8552342Z Task         : Get sources
2019-11-22T15:12:01.8552404Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-11-26T19:42:01.3916613Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-26T19:42:01.3928276Z ##[command]git config gc.auto 0
2019-11-26T19:42:01.3931835Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-26T19:42:01.3935034Z ##[command]git config --get-all http.proxy
2019-11-26T19:42:01.3938432Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66498/merge:refs/remotes/pull/66498/merge
---
2019-11-26T19:49:47.1005428Z configure: build.locked-deps    := True
2019-11-26T19:49:47.1005467Z configure: llvm.ccache          := sccache
2019-11-26T19:49:47.1005655Z configure: build.cargo-native-static := True
2019-11-26T19:49:47.1005821Z configure: dist.missing-tools   := True
2019-11-26T19:49:47.1006025Z configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
2019-11-26T19:49:47.1006127Z configure: writing `config.toml` in current directory
2019-11-26T19:49:47.1006173Z configure: 
2019-11-26T19:49:47.1006367Z configure: run `python /checkout/x.py --help`
2019-11-26T19:49:47.1006405Z configure: 
---
2019-11-26T19:51:23.4148474Z     Checking panic_abort v0.0.0 (/checkout/src/libpanic_abort)
2019-11-26T19:51:23.5214587Z     Checking backtrace v0.3.40
2019-11-26T19:51:25.2371475Z     Checking rustc-std-workspace-alloc v1.99.0 (/checkout/src/tools/rustc-std-workspace-alloc)
2019-11-26T19:51:25.2394786Z     Checking panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
2019-11-26T19:51:26.8504545Z error[E0658]: use of unstable library feature 'slice_internals': exposed from core to be reused in std; use the memchr crate
2019-11-26T19:51:26.8505651Z   --> src/libstd/memchr.rs:25:5
2019-11-26T19:51:26.8506118Z    |
2019-11-26T19:51:26.8506525Z 25 |     crate::sys::memchr::memchr(needle, haystack)
2019-11-26T19:51:26.8507283Z    |
2019-11-26T19:51:26.8507745Z    = help: add `#![feature(slice_internals)]` to the crate attributes to enable
2019-11-26T19:51:26.8507929Z 
2019-11-26T19:51:26.8507929Z 
2019-11-26T19:51:26.8508382Z error[E0658]: use of unstable library feature 'slice_internals': exposed from core to be reused in std; use the memchr crate
2019-11-26T19:51:26.8508776Z   --> src/libstd/memchr.rs:45:5
2019-11-26T19:51:26.8509117Z    |
2019-11-26T19:51:26.8509538Z 45 |     crate::sys::memchr::memrchr(needle, haystack)
2019-11-26T19:51:26.8510314Z    |
2019-11-26T19:51:26.8510729Z    = help: add `#![feature(slice_internals)]` to the crate attributes to enable
2019-11-26T19:51:26.8510885Z 
2019-11-26T19:51:26.8510885Z 
2019-11-26T19:51:26.8522781Z error[E0658]: use of unstable library feature 'slice_internals': exposed from core to be reused in std; use the memchr crate
2019-11-26T19:51:26.8523363Z  --> src/libstd/sys/windows/memchr.rs:5:31
2019-11-26T19:51:26.8523770Z   |
2019-11-26T19:51:26.8524190Z 5 | pub use core::slice::memchr::{memchr, memrchr};
2019-11-26T19:51:26.8524941Z   |
2019-11-26T19:51:26.8525392Z   = help: add `#![feature(slice_internals)]` to the crate attributes to enable
2019-11-26T19:51:26.8525557Z 
2019-11-26T19:51:26.8525557Z 
2019-11-26T19:51:26.8533091Z error[E0658]: use of unstable library feature 'slice_internals': exposed from core to be reused in std; use the memchr crate
2019-11-26T19:51:26.8533609Z  --> src/libstd/sys/windows/memchr.rs:5:39
2019-11-26T19:51:26.8534190Z   |
2019-11-26T19:51:26.8534633Z 5 | pub use core::slice::memchr::{memchr, memrchr};
2019-11-26T19:51:26.8535748Z   |
2019-11-26T19:51:26.8536171Z   = help: add `#![feature(slice_internals)]` to the crate attributes to enable
2019-11-26T19:51:26.8539345Z 
2019-11-26T19:51:28.3879172Z error: aborting due to 4 previous errors
---
2019-11-26T19:51:28.4279039Z   local time: Tue Nov 26 19:51:28 UTC 2019
2019-11-26T19:51:28.4968040Z   network time: Tue, 26 Nov 2019 19:51:28 GMT
2019-11-26T19:51:28.4968103Z == end clock drift check ==
2019-11-26T19:51:37.7173704Z 
2019-11-26T19:51:37.7263187Z ##[error]Bash exited with code '1'.
2019-11-26T19:51:37.7296306Z ##[section]Starting: Checkout
2019-11-26T19:51:37.7297864Z ==============================================================================
2019-11-26T19:51:37.7297906Z Task         : Get sources
2019-11-26T19:51:37.7297943Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Dylan-DPC-zz
Copy link

From the error it looks like slice_internals is still required

@Dylan-DPC-zz Dylan-DPC-zz added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2019
@bors
Copy link
Contributor

bors commented Dec 1, 2019

☔ The latest upstream changes (presumably #66908) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnCSimon
Copy link
Member

Ping from triage:
@bjorn3 Can you please address the merge conflicts, build failures and the comment from Dylan-DPC?
Thank you.

@JohnCSimon
Copy link
Member

Pinging again from triage:
@bjorn3 Can you please address the merge conflicts, etc?
Thanks.

@bjorn3 bjorn3 force-pushed the less_feature_flags branch from e475da6 to b18a225 Compare December 16, 2019 10:13
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-16T10:17:35.9926673Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-16T10:17:36.0093279Z ##[command]git config gc.auto 0
2019-12-16T10:17:36.0166331Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-16T10:17:36.0209335Z ##[command]git config --get-all http.proxy
2019-12-16T10:17:36.9978377Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66498/merge:refs/remotes/pull/66498/merge
---
2019-12-16T10:43:37.1467741Z    Compiling autocfg v0.1.6
2019-12-16T10:43:38.2062119Z    Compiling std v0.0.0 (/checkout/src/libstd)
2019-12-16T10:43:38.5966521Z    Compiling cmake v0.1.38
2019-12-16T10:43:40.6239513Z    Compiling compiler_builtins v0.1.22
2019-12-16T10:43:41.4333108Z error: `num::<impl i8>::to_ne_bytes` is not yet stable as a const fn
2019-12-16T10:43:41.4334686Z     --> src/libcore/num/mod.rs:2217:17
2019-12-16T10:43:41.4335896Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:41.4335896Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:41.4336475Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:41.4337052Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:41.4337785Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:41.4338250Z ...    |
2019-12-16T10:43:41.4338773Z 2217 | |                 self.to_be().to_ne_bytes()
2019-12-16T10:43:41.4339698Z ...    |
2019-12-16T10:43:41.4340182Z 2406 | |     }
2019-12-16T10:43:41.4340825Z 2407 | | }
2019-12-16T10:43:41.4341550Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:41.4341550Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:41.4342011Z ...
2019-12-16T10:43:41.4342631Z 2411 | /     int_impl! { i8, i8, u8, 8, -128, 127, "", "", 2, "-0x7e", "0xa", "0x12", "0x12", "0x48",
2019-12-16T10:43:41.4343215Z 2412 | |     "[0x12]", "[0x12]", "", "" }
2019-12-16T10:43:41.4344557Z      |
2019-12-16T10:43:41.4345066Z      = help: add `#![feature(const_int_conversion)]` to the crate attributes to enable
2019-12-16T10:43:41.4347798Z 
2019-12-16T10:43:41.4347798Z 
2019-12-16T10:43:41.5009542Z error: `num::<impl i16>::to_ne_bytes` is not yet stable as a const fn
2019-12-16T10:43:41.5010340Z     --> src/libcore/num/mod.rs:2217:17
2019-12-16T10:43:41.5011372Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:41.5011372Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:41.5011939Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:41.5012534Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:41.5013059Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:41.5013543Z ...    |
2019-12-16T10:43:41.5014234Z 2217 | |                 self.to_be().to_ne_bytes()
2019-12-16T10:43:41.5016296Z ...    |
2019-12-16T10:43:41.5016922Z 2406 | |     }
2019-12-16T10:43:41.5017426Z 2407 | | }
2019-12-16T10:43:41.5017891Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:41.5017891Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:41.5018265Z ...
2019-12-16T10:43:41.5019265Z 2417 | /     int_impl! { i16, i16, u16, 16, -32768, 32767, "", "", 4, "-0x5ffd", "0x3a", "0x1234", "0x3412",
2019-12-16T10:43:41.5019939Z 2418 | |     "0x2c48", "[0x34, 0x12]", "[0x12, 0x34]", "", "" }
2019-12-16T10:43:41.5020772Z      |
2019-12-16T10:43:41.5021192Z      = help: add `#![feature(const_int_conversion)]` to the crate attributes to enable
2019-12-16T10:43:41.5021348Z 
2019-12-16T10:43:41.5021348Z 
2019-12-16T10:43:41.5769300Z error: `num::<impl i32>::to_ne_bytes` is not yet stable as a const fn
2019-12-16T10:43:41.5769622Z     --> src/libcore/num/mod.rs:2217:17
2019-12-16T10:43:41.5770135Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:41.5770135Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:41.5770509Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:41.5770860Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:41.5771183Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:41.5771411Z ...    |
2019-12-16T10:43:41.5771697Z 2217 | |                 self.to_be().to_ne_bytes()
2019-12-16T10:43:41.5772234Z ...    |
2019-12-16T10:43:41.5772501Z 2406 | |     }
2019-12-16T10:43:41.5772755Z 2407 | | }
2019-12-16T10:43:41.5773025Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:41.5773025Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:41.5773223Z ...
2019-12-16T10:43:41.5773567Z 2423 | /     int_impl! { i32, i32, u32, 32, -2147483648, 2147483647, "", "", 8, "0x10000b3", "0xb301",
2019-12-16T10:43:41.5774056Z 2424 | |     "0x12345678", "0x78563412", "0x1e6a2c48", "[0x78, 0x56, 0x34, 0x12]",
2019-12-16T10:43:41.5774419Z 2425 | |     "[0x12, 0x34, 0x56, 0x78]", "", "" }
2019-12-16T10:43:41.5775090Z      |
2019-12-16T10:43:41.5775386Z      = help: add `#![feature(const_int_conversion)]` to the crate attributes to enable
2019-12-16T10:43:41.5778202Z 
2019-12-16T10:43:41.5778202Z 
2019-12-16T10:43:41.6491912Z error: `num::<impl i64>::to_ne_bytes` is not yet stable as a const fn
2019-12-16T10:43:41.6492397Z     --> src/libcore/num/mod.rs:2217:17
2019-12-16T10:43:41.6492861Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:41.6492861Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:41.6493165Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:41.6493486Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:41.6493760Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:41.6493971Z ...    |
2019-12-16T10:43:41.6494231Z 2217 | |                 self.to_be().to_ne_bytes()
2019-12-16T10:43:41.6494698Z ...    |
2019-12-16T10:43:41.6494918Z 2406 | |     }
2019-12-16T10:43:41.6495136Z 2407 | | }
2019-12-16T10:43:41.6495399Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:41.6495399Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:41.6495741Z ...
2019-12-16T10:43:41.6496220Z 2430 | /     int_impl! { i64, i64, u64, 64, -9223372036854775808, 9223372036854775807, "", "", 12,
2019-12-16T10:43:41.6496774Z 2431 | |     "0xaa00000000006e1", "0x6e10aa", "0x1234567890123456", "0x5634129078563412",
2019-12-16T10:43:41.6497114Z 2432 | |     "0x6a2c48091e6a2c48", "[0x56, 0x34, 0x12, 0x90, 0x78, 0x56, 0x34, 0x12]",
2019-12-16T10:43:41.6498276Z 2433 | |     "[0x12, 0x34, 0x56, 0x78, 0x90, 0x12, 0x34, 0x56]", "", "" }
2019-12-16T10:43:41.6502640Z      |
2019-12-16T10:43:41.6506943Z      = help: add `#![feature(const_int_conversion)]` to the crate attributes to enable
2019-12-16T10:43:41.6507015Z 
2019-12-16T10:43:41.6507015Z 
2019-12-16T10:43:41.7375717Z error: `num::<impl i128>::to_ne_bytes` is not yet stable as a const fn
2019-12-16T10:43:41.7376105Z     --> src/libcore/num/mod.rs:2217:17
2019-12-16T10:43:41.7376612Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:41.7376612Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:41.7377169Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:41.7377584Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:41.7378083Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:41.7378369Z ...    |
2019-12-16T10:43:41.7378689Z 2217 | |                 self.to_be().to_ne_bytes()
2019-12-16T10:43:41.7379271Z ...    |
2019-12-16T10:43:41.7379555Z 2406 | |     }
2019-12-16T10:43:41.7380162Z 2407 | | }
2019-12-16T10:43:41.7380594Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:41.7380594Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:41.7380783Z ...
2019-12-16T10:43:41.7381127Z 2438 | /     int_impl! { i128, i128, u128, 128, -170141183460469231731687303715884105728,
2019-12-16T10:43:41.7381437Z 2439 | |     170141183460469231731687303715884105727, "", "", 16,
2019-12-16T10:43:41.7381778Z 2440 | |     "0x13f40000000000000000000000004f76", "0x4f7613f4", "0x12345678901234567890123456789012",
2019-12-16T10:43:41.7382128Z 2441 | |     "0x12907856341290785634129078563412", "0x48091e6a2c48091e6a2c48091e6a2c48",
2019-12-16T10:43:41.7382341Z ...    |
2019-12-16T10:43:41.7382673Z 2444 | |     "[0x12, 0x34, 0x56, 0x78, 0x90, 0x12, 0x34, 0x56, \
2019-12-16T10:43:41.7382986Z 2445 | |       0x78, 0x90, 0x12, 0x34, 0x56, 0x78, 0x90, 0x12]", "", "" }
2019-12-16T10:43:41.7383512Z      |
2019-12-16T10:43:41.7383780Z      = help: add `#![feature(const_int_conversion)]` to the crate attributes to enable
2019-12-16T10:43:41.7387815Z 
2019-12-16T10:43:41.7387815Z 
2019-12-16T10:43:41.8053687Z error: `num::<impl isize>::to_ne_bytes` is not yet stable as a const fn
2019-12-16T10:43:41.8054071Z     --> src/libcore/num/mod.rs:2217:17
2019-12-16T10:43:41.8055097Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:41.8055097Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:41.8055501Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:41.8055889Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:41.8056204Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:41.8056432Z ...    |
2019-12-16T10:43:41.8056867Z 2217 | |                 self.to_be().to_ne_bytes()
2019-12-16T10:43:41.8057401Z ...    |
2019-12-16T10:43:41.8057687Z 2406 | |     }
2019-12-16T10:43:41.8057949Z 2407 | | }
2019-12-16T10:43:41.8058251Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:41.8058251Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:41.8058442Z ...
2019-12-16T10:43:41.8058789Z 2468 | /     int_impl! { isize, i64, u64, 64, -9223372036854775808, 9223372036854775807, "", "",
2019-12-16T10:43:41.8059187Z 2469 | |     12, "0xaa00000000006e1", "0x6e10aa",  "0x1234567890123456", "0x5634129078563412",
2019-12-16T10:43:41.8059546Z 2470 | |      "0x6a2c48091e6a2c48", "[0x56, 0x34, 0x12, 0x90, 0x78, 0x56, 0x34, 0x12]",
2019-12-16T10:43:41.8059871Z 2471 | |      "[0x12, 0x34, 0x56, 0x78, 0x90, 0x12, 0x34, 0x56]",
2019-12-16T10:43:41.8060765Z 2472 | |      usize_isize_to_xe_bytes_doc!(), usize_isize_from_xe_bytes_doc!() }
2019-12-16T10:43:41.8061403Z      |
2019-12-16T10:43:41.8061723Z      = help: add `#![feature(const_int_conversion)]` to the crate attributes to enable
2019-12-16T10:43:41.8066753Z 
2019-12-16T10:43:41.8066753Z 
2019-12-16T10:43:41.8861515Z error: `num::<impl i8>::to_ne_bytes` is not yet stable as a const fn
2019-12-16T10:43:41.8861873Z     --> src/libcore/num/mod.rs:2241:17
2019-12-16T10:43:41.8862580Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:41.8862580Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:41.8862948Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:41.8863656Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:41.8864039Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:41.8864606Z 2241 | |                 self.to_le().to_ne_bytes()
2019-12-16T10:43:41.8865098Z      | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-12-16T10:43:41.8865342Z ...    |
2019-12-16T10:43:41.8865644Z 2406 | |     }
2019-12-16T10:43:41.8865644Z 2406 | |     }
2019-12-16T10:43:41.8866071Z 2407 | | }
2019-12-16T10:43:41.8866390Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:41.8866617Z ...
2019-12-16T10:43:41.8866994Z 2411 | /     int_impl! { i8, i8, u8, 8, -128, 127, "", "", 2, "-0x7e", "0xa", "0x12", "0x12", "0x48",
2019-12-16T10:43:41.8867334Z 2412 | |     "[0x12]", "[0x12]", "", "" }
2019-12-16T10:43:41.8867884Z      |
2019-12-16T10:43:41.8868227Z      = help: add `#![feature(const_int_conversion)]` to the crate attributes to enable
2019-12-16T10:43:41.8916050Z 
2019-12-16T10:43:41.8916050Z 
2019-12-16T10:43:41.9494062Z error: `num::<impl i16>::to_ne_bytes` is not yet stable as a const fn
2019-12-16T10:43:41.9494411Z     --> src/libcore/num/mod.rs:2241:17
2019-12-16T10:43:41.9495126Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:41.9495126Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:41.9495500Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:41.9495910Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:41.9496269Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:41.9497219Z 2241 | |                 self.to_le().to_ne_bytes()
2019-12-16T10:43:41.9497596Z      | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-12-16T10:43:41.9497861Z ...    |
2019-12-16T10:43:41.9498144Z 2406 | |     }
2019-12-16T10:43:41.9498144Z 2406 | |     }
2019-12-16T10:43:41.9498588Z 2407 | | }
2019-12-16T10:43:41.9498917Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:41.9499278Z ...
2019-12-16T10:43:41.9499701Z 2417 | /     int_impl! { i16, i16, u16, 16, -32768, 32767, "", "", 4, "-0x5ffd", "0x3a", "0x1234", "0x3412",
2019-12-16T10:43:41.9500063Z 2418 | |     "0x2c48", "[0x34, 0x12]", "[0x12, 0x34]", "", "" }
2019-12-16T10:43:41.9500662Z      |
2019-12-16T10:43:41.9500966Z      = help: add `#![feature(const_int_conversion)]` to the crate attributes to enable
2019-12-16T10:43:41.9505362Z 
2019-12-16T10:43:41.9505362Z 
2019-12-16T10:43:42.0292252Z error: `num::<impl i32>::to_ne_bytes` is not yet stable as a const fn
2019-12-16T10:43:42.0292657Z     --> src/libcore/num/mod.rs:2241:17
2019-12-16T10:43:42.0293371Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.0293371Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.0293732Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:42.0294130Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:42.0294466Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:42.0295060Z 2241 | |                 self.to_le().to_ne_bytes()
2019-12-16T10:43:42.0295382Z      | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-12-16T10:43:42.0295617Z ...    |
2019-12-16T10:43:42.0295889Z 2406 | |     }
2019-12-16T10:43:42.0295889Z 2406 | |     }
2019-12-16T10:43:42.0296177Z 2407 | | }
2019-12-16T10:43:42.0296474Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:42.0296680Z ...
2019-12-16T10:43:42.0297075Z 2423 | /     int_impl! { i32, i32, u32, 32, -2147483648, 2147483647, "", "", 8, "0x10000b3", "0xb301",
2019-12-16T10:43:42.0297442Z 2424 | |     "0x12345678", "0x78563412", "0x1e6a2c48", "[0x78, 0x56, 0x34, 0x12]",
2019-12-16T10:43:42.0297758Z 2425 | |     "[0x12, 0x34, 0x56, 0x78]", "", "" }
2019-12-16T10:43:42.0298312Z      |
2019-12-16T10:43:42.0298608Z      = help: add `#![feature(const_int_conversion)]` to the crate attributes to enable
2019-12-16T10:43:42.0302821Z 
2019-12-16T10:43:42.0302821Z 
2019-12-16T10:43:42.0975193Z error: `num::<impl i64>::to_ne_bytes` is not yet stable as a const fn
2019-12-16T10:43:42.0975596Z     --> src/libcore/num/mod.rs:2241:17
2019-12-16T10:43:42.0976102Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.0976102Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.0976483Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:42.0976852Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:42.0977311Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:42.0977888Z 2241 | |                 self.to_le().to_ne_bytes()
2019-12-16T10:43:42.0978213Z      | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-12-16T10:43:42.0978448Z ...    |
2019-12-16T10:43:42.0978721Z 2406 | |     }
2019-12-16T10:43:42.0978721Z 2406 | |     }
2019-12-16T10:43:42.0979010Z 2407 | | }
2019-12-16T10:43:42.0979307Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:42.0979513Z ...
2019-12-16T10:43:42.0979902Z 2430 | /     int_impl! { i64, i64, u64, 64, -9223372036854775808, 9223372036854775807, "", "", 12,
2019-12-16T10:43:42.0980278Z 2431 | |     "0xaa00000000006e1", "0x6e10aa", "0x1234567890123456", "0x5634129078563412",
2019-12-16T10:43:42.0980835Z 2432 | |     "0x6a2c48091e6a2c48", "[0x56, 0x34, 0x12, 0x90, 0x78, 0x56, 0x34, 0x12]",
2019-12-16T10:43:42.0981216Z 2433 | |     "[0x12, 0x34, 0x56, 0x78, 0x90, 0x12, 0x34, 0x56]", "", "" }
2019-12-16T10:43:42.0981826Z      |
2019-12-16T10:43:42.0982148Z      = help: add `#![feature(const_int_conversion)]` to the crate attributes to enable
2019-12-16T10:43:42.0986000Z 
2019-12-16T10:43:42.0986000Z 
2019-12-16T10:43:42.1597839Z error: `num::<impl i128>::to_ne_bytes` is not yet stable as a const fn
2019-12-16T10:43:42.1598221Z     --> src/libcore/num/mod.rs:2241:17
2019-12-16T10:43:42.1598755Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.1598755Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.1599307Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:42.1599897Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:42.1600301Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:42.1600864Z 2241 | |                 self.to_le().to_ne_bytes()
2019-12-16T10:43:42.1601373Z      | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-12-16T10:43:42.1601610Z ...    |
2019-12-16T10:43:42.1602045Z 2406 | |     }
2019-12-16T10:43:42.1602045Z 2406 | |     }
2019-12-16T10:43:42.1602333Z 2407 | | }
2019-12-16T10:43:42.1602640Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:42.1602860Z ...
2019-12-16T10:43:42.1603228Z 2438 | /     int_impl! { i128, i128, u128, 128, -170141183460469231731687303715884105728,
2019-12-16T10:43:42.1603573Z 2439 | |     170141183460469231731687303715884105727, "", "", 16,
2019-12-16T10:43:42.1603987Z 2440 | |     "0x13f40000000000000000000000004f76", "0x4f7613f4", "0x12345678901234567890123456789012",
2019-12-16T10:43:42.1604382Z 2441 | |     "0x12907856341290785634129078563412", "0x48091e6a2c48091e6a2c48091e6a2c48",
2019-12-16T10:43:42.1604792Z ...    |
2019-12-16T10:43:42.1605114Z 2444 | |     "[0x12, 0x34, 0x56, 0x78, 0x90, 0x12, 0x34, 0x56, \
2019-12-16T10:43:42.1605454Z 2445 | |       0x78, 0x90, 0x12, 0x34, 0x56, 0x78, 0x90, 0x12]", "", "" }
2019-12-16T10:43:42.1606026Z      |
2019-12-16T10:43:42.1606374Z      = help: add `#![feature(const_int_conversion)]` to the crate attributes to enable
2019-12-16T10:43:42.1606425Z 
2019-12-16T10:43:42.1606425Z 
2019-12-16T10:43:42.1982955Z error: `num::<impl isize>::to_ne_bytes` is not yet stable as a const fn
2019-12-16T10:43:42.1983336Z     --> src/libcore/num/mod.rs:2241:17
2019-12-16T10:43:42.1983861Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.1983861Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.1984416Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:42.1984784Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:42.1985119Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:42.1985893Z 2241 | |                 self.to_le().to_ne_bytes()
2019-12-16T10:43:42.1986196Z      | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-12-16T10:43:42.1986448Z ...    |
2019-12-16T10:43:42.1986719Z 2406 | |     }
2019-12-16T10:43:42.1986719Z 2406 | |     }
2019-12-16T10:43:42.1987002Z 2407 | | }
2019-12-16T10:43:42.1987421Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:42.1987620Z ...
2019-12-16T10:43:42.1988002Z 2468 | /     int_impl! { isize, i64, u64, 64, -9223372036854775808, 9223372036854775807, "", "",
2019-12-16T10:43:42.1988377Z 2469 | |     12, "0xaa00000000006e1", "0x6e10aa",  "0x1234567890123456", "0x5634129078563412",
2019-12-16T10:43:42.1988741Z 2470 | |      "0x6a2c48091e6a2c48", "[0x56, 0x34, 0x12, 0x90, 0x78, 0x56, 0x34, 0x12]",
2019-12-16T10:43:42.1989095Z 2471 | |      "[0x12, 0x34, 0x56, 0x78, 0x90, 0x12, 0x34, 0x56]",
2019-12-16T10:43:42.1989444Z 2472 | |      usize_isize_to_xe_bytes_doc!(), usize_isize_from_xe_bytes_doc!() }
2019-12-16T10:43:42.1990142Z      |
2019-12-16T10:43:42.1990428Z      = help: add `#![feature(const_int_conversion)]` to the crate attributes to enable
2019-12-16T10:43:42.1994949Z 
2019-12-16T10:43:42.2652789Z error: `intrinsics::transmute` is not yet stable as a const fn
2019-12-16T10:43:42.2652789Z error: `intrinsics::transmute` is not yet stable as a const fn
2019-12-16T10:43:42.2653162Z     --> src/libcore/num/mod.rs:2282:26
2019-12-16T10:43:42.2653397Z      |
2019-12-16T10:43:42.2653698Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.2654154Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:42.2654547Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:42.2655055Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:42.2655609Z 2282 | |                 unsafe { mem::transmute(self) }
2019-12-16T10:43:42.2655907Z      | |                          ^^^^^^^^^^^^^^^^^^^^
2019-12-16T10:43:42.2656146Z ...    |
2019-12-16T10:43:42.2656611Z 2406 | |     }
2019-12-16T10:43:42.2656611Z 2406 | |     }
2019-12-16T10:43:42.2656925Z 2407 | | }
2019-12-16T10:43:42.2657207Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:42.2657421Z ...
2019-12-16T10:43:42.2657770Z 2411 | /     int_impl! { i8, i8, u8, 8, -128, 127, "", "", 2, "-0x7e", "0xa", "0x12", "0x12", "0x48",
2019-12-16T10:43:42.2658084Z 2412 | |     "[0x12]", "[0x12]", "", "" }
2019-12-16T10:43:42.2658734Z      |
2019-12-16T10:43:42.2659043Z      = help: add `#![feature(const_transmute)]` to the crate attributes to enable
2019-12-16T10:43:42.2663263Z 
2019-12-16T10:43:42.3372343Z error: `intrinsics::transmute` is not yet stable as a const fn
2019-12-16T10:43:42.3372343Z error: `intrinsics::transmute` is not yet stable as a const fn
2019-12-16T10:43:42.3375558Z     --> src/libcore/num/mod.rs:2282:26
2019-12-16T10:43:42.3375803Z      |
2019-12-16T10:43:42.3376128Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.3376514Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:42.3377028Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:42.3377393Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:42.3378077Z 2282 | |                 unsafe { mem::transmute(self) }
2019-12-16T10:43:42.3378396Z      | |                          ^^^^^^^^^^^^^^^^^^^^
2019-12-16T10:43:42.3379040Z ...    |
2019-12-16T10:43:42.3379323Z 2406 | |     }
2019-12-16T10:43:42.3379323Z 2406 | |     }
2019-12-16T10:43:42.3379581Z 2407 | | }
2019-12-16T10:43:42.3379870Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:42.3380057Z ...
2019-12-16T10:43:42.3380403Z 2417 | /     int_impl! { i16, i16, u16, 16, -32768, 32767, "", "", 4, "-0x5ffd", "0x3a", "0x1234", "0x3412",
2019-12-16T10:43:42.3380737Z 2418 | |     "0x2c48", "[0x34, 0x12]", "[0x12, 0x34]", "", "" }
2019-12-16T10:43:42.3381445Z      |
2019-12-16T10:43:42.3381882Z      = help: add `#![feature(const_transmute)]` to the crate attributes to enable
2019-12-16T10:43:42.3385435Z 
2019-12-16T10:43:42.4107704Z error: `intrinsics::transmute` is not yet stable as a const fn
2019-12-16T10:43:42.4107704Z error: `intrinsics::transmute` is not yet stable as a const fn
2019-12-16T10:43:42.4108054Z     --> src/libcore/num/mod.rs:2282:26
2019-12-16T10:43:42.4108577Z      |
2019-12-16T10:43:42.4108911Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.4109286Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:42.4109962Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:42.4110334Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:42.4110928Z 2282 | |                 unsafe { mem::transmute(self) }
2019-12-16T10:43:42.4111245Z      | |                          ^^^^^^^^^^^^^^^^^^^^
2019-12-16T10:43:42.4111655Z ...    |
2019-12-16T10:43:42.4111927Z 2406 | |     }
2019-12-16T10:43:42.4111927Z 2406 | |     }
2019-12-16T10:43:42.4112256Z 2407 | | }
2019-12-16T10:43:42.4112584Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:42.4112785Z ...
2019-12-16T10:43:42.4113152Z 2423 | /     int_impl! { i32, i32, u32, 32, -2147483648, 2147483647, "", "", 8, "0x10000b3", "0xb301",
2019-12-16T10:43:42.4113690Z 2424 | |     "0x12345678", "0x78563412", "0x1e6a2c48", "[0x78, 0x56, 0x34, 0x12]",
2019-12-16T10:43:42.4113997Z 2425 | |     "[0x12, 0x34, 0x56, 0x78]", "", "" }
2019-12-16T10:43:42.4114545Z      |
2019-12-16T10:43:42.4116670Z      = help: add `#![feature(const_transmute)]` to the crate attributes to enable
2019-12-16T10:43:42.4167619Z 
2019-12-16T10:43:42.4895126Z error: `intrinsics::transmute` is not yet stable as a const fn
2019-12-16T10:43:42.4895126Z error: `intrinsics::transmute` is not yet stable as a const fn
2019-12-16T10:43:42.4895473Z     --> src/libcore/num/mod.rs:2282:26
2019-12-16T10:43:42.4895718Z      |
2019-12-16T10:43:42.4896015Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.4896375Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:42.4896958Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:42.4897330Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:42.4897900Z 2282 | |                 unsafe { mem::transmute(self) }
2019-12-16T10:43:42.4898205Z      | |                          ^^^^^^^^^^^^^^^^^^^^
2019-12-16T10:43:42.4898457Z ...    |
2019-12-16T10:43:42.4898729Z 2406 | |     }
2019-12-16T10:43:42.4898729Z 2406 | |     }
2019-12-16T10:43:42.4899123Z 2407 | | }
2019-12-16T10:43:42.4899450Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:42.4899648Z ...
2019-12-16T10:43:42.4900008Z 2430 | /     int_impl! { i64, i64, u64, 64, -9223372036854775808, 9223372036854775807, "", "", 12,
2019-12-16T10:43:42.4900393Z 2431 | |     "0xaa00000000006e1", "0x6e10aa", "0x1234567890123456", "0x5634129078563412",
2019-12-16T10:43:42.4900755Z 2432 | |     "0x6a2c48091e6a2c48", "[0x56, 0x34, 0x12, 0x90, 0x78, 0x56, 0x34, 0x12]",
2019-12-16T10:43:42.4901130Z 2433 | |     "[0x12, 0x34, 0x56, 0x78, 0x90, 0x12, 0x34, 0x56]", "", "" }
2019-12-16T10:43:42.4901704Z      |
2019-12-16T10:43:42.4902018Z      = help: add `#![feature(const_transmute)]` to the crate attributes to enable
2019-12-16T10:43:42.4906314Z 
2019-12-16T10:43:42.5550622Z    Compiling unwind v0.0.0 (/checkout/src/libunwind)
2019-12-16T10:43:42.5550622Z    Compiling unwind v0.0.0 (/checkout/src/libunwind)
2019-12-16T10:43:42.5736033Z error: `intrinsics::transmute` is not yet stable as a const fn
2019-12-16T10:43:42.5736373Z     --> src/libcore/num/mod.rs:2282:26
2019-12-16T10:43:42.5736628Z      |
2019-12-16T10:43:42.5736949Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.5737341Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:42.5737728Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:42.5738055Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:42.5738618Z 2282 | |                 unsafe { mem::transmute(self) }
2019-12-16T10:43:42.5739103Z      | |                          ^^^^^^^^^^^^^^^^^^^^
2019-12-16T10:43:42.5739379Z ...    |
2019-12-16T10:43:42.5739670Z 2406 | |     }
2019-12-16T10:43:42.5739670Z 2406 | |     }
2019-12-16T10:43:42.5739935Z 2407 | | }
2019-12-16T10:43:42.5740239Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:42.5740434Z ...
2019-12-16T10:43:42.5740786Z 2438 | /     int_impl! { i128, i128, u128, 128, -170141183460469231731687303715884105728,
2019-12-16T10:43:42.5741261Z 2439 | |     170141183460469231731687303715884105727, "", "", 16,
2019-12-16T10:43:42.5741651Z 2440 | |     "0x13f40000000000000000000000004f76", "0x4f7613f4", "0x12345678901234567890123456789012",
2019-12-16T10:43:42.5742016Z 2441 | |     "0x12907856341290785634129078563412", "0x48091e6a2c48091e6a2c48091e6a2c48",
2019-12-16T10:43:42.5742271Z ...    |
2019-12-16T10:43:42.5742599Z 2444 | |     "[0x12, 0x34, 0x56, 0x78, 0x90, 0x12, 0x34, 0x56, \
2019-12-16T10:43:42.5742957Z 2445 | |       0x78, 0x90, 0x12, 0x34, 0x56, 0x78, 0x90, 0x12]", "", "" }
2019-12-16T10:43:42.5743539Z      |
2019-12-16T10:43:42.5743851Z      = help: add `#![feature(const_transmute)]` to the crate attributes to enable
2019-12-16T10:43:42.5748162Z 
2019-12-16T10:43:42.6452452Z error: `intrinsics::transmute` is not yet stable as a const fn
2019-12-16T10:43:42.6452452Z error: `intrinsics::transmute` is not yet stable as a const fn
2019-12-16T10:43:42.6452801Z     --> src/libcore/num/mod.rs:2282:26
2019-12-16T10:43:42.6453001Z      |
2019-12-16T10:43:42.6453270Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.6453625Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:42.6454154Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:42.6454466Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:42.6454956Z 2282 | |                 unsafe { mem::transmute(self) }
2019-12-16T10:43:42.6455249Z      | |                          ^^^^^^^^^^^^^^^^^^^^
2019-12-16T10:43:42.6455468Z ...    |
2019-12-16T10:43:42.6455710Z 2406 | |     }
2019-12-16T10:43:42.6455710Z 2406 | |     }
2019-12-16T10:43:42.6456131Z 2407 | | }
2019-12-16T10:43:42.6456438Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:42.6456614Z ...
2019-12-16T10:43:42.6456955Z 2468 | /     int_impl! { isize, i64, u64, 64, -9223372036854775808, 9223372036854775807, "", "",
2019-12-16T10:43:42.6457287Z 2469 | |     12, "0xaa00000000006e1", "0x6e10aa",  "0x1234567890123456", "0x5634129078563412",
2019-12-16T10:43:42.6457633Z 2470 | |      "0x6a2c48091e6a2c48", "[0x56, 0x34, 0x12, 0x90, 0x78, 0x56, 0x34, 0x12]",
2019-12-16T10:43:42.6458066Z 2471 | |      "[0x12, 0x34, 0x56, 0x78, 0x90, 0x12, 0x34, 0x56]",
2019-12-16T10:43:42.6458373Z 2472 | |      usize_isize_to_xe_bytes_doc!(), usize_isize_from_xe_bytes_doc!() }
2019-12-16T10:43:42.6458902Z      |
2019-12-16T10:43:42.6459297Z      = help: add `#![feature(const_transmute)]` to the crate attributes to enable
2019-12-16T10:43:42.6463592Z 
2019-12-16T10:43:42.6463592Z 
2019-12-16T10:43:42.7213346Z error: `num::<impl i8>::from_ne_bytes` is not yet stable as a const fn
2019-12-16T10:43:42.7213678Z     --> src/libcore/num/mod.rs:2318:31
2019-12-16T10:43:42.7214151Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.7214151Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.7214486Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:42.7214805Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:42.7215084Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:42.7215323Z ...    |
2019-12-16T10:43:42.7215790Z 2318 | |                 Self::from_be(Self::from_ne_bytes(bytes))
2019-12-16T10:43:42.7216874Z ...    |
2019-12-16T10:43:42.7217307Z 2406 | |     }
2019-12-16T10:43:42.7217579Z 2407 | | }
2019-12-16T10:43:42.7218049Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:42.7218049Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:42.7218253Z ...
2019-12-16T10:43:42.7218802Z 2411 | /     int_impl! { i8, i8, u8, 8, -128, 127, "", "", 2, "-0x7e", "0xa", "0x12", "0x12", "0x48",
2019-12-16T10:43:42.7219157Z 2412 | |     "[0x12]", "[0x12]", "", "" }
2019-12-16T10:43:42.7220360Z      |
2019-12-16T10:43:42.7220636Z      = help: add `#![feature(const_int_conversion)]` to the crate attributes to enable
2019-12-16T10:43:42.7224953Z 
2019-12-16T10:43:42.7224953Z 
2019-12-16T10:43:42.7933539Z error: `num::<impl i16>::from_ne_bytes` is not yet stable as a const fn
2019-12-16T10:43:42.7934253Z     --> src/libcore/num/mod.rs:2318:31
2019-12-16T10:43:42.7934774Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.7934774Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.7935114Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:42.7935470Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:42.7935770Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:42.7936308Z ...    |
2019-12-16T10:43:42.7936637Z 2318 | |                 Self::from_be(Self::from_ne_bytes(bytes))
2019-12-16T10:43:42.7937140Z ...    |
2019-12-16T10:43:42.7937376Z 2406 | |     }
2019-12-16T10:43:42.7937611Z 2407 | | }
2019-12-16T10:43:42.7937885Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:42.7937885Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:42.7938058Z ...
2019-12-16T10:43:42.7938381Z 2417 | /     int_impl! { i16, i16, u16, 16, -32768, 32767, "", "", 4, "-0x5ffd", "0x3a", "0x1234", "0x3412",
2019-12-16T10:43:42.7938711Z 2418 | |     "0x2c48", "[0x34, 0x12]", "[0x12, 0x34]", "", "" }
2019-12-16T10:43:42.7939189Z      |
2019-12-16T10:43:42.7939470Z      = help: add `#![feature(const_int_conversion)]` to the crate attributes to enable
2019-12-16T10:43:42.7943577Z 
2019-12-16T10:43:42.7943577Z 
2019-12-16T10:43:42.8732830Z error: `num::<impl i32>::from_ne_bytes` is not yet stable as a const fn
2019-12-16T10:43:42.8733170Z     --> src/libcore/num/mod.rs:2318:31
2019-12-16T10:43:42.8733651Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.8733651Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.8734142Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:42.8734520Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:42.8734830Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:42.8735043Z ...    |
2019-12-16T10:43:42.8735341Z 2318 | |                 Self::from_be(Self::from_ne_bytes(bytes))
2019-12-16T10:43:42.8735953Z ...    |
2019-12-16T10:43:42.8736389Z 2406 | |     }
2019-12-16T10:43:42.8736629Z 2407 | | }
2019-12-16T10:43:42.8737141Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:42.8737141Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:42.8737338Z ...
2019-12-16T10:43:42.8737703Z 2423 | /     int_impl! { i32, i32, u32, 32, -2147483648, 2147483647, "", "", 8, "0x10000b3", "0xb301",
2019-12-16T10:43:42.8738095Z 2424 | |     "0x12345678", "0x78563412", "0x1e6a2c48", "[0x78, 0x56, 0x34, 0x12]",
2019-12-16T10:43:42.8738421Z 2425 | |     "[0x12, 0x34, 0x56, 0x78]", "", "" }
2019-12-16T10:43:42.8738974Z      |
2019-12-16T10:43:42.8739270Z      = help: add `#![feature(const_int_conversion)]` to the crate attributes to enable
2019-12-16T10:43:42.8743459Z 
2019-12-16T10:43:42.8743459Z 
2019-12-16T10:43:42.9493270Z error: `num::<impl i64>::from_ne_bytes` is not yet stable as a const fn
2019-12-16T10:43:42.9493583Z     --> src/libcore/num/mod.rs:2318:31
2019-12-16T10:43:42.9494150Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.9494150Z 248  | / macro_rules! int_impl {
2019-12-16T10:43:42.9494509Z 249  | |     ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr,
2019-12-16T10:43:42.9495081Z 250  | |      $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr,
2019-12-16T10:43:42.9495416Z 251  | |      $reversed:expr, $le_bytes:expr, $be_bytes:expr,
2019-12-16T10:43:42.9495679Z ...    |
2019-12-16T10:43:42.9496017Z 2318 | |                 Self::from_be(Self::from_ne_bytes(bytes))
2019-12-16T10:43:42.9496822Z ...    |
2019-12-16T10:43:42.9497093Z 2406 | |     }
2019-12-16T10:43:42.9497362Z 2407 | | }
2019-12-16T10:43:42.9497679Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:42.9497679Z      | |_- in this expansion of `int_impl!`
2019-12-16T10:43:42.9497878Z ...
2019-12-16T10:43:42.9498239Z 2430 | /     int_impl! { i64, i64, u64, 64, -9223372036854775808, 9223372036854775807, "", "", 12,
2019-12-16T10:43:42.9498761Z 2431 | |     "0xaa00000000006e1", "0x6e10aa", "0x1234567890123456", "0x5634129078563412",
2019-12-16T10:43:42.9499131Z 2432 | |     "0x6a2c48091e6a2c48", "[0x56, 0x34, 0x12, 0x90, 0x78, 0x56, 0x34, 0x12]",
2019-12-16T10:43:42.9499496Z 2433 | |     "[0x12, 0x34, 0x56, 0x78, 0x90, 0x12, 0x34, 0x56]", "", "" }
2019-12-16T10:43:42.9500065Z      |
---
2019-12-16T10:43:52.5022880Z   local time: Mon Dec 16 10:43:52 UTC 2019
2019-12-16T10:43:52.7744975Z   network time: Mon, 16 Dec 2019 10:43:52 GMT
2019-12-16T10:43:52.7750277Z == end clock drift check ==
2019-12-16T10:43:55.9986058Z 
2019-12-16T10:43:56.0078320Z ##[error]Bash exited with code '1'.
2019-12-16T10:43:56.0107097Z ##[section]Starting: Checkout
2019-12-16T10:43:56.0108583Z ==============================================================================
2019-12-16T10:43:56.0108626Z Task         : Get sources
2019-12-16T10:43:56.0108663Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bjorn3
Copy link
Member Author

bjorn3 commented Dec 16, 2019

I have reverted the changes to libcore, liballoc and libstd for now as they keep needing more feature gates in tests.

@bjorn3
Copy link
Member Author

bjorn3 commented Dec 16, 2019

CI is finally happy.

@bors
Copy link
Contributor

bors commented Dec 23, 2019

☔ The latest upstream changes (presumably #67540) made this pull request unmergeable. Please resolve the merge conflicts.

@bjorn3 bjorn3 force-pushed the less_feature_flags branch from 71a4e9a to dc27594 Compare December 23, 2019 14:36
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-23T14:51:04.7615589Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-23T14:51:05.6838741Z ##[command]git config gc.auto 0
2019-12-23T14:51:05.6841187Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-23T14:51:05.6843311Z ##[command]git config --get-all http.proxy
2019-12-23T14:51:05.6847318Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66498/merge:refs/remotes/pull/66498/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bjorn3 bjorn3 force-pushed the less_feature_flags branch from 9963315 to 2275d0c Compare February 7, 2020 12:59
@bjorn3 bjorn3 force-pushed the less_feature_flags branch from 2275d0c to 5827d78 Compare February 7, 2020 13:00
@bjorn3
Copy link
Member Author

bjorn3 commented Feb 7, 2020

Added the #![recursion_limit = "256"] back.

@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 8, 2020

📌 Commit 5827d78 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 8, 2020
Remove unused feature gates

I think many of the remaining unstable things can be easily be replaced with stable things. I have kept the `#![feature(nll)]` even though it is only necessary in `libstd`, to make regressions of it harder.
@Dylan-DPC-zz
Copy link

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 8, 2020
@bjorn3
Copy link
Member Author

bjorn3 commented Feb 11, 2020

CI passed.

@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 11, 2020

📌 Commit 3e57a0a has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 11, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 11, 2020
Remove unused feature gates

I think many of the remaining unstable things can be easily be replaced with stable things. I have kept the `#![feature(nll)]` even though it is only necessary in `libstd`, to make regressions of it harder.
bors added a commit that referenced this pull request Feb 11, 2020
Rollup of 8 pull requests

Successful merges:

 - #66498 (Remove unused feature gates)
 - #68816 (Tweak borrow error on `FnMut` when `Fn` is expected)
 - #68824 (Enable Control Flow Guard in rustbuild)
 - #69022 (traits: preallocate 2 Vecs of known initial size)
 - #69031 (Use `dyn Trait` more in tests)
 - #69044 (Don't run coherence twice for future-compat lints)
 - #69047 (Don't rustfmt check the vendor directory.)
 - #69055 (Clean up E0307 explanation)

Failed merges:

r? @ghost
@bors bors merged commit 3e57a0a into rust-lang:master Feb 11, 2020
@bjorn3 bjorn3 deleted the less_feature_flags branch February 11, 2020 21:22
@bjorn3 bjorn3 mentioned this pull request Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.