Suggest calling async closure when needed #66239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @Centril |
Centril
reviewed
Nov 9, 2019
Centril
reviewed
Nov 9, 2019
Centril
added
S-waiting-on-author
|
@estebank 👋 :) |
When using an async closure as a value in a place that expects a future, suggest calling the closure. Fix rust-lang#65923.
estebank
force-pushed
the
suggest-async-closure-call
branch
from
1a0703b
to
d7efa5b
Compare
estebank
force-pushed
the
suggest-async-closure-call
branch
from
fa057fd
to
fcf26aa
Compare
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
suggest-async-closure-call
branch
from
fcf26aa
to
614da98
Compare
|
@bors r=Centril |
|
📌 Commit 614da98 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 19, 2019
…, r=Centril Suggest calling async closure when needed When using an async closure as a value in a place that expects a future, suggest calling the closure. Fix rust-lang#65923.
bors
added a commit
that referenced
this pull request
Nov 19, 2019
Rollup of 13 pull requests Successful merges: - #66090 (Misc CI improvements) - #66239 (Suggest calling async closure when needed) - #66430 ([doc] Fix the source code highlighting on source comments) - #66431 (Fix 'type annotations needed' error with opaque types) - #66461 (Add explanation message for E0641) - #66468 (Cleanup Miri SIMD intrinsics) - #66478 (rustc_plugin: Remove the compatibility shim) - #66493 (Add JohnTitor to rustc-guide toolstate notification list) - #66511 (std::error::Chain: remove Copy) - #66512 (Add unix::process::CommandExt::arg0) - #66520 (Disable gdb pretty printer global section on wasm targets) - #66529 (resolve: Give derive helpers highest priority during resolution) - #66536 (Move the definition of `QueryResult` into `plumbing.rs`.) Failed merges: r? @ghost
|
⌛ Testing commit 614da98 with merge 10a0e4c9c274c8cc6476866bbc68f80c664934cb... |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Nov 19, 2019
…, r=Centril Suggest calling async closure when needed When using an async closure as a value in a place that expects a future, suggest calling the closure. Fix rust-lang#65923.
|
@bors retry rolled up. |
bors
added a commit
that referenced
this pull request
Nov 19, 2019
Rollup of 11 pull requests Successful merges: - #66090 (Misc CI improvements) - #66155 (Add long error explanation for E0594) - #66239 (Suggest calling async closure when needed) - #66430 ([doc] Fix the source code highlighting on source comments) - #66431 (Fix 'type annotations needed' error with opaque types) - #66461 (Add explanation message for E0641) - #66493 (Add JohnTitor to rustc-guide toolstate notification list) - #66511 (std::error::Chain: remove Copy) - #66529 (resolve: Give derive helpers highest priority during resolution) - #66536 (Move the definition of `QueryResult` into `plumbing.rs`.) - #66538 (Remove compiler_builtins_lib feature from libstd) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an async closure as a value in a place that expects a future,
suggest calling the closure.
Fix #65923.