Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic arg disambiguation #66104

Merged
merged 6 commits into from
Nov 20, 2019
Merged

Generic arg disambiguation #66104

merged 6 commits into from
Nov 20, 2019

Commits on Nov 18, 2019

  1. resolve: Allow idents to resolve to primitives in the type namespace

    Gabriel Smith committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    041a612 View commit details
    Browse the repository at this point in the history

  2. rustc: hir: Add method to check validity of a Res/Def in a namespace

    Gabriel Smith committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    128ca74 View commit details
    Browse the repository at this point in the history

  3. resolve: late: Check if type arg is really a const arg 

    A path type argument could be a generic const argument due to
limitations as to what we can determine at parsing. We double check just
to be sure by trying to resolve in the type namespace first, and if that
fails we try again in the value namespace. If resolution in the value
namespace succeeds, we have a generic const argument on our hands.
    Gabriel Smith committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    7b4642f View commit details
    Browse the repository at this point in the history

  4. rustc: lowering: Lower type args as const args when resolved in value 

    namespace
    Gabriel Smith committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    fb6cfde View commit details
    Browse the repository at this point in the history

  5. test: const-generics: Update tests removing unrequired braces 

    Braces were left in cases where generic args were in the generic const
paths.
    Gabriel Smith committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    eaf8fd0 View commit details
    Browse the repository at this point in the history

  6. test: Update tests with fallout of changes 

    The error messages of the two tests effected degraded in quality. The
errors no longer suggest types in other modules as they now assume that
the arguments are const args, not type args.
    Gabriel Smith committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    0207a15 View commit details
    Browse the repository at this point in the history