Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a failing UI test for multiple loops of all kinds in a const #66096

Merged
merged 1 commit into from
Nov 5, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions src/test/ui/consts/const-loop.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
const _: i32 = {
let mut x = 0;

while x < 4 {
//~^ ERROR constant contains unimplemented expression type
//~| ERROR constant contains unimplemented expression type
x += 1;
}

while x < 8 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the checker stop before reaching here?

Copy link
Contributor Author

@ecstatic-morse ecstatic-morse Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The current one does. The new one can give much better errors on code like this but enabling it is blocked on #65949.

For background, I was using this file as a test case while working on improving diagnostics for the new checker, and figured it could be merged upstream separately.

x += 1;
}

x
};

const _: i32 = {
let mut x = 0;

for i in 0..4 {
//~^ ERROR constant contains unimplemented expression type
//~| ERROR constant contains unimplemented expression type
//~| ERROR references in constants may only refer to immutable values
//~| ERROR calls in constants are limited to constant functions, tuple
// structs and tuple variants
x += i;
}

for i in 0..4 {
x += i;
}

x
};

const _: i32 = {
let mut x = 0;

loop {
x += 1;
if x == 4 {
//~^ ERROR constant contains unimplemented expression type
//~| ERROR constant contains unimplemented expression type
break;
}
}

loop {
x += 1;
if x == 8 {
break;
}
}

x
};

fn main() {}
60 changes: 60 additions & 0 deletions src/test/ui/consts/const-loop.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
error[E0019]: constant contains unimplemented expression type
--> $DIR/const-loop.rs:4:11
|
LL | while x < 4 {
| ^^^^^

error[E0019]: constant contains unimplemented expression type
--> $DIR/const-loop.rs:4:5
|
LL | / while x < 4 {
LL | |
LL | |
LL | | x += 1;
LL | | }
| |_____^

error[E0015]: calls in constants are limited to constant functions, tuple structs and tuple variants
--> $DIR/const-loop.rs:20:14
|
LL | for i in 0..4 {
| ^^^^

error[E0019]: constant contains unimplemented expression type
--> $DIR/const-loop.rs:20:14
|
LL | for i in 0..4 {
| ^^^^

error[E0017]: references in constants may only refer to immutable values
--> $DIR/const-loop.rs:20:14
|
LL | for i in 0..4 {
| ^^^^ constants require immutable values

error[E0019]: constant contains unimplemented expression type
--> $DIR/const-loop.rs:20:9
|
LL | for i in 0..4 {
| ^

error[E0019]: constant contains unimplemented expression type
--> $DIR/const-loop.rs:41:12
|
LL | if x == 4 {
| ^^^^^^

error[E0019]: constant contains unimplemented expression type
--> $DIR/const-loop.rs:41:9
|
LL | / if x == 4 {
LL | |
LL | |
LL | | break;
LL | | }
| |_________^

error: aborting due to 8 previous errors

Some errors have detailed explanations: E0015, E0017, E0019.
For more information about an error, try `rustc --explain E0015`.